Re: [PATCH v2 4/7] iio: dac: max5821: Drop unused i2c driver data

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 19 May 2026 10:13:06 +0200
Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com> wrote:

> The .driver_data member of the single i2c_device_id array entry is
> unused in the driver. Drop it and also the then unused definition.
> 
> While at it, convert the i2c_device_id array to a better readable named
> initializer.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Applied. 
> ---
>  drivers/iio/dac/max5821.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/dac/max5821.c b/drivers/iio/dac/max5821.c
> index e7e29359f8fe..f3ebbdff5487 100644
> --- a/drivers/iio/dac/max5821.c
> +++ b/drivers/iio/dac/max5821.c
> @@ -26,10 +26,6 @@
>  #define MAX5821_EXTENDED_DAC_A			0x04
>  #define MAX5821_EXTENDED_DAC_B			0x08
>  
> -enum max5821_device_ids {
> -	ID_MAX5821,
> -};
> -
>  struct max5821_data {
>  	struct i2c_client	*client;
>  	unsigned short		vref_mv;
> @@ -332,7 +328,7 @@ static int max5821_probe(struct i2c_client *client)
>  }
>  
>  static const struct i2c_device_id max5821_id[] = {
> -	{ "max5821", ID_MAX5821 },
> +	{ .name = "max5821" },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, max5821_id);