All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Bernd Schubert <bernd@bsbernd.com>
Cc: fuse-devel <fuse-devel@lists.linux.dev>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: [PATCH] libfuse: fix cppcheck warnings in the new mount service code
Date: Tue, 19 May 2026 15:42:47 -0700	[thread overview]
Message-ID: <20260519224247.GC9544@frogsfrogsfrogs> (raw)

From: Darrick J. Wong <djwong@kernel.org>

Fix some cppcheck warnings.  No functional changes.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
Hopefully this clears up the last of the static checker errors with the
fuse service container branch?
---
 util/mount_service.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/util/mount_service.c b/util/mount_service.c
index afb345e8b91dfc..8b0eecf5b00ab2 100644
--- a/util/mount_service.c
+++ b/util/mount_service.c
@@ -882,7 +882,7 @@ static int mount_service_handle_source_cmd(struct mount_service *mo,
 					   const struct fuse_service_packet *p,
 					   size_t psz)
 {
-	struct fuse_service_string_command *oc =
+	const struct fuse_service_string_command *oc =
 			container_of(p, struct fuse_service_string_command, p);
 	char *source;
 
@@ -935,7 +935,8 @@ static int mount_service_handle_mntopts_cmd(struct mount_service *mo,
 	struct fuse_service_string_command *oc =
 			container_of(p, struct fuse_service_string_command, p);
 	char *tokstr = oc->value;
-	char *tok, *savetok;
+	const char *tok;
+	char *savetok;
 	char *mntopts;
 
 	if (psz < sizeof_fuse_service_string_command(1)) {

                 reply	other threads:[~2026-05-19 22:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260519224247.GC9544@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=bernd@bsbernd.com \
    --cc=fuse-devel@lists.linux.dev \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.