From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99E1A4502A for ; Tue, 19 May 2026 22:58:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779231513; cv=none; b=MZii8U5eZHpEOJjtK43YQuim9JV/ep8CgWTD4Y1P0lYTWng2ng4WS0A+ZDRoW4vd/nWg7Ilj0vN8lBy4AXe4nC5mK/z57r3ATJK1pHxs37l0ghQeg9xic9YYDr3RPTKHWsvZbqeFQSa5Yi4Rh3s0uZt5uJwSlkwKQb89YEktntg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779231513; c=relaxed/simple; bh=wg75y48mnLaHgHyQnkKxc/BlrEASPS8X8Fxan1xYnOs=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=OFemQbabMO73bMel02aNOoMW08JjKtRwfQ0uk0YMycQ3XwXLZaO8+L6ZhM7AjGj9+iDXdpRwCShiVu3PC0QeAmxfenTFcQdvrKUz7tS4icdT6kLI3FHLo1OpnQUeSeGuPd9j5L3S9bMEwSRHT7pejc6RZfhqd5S++zq3NpUtqMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=M1SmDrz3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="M1SmDrz3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C41C91F000E9; Tue, 19 May 2026 22:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779231512; bh=ckLWd3Pcv5VS9zUkCSDTjdLnQXXOdrp15i1cta7NHnY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=M1SmDrz3tBUH44wRXHoJBQfWC9HbTxbbcl+xe7Zfup18yLZPVZ0ZwrRsjuMS9/oS8 UD3tM6CSiZvFfOh+z7K77S6DAGC7JCT0vx8HlAeVit2rSFJR2whgw7HFcYHGNE38e4 5enkDsBZRSXHYdFAHD5Ao/Gmi7XiMdKQ4MSe0mU5aVdH8mSJjgVdvmiludXA6zSEbE jpGx7jZdfjiYJxkOxxB9zPDWyu4NQXyY27CcrhWjjQGaJlyOD3POh/HI8TbV9kAPph Ns2l1FoTU+eU2HLxig0EakozmbWmXWaUWW9kcz5/jK2IuU+t+0k2iVem6y223rqQuH UIfdrx+V6d66A== From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 5/6] phy: move and rename Airoha PCIe PHY driver to dedicated directory Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Marangi" Cc: olteanv@gmail.com, conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org In-Reply-To: <20260519220813.28468-6-ansuelsmth@gmail.com> References: <20260519220813.28468-6-ansuelsmth@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 19 May 2026 22:58:31 +0000 Message-Id: <20260519225831.C41C91F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Low] The commit claims to move and rename the Airoha PCIe PHY driver to = a dedicated directory, but fails to delete the original source files, leavi= ng them as dead code in the tree. - [Low] The newly added header file uses the same include guard as the old = file. -- commit 86b6424c6ba53c67472bea2d3d41f8d654e1cb31 Author: Christian Marangi phy: move and rename Airoha PCIe PHY driver to dedicated directory This commit moves the Airoha AN7581 PCIe PHY driver into a dedicated directory and renames the files and config symbols. This change is in preparation for adding other Airoha PHY drivers in the future. [ ... ] > diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile > index f49d83f00a3d8..84062279fa63e 100644 > --- a/drivers/phy/Makefile > +++ b/drivers/phy/Makefile > @@ -7,7 +7,6 @@ obj-$(CONFIG_PHY_COMMON_PROPS) +=3D phy-common-props.o > obj-$(CONFIG_PHY_COMMON_PROPS_TEST) +=3D phy-common-props-test.o > obj-$(CONFIG_GENERIC_PHY) +=3D phy-core.o > obj-$(CONFIG_GENERIC_PHY_MIPI_DPHY) +=3D phy-core-mipi-dphy.o > -obj-$(CONFIG_PHY_AIROHA_PCIE) +=3D phy-airoha-pcie.o [Severity: Low] The commit message states the driver is being moved, but the diff only shows adding the new files in the airoha directory. It doesn't remove the original drivers/phy/phy-airoha-pcie.c and drivers/phy/phy-airoha-pcie-regs.h files. Should these old files be deleted in this patch to avoid leaving uncompiled dead code in the tree? [ ... ] > diff --git a/drivers/phy/airoha/phy-an7581-pcie-regs.h b/drivers/phy/airo= ha/phy-an7581-pcie-regs.h > new file mode 100644 > index 0000000000000..b938a7b468fee > --- /dev/null > +++ b/drivers/phy/airoha/phy-an7581-pcie-regs.h > @@ -0,0 +1,494 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2024 AIROHA Inc > + * Author: Lorenzo Bianconi > + */ > + > +#ifndef _PHY_AIROHA_PCIE_H [Severity: Low] Since the file is being renamed to phy-an7581-pcie-regs.h, should this include guard be updated to match the new filename? Reusing the old guard might cause conflicts, particularly since the old header file was not deleted. > +#define _PHY_AIROHA_PCIE_H > + > +/* CSR_2L */ > +#define REG_CSR_2L_CMN 0x0000 [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260519220813.2846= 8-1-ansuelsmth@gmail.com?part=3D5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BC2CCD4F5B for ; Tue, 19 May 2026 22:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9Drt0XRbcbNsRr0xlhMxhq7MSIZ4PeQTTtONlzCn8h0=; b=yUhbW/c4fiz2ws gNcJHLAAT4mCBzah1tARdFu4apeugStwwZRh0z4sijhpwekLeKSIWZS5dC+q8qQ5FL3hR81/3PZJn yammG9jW6pIsVUVKRgt0EpCucXYMYm+aUJ32K4VDjQZcE15z7Mns4JHQC8Q8frzAjMVjxpwhnee4f S0mx+w8/9e+VcJPFA3I3oPbEfbhE/kPrIDXseEHsKjFU9i6/XPoMbOdSnafF7Xnp4yr+HLZwJOM2V KKXJP8mVYCdogjnrKeOQrbtPbyzeQLOOVYOenI2mhm2WVyNk31riQy6LA1J1nJjVC4O88UtXcB1Bw 12tU8HPPN48QZgOOh2lA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPTOU-000000031FJ-1hC2; Tue, 19 May 2026 22:58:34 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPTOT-000000031F7-1PrT for linux-phy@lists.infradead.org; Tue, 19 May 2026 22:58:33 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 8BCB860216; Tue, 19 May 2026 22:58:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C41C91F000E9; Tue, 19 May 2026 22:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779231512; bh=ckLWd3Pcv5VS9zUkCSDTjdLnQXXOdrp15i1cta7NHnY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=M1SmDrz3tBUH44wRXHoJBQfWC9HbTxbbcl+xe7Zfup18yLZPVZ0ZwrRsjuMS9/oS8 UD3tM6CSiZvFfOh+z7K77S6DAGC7JCT0vx8HlAeVit2rSFJR2whgw7HFcYHGNE38e4 5enkDsBZRSXHYdFAHD5Ao/Gmi7XiMdKQ4MSe0mU5aVdH8mSJjgVdvmiludXA6zSEbE jpGx7jZdfjiYJxkOxxB9zPDWyu4NQXyY27CcrhWjjQGaJlyOD3POh/HI8TbV9kAPph Ns2l1FoTU+eU2HLxig0EakozmbWmXWaUWW9kcz5/jK2IuU+t+0k2iVem6y223rqQuH UIfdrx+V6d66A== From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 5/6] phy: move and rename Airoha PCIe PHY driver to dedicated directory To: "Christian Marangi" Cc: olteanv@gmail.com, conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org In-Reply-To: <20260519220813.28468-6-ansuelsmth@gmail.com> References: <20260519220813.28468-6-ansuelsmth@gmail.com> Date: Tue, 19 May 2026 22:58:31 +0000 Message-Id: <20260519225831.C41C91F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gVGhlIGNvbW1pdCBjbGFp bXMgdG8gbW92ZSBhbmQgcmVuYW1lIHRoZSBBaXJvaGEgUENJZSBQSFkgZHJpdmVyIHRvIGEgZGVk aWNhdGVkIGRpcmVjdG9yeSwgYnV0IGZhaWxzIHRvIGRlbGV0ZSB0aGUgb3JpZ2luYWwgc291cmNl IGZpbGVzLCBsZWF2aW5nIHRoZW0gYXMgZGVhZCBjb2RlIGluIHRoZSB0cmVlLgotIFtMb3ddIFRo ZSBuZXdseSBhZGRlZCBoZWFkZXIgZmlsZSB1c2VzIHRoZSBzYW1lIGluY2x1ZGUgZ3VhcmQgYXMg dGhlIG9sZCBmaWxlLgotLQoKY29tbWl0IDg2YjY0MjRjNmJhNTNjNjc0NzJiZWEyZDNkNDFmOGQ2 NTRlMWNiMzEKQXV0aG9yOiBDaHJpc3RpYW4gTWFyYW5naSA8YW5zdWVsc210aEBnbWFpbC5jb20+ CgpwaHk6IG1vdmUgYW5kIHJlbmFtZSBBaXJvaGEgUENJZSBQSFkgZHJpdmVyIHRvIGRlZGljYXRl ZCBkaXJlY3RvcnkKClRoaXMgY29tbWl0IG1vdmVzIHRoZSBBaXJvaGEgQU43NTgxIFBDSWUgUEhZ IGRyaXZlciBpbnRvIGEgZGVkaWNhdGVkCmRpcmVjdG9yeSBhbmQgcmVuYW1lcyB0aGUgZmlsZXMg YW5kIGNvbmZpZyBzeW1ib2xzLiBUaGlzIGNoYW5nZSBpcwppbiBwcmVwYXJhdGlvbiBmb3IgYWRk aW5nIG90aGVyIEFpcm9oYSBQSFkgZHJpdmVycyBpbiB0aGUgZnV0dXJlLgoKWyAuLi4gXQoKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvTWFrZWZpbGUgYi9kcml2ZXJzL3BoeS9NYWtlZmlsZQo+ IGluZGV4IGY0OWQ4M2YwMGEzZDguLjg0MDYyMjc5ZmE2M2UgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9waHkvTWFrZWZpbGUKPiArKysgYi9kcml2ZXJzL3BoeS9NYWtlZmlsZQo+IEBAIC03LDcgKzcs NiBAQCBvYmotJChDT05GSUdfUEhZX0NPTU1PTl9QUk9QUykJCSs9IHBoeS1jb21tb24tcHJvcHMu bwo+ICBvYmotJChDT05GSUdfUEhZX0NPTU1PTl9QUk9QU19URVNUKQkrPSBwaHktY29tbW9uLXBy b3BzLXRlc3Qubwo+ICBvYmotJChDT05GSUdfR0VORVJJQ19QSFkpCQkrPSBwaHktY29yZS5vCj4g IG9iai0kKENPTkZJR19HRU5FUklDX1BIWV9NSVBJX0RQSFkpCSs9IHBoeS1jb3JlLW1pcGktZHBo eS5vCj4gLW9iai0kKENPTkZJR19QSFlfQUlST0hBX1BDSUUpCQkrPSBwaHktYWlyb2hhLXBjaWUu bwoKW1NldmVyaXR5OiBMb3ddClRoZSBjb21taXQgbWVzc2FnZSBzdGF0ZXMgdGhlIGRyaXZlciBp cyBiZWluZyBtb3ZlZCwgYnV0IHRoZSBkaWZmIG9ubHkgc2hvd3MKYWRkaW5nIHRoZSBuZXcgZmls ZXMgaW4gdGhlIGFpcm9oYSBkaXJlY3RvcnkuIEl0IGRvZXNuJ3QgcmVtb3ZlIHRoZSBvcmlnaW5h bApkcml2ZXJzL3BoeS9waHktYWlyb2hhLXBjaWUuYyBhbmQgZHJpdmVycy9waHkvcGh5LWFpcm9o YS1wY2llLXJlZ3MuaCBmaWxlcy4KU2hvdWxkIHRoZXNlIG9sZCBmaWxlcyBiZSBkZWxldGVkIGlu IHRoaXMgcGF0Y2ggdG8gYXZvaWQgbGVhdmluZyB1bmNvbXBpbGVkCmRlYWQgY29kZSBpbiB0aGUg dHJlZT8KClsgLi4uIF0KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L2Fpcm9oYS9waHktYW43 NTgxLXBjaWUtcmVncy5oIGIvZHJpdmVycy9waHkvYWlyb2hhL3BoeS1hbjc1ODEtcGNpZS1yZWdz LmgKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAwMDAwMDAuLmI5MzhhN2I0 NjhmZWUKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvZHJpdmVycy9waHkvYWlyb2hhL3BoeS1hbjc1 ODEtcGNpZS1yZWdzLmgKPiBAQCAtMCwwICsxLDQ5NCBAQAo+ICsvLyBTUERYLUxpY2Vuc2UtSWRl bnRpZmllcjogR1BMLTIuMC1vbmx5Cj4gKy8qCj4gKyAqIENvcHlyaWdodCAoYykgMjAyNCBBSVJP SEEgSW5jCj4gKyAqIEF1dGhvcjogTG9yZW56byBCaWFuY29uaSA8bG9yZW56b0BrZXJuZWwub3Jn Pgo+ICsgKi8KPiArCj4gKyNpZm5kZWYgX1BIWV9BSVJPSEFfUENJRV9ICgpbU2V2ZXJpdHk6IExv d10KU2luY2UgdGhlIGZpbGUgaXMgYmVpbmcgcmVuYW1lZCB0byBwaHktYW43NTgxLXBjaWUtcmVn cy5oLCBzaG91bGQgdGhpcwppbmNsdWRlIGd1YXJkIGJlIHVwZGF0ZWQgdG8gbWF0Y2ggdGhlIG5l dyBmaWxlbmFtZT8gUmV1c2luZyB0aGUgb2xkIGd1YXJkCm1pZ2h0IGNhdXNlIGNvbmZsaWN0cywg cGFydGljdWxhcmx5IHNpbmNlIHRoZSBvbGQgaGVhZGVyIGZpbGUgd2FzIG5vdApkZWxldGVkLgoK PiArI2RlZmluZSBfUEhZX0FJUk9IQV9QQ0lFX0gKPiArCj4gKy8qIENTUl8yTCAqLwo+ICsjZGVm aW5lIFJFR19DU1JfMkxfQ01OCQkJCTB4MDAwMAoKWyAuLi4gXQoKLS0gClNhc2hpa28gQUkgcmV2 aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDUxOTIyMDgxMy4yODQ2 OC0xLWFuc3VlbHNtdGhAZ21haWwuY29tP3BhcnQ9NQoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxp c3QKbGludXgtcGh5QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcGh5Cg==