From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9075DCD4F3C for ; Wed, 20 May 2026 08:30:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EHBv0AZ8AvtVs2b4tglHJu0bAHteu0Q2DK6yYMnWEFw=; b=GfbyrEOnap1kpVof72nJFxhrXo OtIBKOXUAcd0X8KPE9Zm3G3rCZM0jAw4GjRXcaxBtnxy9eRk5z1wWBl50EIvDGXe2dY7n7qYFL5Na yo+HDjR5rGp9IjpEBQ/1RBnJ3roYzP/WMRhYnes2dsIq+4bBfE8b8SyMVCeTelEtTZLm5s7Wn5B0m nD+NGijuO9bqYt5LXVR0HmQZbUYXneo2EUj/WzCpxLWoRMNIV6uheJnPOh+ItT3+jbmkZjOcINv1Y Y16cFRpp7t38dUchXnbnWDj/m/ZB2V2c2wXNH3OIcpFHn9d9OdXK72NT8pS6tsvs5rbxDNsQj/I7k tml+VMnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPcKM-00000003xdR-1gr9; Wed, 20 May 2026 08:30:54 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPcKJ-00000003xci-2lHd for linux-nvme@lists.infradead.org; Wed, 20 May 2026 08:30:52 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id A580068BFE; Wed, 20 May 2026 10:30:44 +0200 (CEST) Date: Wed, 20 May 2026 10:30:43 +0200 From: Christoph Hellwig To: Pavel Begunkov Cc: Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , Alexander Viro , Christian Brauner , Andrew Morton , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Nitesh Shetty , Kanchan Joshi , Anuj Gupta , Tushar Gohad , William Power , Phil Cayton , Jason Gunthorpe Subject: Re: [PATCH v3 04/10] block: introduce dma map backed bio type Message-ID: <20260520083043.GA18893@lst.de> References: <646ecd6fde8d9e146cb051efb514deb27ce3883e.1777475843.git.asml.silence@gmail.com> <20260513081929.GD5477@lst.de> <24833f76-2289-4859-86d1-9215b11a1258@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24833f76-2289-4859-86d1-9215b11a1258@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260520_013051_841598_C955D62A X-CRM114-Status: GOOD ( 18.03 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, May 18, 2026 at 11:29:54AM +0100, Pavel Begunkov wrote: >>> BIO_ZONE_WRITE_PLUGGING, /* bio handled through zone write plugging */ >>> BIO_EMULATES_ZONE_APPEND, /* bio emulates a zone append operation */ >>> + BIO_DMABUF_MAP, /* Using premmaped dma buffers */ >> >> Shouldn't this be a REQ_ flag as we should never mix and match bios with >> and without this flag in a single request? > > Do you mean adding both and propagating it from bio to req? submit_bio() > takes a bio, so we still need to set it there before it reaches blk-mq. > And there might be bio-based drivers using it in the future. I think I forgot to reply to this, so let's do this now. REQ_ is actually used by both bios and requests, so if you set it in bio->bi_opf it will automatically get propagated to the request, but it can also always be tested on the bio, including by bio-based drivers.