From: Alex Williamson <alex.williamson@nvidia.com>
To: Eric Curtin <ericcurtin17@gmail.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Ankit Agrawal <ankita@nvidia.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Yishai Hadas <yishaih@nvidia.com>,
Shameer Kolothum <skolothumtho@nvidia.com>,
Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH] vfio/nvgrace-gpu: add GB10 device ID (0x2e12)
Date: Wed, 20 May 2026 09:47:46 -0600 [thread overview]
Message-ID: <20260520094746.660ed777@nvidia.com> (raw)
In-Reply-To: <20260519194545.41503-1-ericcurtin17@gmail.com>
On Tue, 19 May 2026 20:45:45 +0100
Eric Curtin <ericcurtin17@gmail.com> wrote:
> The NVIDIA GB10 GPU (device ID 0x2e12, found in DGX GB10 systems) is a
> Grace-Blackwell chip that shares the same NVLink-C2C coherent memory
> architecture as the existing GH200/GB200/GB300 entries. It exposes
> CPU-coherent device memory via the ACPI DSD properties
> nvidia,gpu-mem-base-pa / nvidia,gpu-mem-size and requires the same
> specialised BAR emulation provided by nvgrace-gpu-vfio-pci.
>
> Without this entry the device falls through to the generic vfio-pci
> driver, which fails the iommufd IOMMU_RESV_DIRECT check because the
> NVLink-C2C memory apertures appear as RESV_DIRECT in the IOMMU group
> reserved regions, yielding:
>
> vfio-pci 000f:01:00.0: Firmware has requested this device have a
> 1:1 IOMMU mapping, rejecting configuring the device without a 1:1
> mapping. Contact your platform vendor.
>
> Tested on a DGX GB10 system (aarch64, kernel 6.17.0-1014-nvidia).
This is proposing a patch against upstream v7.1-rc, not a vendor or
downstream kernel. What relevant testing against upstream has been
performed?
It's unclear to me how using the nvgrace-gpu driver rather than
vfio-pci gets around a RESV_DIRECT mapping requirement on the IOMMU
group. Can you elaborate?
The requirement is enforced when setting the group to a container for
the legacy path or when binding the device when using iommufd. Both of
those occur irrespective of using vfio-pci or a variant driver.
I also don't find that a DGX Spark GB10 exposes the ACPI DSD properties
claimed here, so while the architecture may be similar, the support for
the nvgrace-gpu specific functionality doesn't appear to be present.
Thanks,
Alex
> Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
> ---
> drivers/vfio/pci/nvgrace-gpu/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/vfio/pci/nvgrace-gpu/main.c b/drivers/vfio/pci/nvgrace-gpu/main.c
> index fa056b69f899..ac1acf41df86 100644
> --- a/drivers/vfio/pci/nvgrace-gpu/main.c
> +++ b/drivers/vfio/pci/nvgrace-gpu/main.c
> @@ -1244,6 +1244,8 @@ static const struct pci_device_id nvgrace_gpu_vfio_pci_table[] = {
> { PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_NVIDIA, 0x2941) },
> /* GB300 SKU */
> { PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_NVIDIA, 0x31C2) },
> + /* GB10 SKU */
> + { PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_NVIDIA, 0x2E12) },
> {}
> };
>
prev parent reply other threads:[~2026-05-20 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 19:45 [PATCH] vfio/nvgrace-gpu: add GB10 device ID (0x2e12) Eric Curtin
2026-05-20 15:47 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520094746.660ed777@nvidia.com \
--to=alex.williamson@nvidia.com \
--cc=ankita@nvidia.com \
--cc=ericcurtin17@gmail.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skolothumtho@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.