From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA82A3E122D; Wed, 20 May 2026 12:38:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779280682; cv=none; b=UHIzOngCox4Gtn6MVMIlWtbIK+agUUyGwO4m593G9nl6le4q6/NuA0ox20AvhBUmsiBP1nWIIq+uMoKWDxMlxsdsFsJdGT/N6oNAbehvitX/+jBmGWUab+M0BJqAaDf3wO1EsrRqHpIXTrO4JLRBBm+t9LjMfzKcVOt/UYvlMB4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779280682; c=relaxed/simple; bh=J/crzavrYHIn1d+gW2ScGAtX27fA6aHmmfZp3AwtM2s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u1rV6Ie+X/cVTTpGvdecXTIDVttUxuZX9LfLX8rRQ0HlWhjX4QeVC5S4onLmLbx99iSHBrwcZurV1BmGbbL+kl5NS5l+9hgG5Nxt9ysmcWkok4BCOx9p8piXIYTwx3Evg3KShrA2IW7Hph4SGgSKW+yhMMaFCgr06nmuldXEqDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SUkVW4Tz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SUkVW4Tz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F9231F000E9; Wed, 20 May 2026 12:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779280680; bh=VpHBl5t/VGkWUCdWGO0BSnsIrLjhVZANk3wAFYMTAUk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=SUkVW4TzrSEHkRKhjpwkCgR9+l7/kyskC1KL6846qbfM5dI1NpUKyXYjjZjcqsQVD 8wyQdH5upJ/CZv4xWRgb2OcF67ZOEKLKY6IKYd9xGdEz/cu938mc3Qw0iK17zwVqzU f+7uNr/AoOAhj/w6se+oX1k8znWlL68hh7RqDE3fMadk/dIjA/IDqxNa+fF/34ynnr zau2L6KrFmv9PXq3pa2ylVDzBQiFetIWoXypeH98AZ0b1ck5THLICjCgQck5mv+Adf LbSd8kikdQ38sKIAYaQpCEAzL7BYISOaN6BPNRZfwu3F3NEbrjYPhG7cViKtKDpVU8 tsfB2JnRy2JTg== From: Andrey Albershteyn To: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev, linux-fsdevel@vger.kernel.org, ebiggers@kernel.org Cc: Andrey Albershteyn , hch@lst.de, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-btrfs@vger.kernel.org, linux-unionfs@vger.kernel.org, djwong@kernel.org Subject: [PATCH v10 13/22] xfs: disable direct read path for fs-verity files Date: Wed, 20 May 2026 14:37:11 +0200 Message-ID: <20260520123722.405752-14-aalbersh@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260520123722.405752-1-aalbersh@kernel.org> References: <20260520123722.405752-1-aalbersh@kernel.org> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The direct path is not supported on verity files. Attempts to use direct I/O path on such files should fall back to buffered I/O path. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: Andrey Albershteyn --- fs/xfs/xfs_file.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index e3f4353b3b78..2ef946e3f46f 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -282,7 +282,8 @@ xfs_file_dax_read( struct kiocb *iocb, struct iov_iter *to) { - struct xfs_inode *ip = XFS_I(iocb->ki_filp->f_mapping->host); + struct inode *inode = iocb->ki_filp->f_mapping->host; + struct xfs_inode *ip = XFS_I(inode); ssize_t ret = 0; trace_xfs_file_dax_read(iocb, to); @@ -333,6 +334,14 @@ xfs_file_read_iter( if (xfs_is_shutdown(mp)) return -EIO; + /* + * In case fs-verity is enabled, we also fallback to the buffered read + * from the direct read path. Therefore, IOCB_DIRECT is set and need to + * be cleared (see generic_file_read_iter()) + */ + if (fsverity_active(inode)) + iocb->ki_flags &= ~IOCB_DIRECT; + if (IS_DAX(inode)) ret = xfs_file_dax_read(iocb, to); else if (iocb->ki_flags & IOCB_DIRECT) -- 2.51.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53D80CD5BA6 for ; Wed, 20 May 2026 12:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:MIME-Version:References:In-Reply-To: Message-ID:Date:To:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3IwpZWMPuUaD4QQLROJ5s775XtsRajsTUx8SMf4UvOM=; b=itNX8XpjAhsNxamBfVQCAyGg59 ivfw+Xl0tCyeOY3YgkT7gzLZmB71VRJbfPixfxUSDCTnujFovd+/EPet/svqAez4HBg3Rm02ZzRK2 ODENR9Ic8U76OnVj4Z4WzwN6oINxrXgC+QfuQkZvzdehGXI6VF++xtrfej6UIcKb3SL0=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wPgBl-00071f-DK; Wed, 20 May 2026 12:38:14 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wPgBi-00071M-LM for linux-f2fs-devel@lists.sourceforge.net; Wed, 20 May 2026 12:38:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VpHBl5t/VGkWUCdWGO0BSnsIrLjhVZANk3wAFYMTAUk=; b=FNJVbmXnqB2JpO0PudpWF9754N /1gA48zHCa0QuiDx3wwOskRHY4snsyAZdQschbBjqU8WPXUwcfRt3DpCOYD9Op/GjT60ZtcIxBl7X cSuMEOlupmN269zNOqvYanmTgShdAdTwwbGNWWAPbYG9ECjbYyFLh5nDvLt0NqBbeSl4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VpHBl5t/VGkWUCdWGO0BSnsIrLjhVZANk3wAFYMTAUk=; b=Dn0gZ9nCJBWmqIm0TBhM8FvYOp L/kfpu65D6O1toN1Mdkehgu4S4vNGZZnVqTwuiENeprtxQZhxADCAr+tOBMs6r2JlajMbAcD3csGl Uh27WZw83g2XRz6N9lVk2h8sN7UQ91Q/vUoMGt6/uSrG7yJU0AZfsWPOYEyNXky/FdWg=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wPgBe-0006ag-7h for linux-f2fs-devel@lists.sourceforge.net; Wed, 20 May 2026 12:38:12 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 7292642B77; Wed, 20 May 2026 12:38:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F9231F000E9; Wed, 20 May 2026 12:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779280680; bh=VpHBl5t/VGkWUCdWGO0BSnsIrLjhVZANk3wAFYMTAUk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=SUkVW4TzrSEHkRKhjpwkCgR9+l7/kyskC1KL6846qbfM5dI1NpUKyXYjjZjcqsQVD 8wyQdH5upJ/CZv4xWRgb2OcF67ZOEKLKY6IKYd9xGdEz/cu938mc3Qw0iK17zwVqzU f+7uNr/AoOAhj/w6se+oX1k8znWlL68hh7RqDE3fMadk/dIjA/IDqxNa+fF/34ynnr zau2L6KrFmv9PXq3pa2ylVDzBQiFetIWoXypeH98AZ0b1ck5THLICjCgQck5mv+Adf LbSd8kikdQ38sKIAYaQpCEAzL7BYISOaN6BPNRZfwu3F3NEbrjYPhG7cViKtKDpVU8 tsfB2JnRy2JTg== To: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev, linux-fsdevel@vger.kernel.org, ebiggers@kernel.org Date: Wed, 20 May 2026 14:37:11 +0200 Message-ID: <20260520123722.405752-14-aalbersh@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260520123722.405752-1-aalbersh@kernel.org> References: <20260520123722.405752-1-aalbersh@kernel.org> MIME-Version: 1.0 X-Headers-End: 1wPgBe-0006ag-7h Subject: [f2fs-dev] [PATCH v10 13/22] xfs: disable direct read path for fs-verity files X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrey Albershteyn via Linux-f2fs-devel Reply-To: Andrey Albershteyn Cc: Andrey Albershteyn , djwong@kernel.org, linux-unionfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, hch@lst.de, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net The direct path is not supported on verity files. Attempts to use direct I/O path on such files should fall back to buffered I/O path. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: Andrey Albershteyn --- fs/xfs/xfs_file.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index e3f4353b3b78..2ef946e3f46f 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -282,7 +282,8 @@ xfs_file_dax_read( struct kiocb *iocb, struct iov_iter *to) { - struct xfs_inode *ip = XFS_I(iocb->ki_filp->f_mapping->host); + struct inode *inode = iocb->ki_filp->f_mapping->host; + struct xfs_inode *ip = XFS_I(inode); ssize_t ret = 0; trace_xfs_file_dax_read(iocb, to); @@ -333,6 +334,14 @@ xfs_file_read_iter( if (xfs_is_shutdown(mp)) return -EIO; + /* + * In case fs-verity is enabled, we also fallback to the buffered read + * from the direct read path. Therefore, IOCB_DIRECT is set and need to + * be cleared (see generic_file_read_iter()) + */ + if (fsverity_active(inode)) + iocb->ki_flags &= ~IOCB_DIRECT; + if (IS_DAX(inode)) ret = xfs_file_dax_read(iocb, to); else if (iocb->ki_flags & IOCB_DIRECT) -- 2.51.2 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel