Re: [RFC PATCH 14/14] selftests/damon/sysfs.sh: test pause file existence

[SeongJae Park <sj@kernel.org>]

On Wed, 20 May 2026 06:42:52 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The newly added test for the 'pause' file passes the typoed string 'exit' instead of 'exist' to `ensure_file()`, causing the test to silently do nothing.
> --
> 
> commit dfd394f0319e5426a9139ffa02a782a34b43e8ff
> Author: SeongJae Park <sj@kernel.org>
> 
> selftests/damon/sysfs.sh: test pause file existence
> 
> This commit adds a test to ensure the 'pause' sysfs file exists in DAMON's
> sysfs interface.
> 
> > diff --git a/tools/testing/selftests/damon/sysfs.sh b/tools/testing/selftests/damon/sysfs.sh
> > --- a/tools/testing/selftests/damon/sysfs.sh
> > +++ b/tools/testing/selftests/damon/sysfs.sh
> > @@ -366,6 +366,7 @@ test_context()
> >  	ensure_file "$context_dir/avail_operations" "exit" 400
> >  	ensure_file "$context_dir/operations" "exist" 600
> >  	ensure_file "$context_dir/addr_unit" "exit" 600
> > +	ensure_file "$context_dir/pause" "exit" 600
> 
> [Severity: Medium]
> Is this test unintentionally bypassed? The helper function ensure_file()
> checks for the strings "exist" or "not_exist" to determine what checks
> to perform. Because "exit" is passed instead of "exist", the function
> evaluates neither condition and returns immediately.
> 
> This prevents the test from verifying the file's presence or its
> permissions, causing it to silently do nothing.

Good catch, I will fix this in the next revision.

> 
> >  	test_monitoring_attrs "$context_dir/monitoring_attrs"
> >  	test_targets "$context_dir/targets"
> >  	test_schemes "$context_dir/schemes"
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260520062858.167011-1-sj@kernel.org?part=14


Thanks,
SJ