From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: Willem de Bruijn <willemb@google.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, Simon Horman <horms@kernel.org>,
Dragos Tatulea <dtatulea@nvidia.com>,
Alice Mikityanska <alice@isovalent.com>,
Matthew Schwartz <matthew.schwartz@linux.dev>
Subject: Re: [PATCH net v2 2/2] udp: Fix UDP length on last GSO_PARTIAL segment
Date: Wed, 20 May 2026 15:05:18 -0700 [thread overview]
Message-ID: <20260520150518.2e65eb26@kernel.org> (raw)
In-Reply-To: <f829d309-a4b8-4474-85ab-da5ffffc801a@nvidia.com>
On Wed, 20 May 2026 19:34:17 +0300 Gal Pressman wrote:
> On 20/05/2026 4:12, Jakub Kicinski wrote:
> > On Mon, 18 May 2026 09:22:50 +0300 Gal Pressman wrote:
> >> + if (!skb_is_gso(seg))
> >> + /* last packet can be partial gso_size, account for that in
> >> + * checksum.
> >> + */
> >
> > No need to repost but I think we should tweak this comment.
> > Saying "partial gso_size" when it such segment is in fact
> > not part of GSO_PARTIAL is a bit confusing. How about:
> >
> > /* Unless skb fits perfectly as GSO_PARTIAL, the trailing
> > * segment may not be full MSS, account for that in the checksum
> > */
> >
> > ?
>
> Sounds good, should I submit a patch?
I'll edit, don't want it to miss the PR
next prev parent reply other threads:[~2026-05-20 22:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 6:22 [PATCH net v2 0/2] udp: gso: Fix __udp_gso_segment() after GSO_PARTIAL UDP length change Gal Pressman
2026-05-18 6:22 ` [PATCH net v2 1/2] udp: gso: Fix handling checksum in __udp_gso_segment Gal Pressman
2026-05-18 6:22 ` [PATCH net v2 2/2] udp: Fix UDP length on last GSO_PARTIAL segment Gal Pressman
2026-05-20 1:12 ` Jakub Kicinski
2026-05-20 16:34 ` Gal Pressman
2026-05-20 22:05 ` Jakub Kicinski [this message]
2026-05-20 22:20 ` [PATCH net v2 0/2] udp: gso: Fix __udp_gso_segment() after GSO_PARTIAL UDP length change patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520150518.2e65eb26@kernel.org \
--to=kuba@kernel.org \
--cc=alice@isovalent.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=matthew.schwartz@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.