From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <horms@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, hmohsin@meta.com
Subject: Re: [PATCH net 0/2] net: shaper: fix VALID confusion even more
Date: Wed, 20 May 2026 16:34:00 -0700 [thread overview]
Message-ID: <20260520163400.72c24ef7@kernel.org> (raw)
In-Reply-To: <20260520195428.GA1506108@horms.kernel.org>
On Wed, 20 May 2026 20:54:28 +0100 Simon Horman wrote:
> On Fri, May 15, 2026 at 03:13:23PM -0700, Jakub Kicinski wrote:
> > Sashiko reported another pre-exising issue in the previous
> > batch of fixes:
> > https://sashiko.dev/#/patchset/20260510192904.3987113-7-kuba@kernel.org
> >
> > Turns out I over-esitmated the guarantees of the XArray flags.
> > Stop using them completely.
>
> Sashiko suggests updating the wording of the VALID flag
> comment in net_shaper_pre_insert as part of the second patch.
> But, TBH, I don't feel strongly about that.
It's very picky about these comments.
IMHO the word "mark" is not reserved to exclusively mean xa_mark
in case no xa_mark is used by the code any more.
> For the series:
> Reviewed-by: Simon Horman <horms@kernel.org>
Thanks!
next prev parent reply other threads:[~2026-05-20 23:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 22:13 [PATCH net 0/2] net: shaper: fix VALID confusion even more Jakub Kicinski
2026-05-15 22:13 ` [PATCH net 1/2] net: shaper: annotate the data races Jakub Kicinski
2026-05-15 22:13 ` [PATCH net 2/2] net: shaper: rework the VALID marking (again) Jakub Kicinski
2026-05-20 19:54 ` [PATCH net 0/2] net: shaper: fix VALID confusion even more Simon Horman
2026-05-20 23:34 ` Jakub Kicinski [this message]
2026-05-21 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520163400.72c24ef7@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hmohsin@meta.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.