From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34079CD4F3D for ; Wed, 20 May 2026 18:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tIWY6bDZolerKnu7Agd5wQZ0WBmeeNXVSaShmmP2WSc=; b=H0MdeJycY4LEwz eT9YLAEirteUYnpw2HKqNpE9qZTfmK0Q4XdYJJQHooGOUW54VwT694K77acQ9TpFfMn4iqKnaJb3g /TjCHPOT9l0mrddyau9UKi4NBysc0YbWqQQdlZuGBQxV6FceVBhd95twUj1dc/Cx933tER3A1JlJK WuuC3QH5BhLqR8W9NGtnE3JYprvq/RnYtdVTuW+3d/73K1MOWqcaM5SaQTw3gOW6aXk1J3bW/1O9u bjJbaAZtz7OyIi1ndD7VvFFZ4cPKTV48LwMlkgTK94N7D7Y8iUCxHmsW6QojrZByQSRoYqQOaXJ3Z YQmYf0+/dIusNEGCo2Mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPlZZ-00000005Qw9-1FTm; Wed, 20 May 2026 18:23:13 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPlZY-00000005QvW-0ikN for linux-phy@lists.infradead.org; Wed, 20 May 2026 18:23:12 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 49456601E8; Wed, 20 May 2026 18:23:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF28C1F00894; Wed, 20 May 2026 18:23:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779301391; bh=O8pZXT88JamUOEed+p0VRDdpFezDMQUWHy5KfPCJ8UA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VrO8p/AMcDA4prnhPQKZPU/r0NwjL012ao+Z11dfCzhTxxH88F88NloBkfaivVqKa dw6iv2NYB+xgbQv1V+zhy+X0g+r3ii+kjrMk7oV6Stb0RKqpWMnU1o4GZfumGTtfxC FWtTXBlXMbrhEugq28Tq5RTEkKzjQlAO/gjJAAMGWkx8nS6/4YjdlOnSZV1OFT1D7t +lmd2y+/IDO/V+yJc2Wd/lWoMPSTufw48/kNbu6l6bCD0xQpt9z0Q/XSPtfkyXYZqw cpfOHCCgPz3p4zrzB7z1Dai/hmzLiFPLWW2dgtHkW3DdDPHDt6FjGKOYGEJOVjTJIa QvRzN5LyqhtEQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 1/6] phy: realtek: usb2: introduce vstatus/new_reg_req variables to driver data To: "Rustam Adilov" Cc: neil.armstrong@linaro.org, robh@kernel.org, devicetree@vger.kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org, vkoul@kernel.org, conor+dt@kernel.org In-Reply-To: <20260520175728.720877-2-adilov@disroot.org> References: <20260520175728.720877-2-adilov@disroot.org> Date: Wed, 20 May 2026 18:23:10 +0000 Message-Id: <20260520182310.AF28C1F00894@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBUaGlzIHByb2JsZW0gd2Fzbid0IGludHJvZHVjZWQgYnkgdGhpcyBwYXRjaCwgYnV0 IHRoZSBkcml2ZXIgZmFpbHMgdG8gY2hlY2sgdGhlIHJldHVybiB2YWx1ZSBvZiBgb2ZfaW9tYXAo KWAsIHdoaWNoIGNhbiBsZWFkIHRvIGEgTlVMTCBwb2ludGVyIGRlcmVmZXJlbmNlLgotIFtIaWdo XSBUaGlzIHByb2JsZW0gd2Fzbid0IGludHJvZHVjZWQgYnkgdGhpcyBwYXRjaCwgYnV0IGluY29y cmVjdCBwb2ludGVyIGFyaXRobWV0aWMgb24gYSBgdm9pZCBfX2lvbWVtICpgIHBvaW50ZXIgcmVz dWx0cyBpbiB1bmFsaWduZWQgSS9PIG1lbW9yeSBhY2Nlc3NlcyBmb3IgbXVsdGktcG9ydCBzZXR1 cHMuCi0gW0hpZ2hdIFRoaXMgcHJvYmxlbSB3YXNuJ3QgaW50cm9kdWNlZCBieSB0aGlzIHBhdGNo LCBidXQgSS9PIG1lbW9yeSBtYXBwaW5ncyBjcmVhdGVkIGJ5IGBvZl9pb21hcCgpYCBhcmUgbmV2 ZXIgdW5tYXBwZWQsIGxlYWRpbmcgdG8gcmVzb3VyY2UgbGVha3MuCi0gW0hpZ2hdIFRoaXMgcHJv YmxlbSB3YXNuJ3QgaW50cm9kdWNlZCBieSB0aGlzIHBhdGNoLCBidXQgbXVsdGktcG9ydCBQSFkg Y29uZmlndXJhdGlvbnMgY29uY3VycmVudGx5IG1vZGlmeSBzaGFyZWQgaGFyZHdhcmUgcmVnaXN0 ZXJzIHdpdGhvdXQgc3luY2hyb25pemF0aW9uIG9yIGEgcmVhZC1tb2RpZnktd3JpdGUgY3ljbGUu Ci0tCgpjb21taXQgNzM0NTA3ZWZiNzVhNmJlMTUxZGNkZTM4OWJmYzdmMGUxZGY5NTEzMgpBdXRo b3I6IFJ1c3RhbSBBZGlsb3YgPGFkaWxvdkBkaXNyb290Lm9yZz4KCnBoeTogcmVhbHRlazogdXNi MjogaW50cm9kdWNlIHZzdGF0dXMvbmV3X3JlZ19yZXEgdmFyaWFibGVzIHRvIGRyaXZlciBkYXRh CgpUaGlzIGNvbW1pdCBpbnRyb2R1Y2VzIHZzdGF0dXNfb2Zmc2V0LCB2c3RhdHVzX2J1c3ksIGFu ZCBuZXdfcmVnX3JlcSB2YXJpYWJsZXMgCnRvIHRoZSBkcml2ZXIgZGF0YSB0byBoYW5kbGUgZGlm ZmVyZW50IHJlZ2lzdGVyIG9mZnNldHMgYW5kIGJ1c3kgYml0IApkZWZpbml0aW9ucyBpbiB0aGUg UlRMOTYwN0MgU29DLiBUaGVzZSB2YXJpYWJsZXMgYXJlIGFkZGVkIHRvIHRoZSBleGlzdGluZyAK UEhZIGNvbmZpZ3VyYXRpb24gc3RydWN0dXJlcyBhbmQgYXNzaWduZWQgZGVmYXVsdCB2YWx1ZXMu Cgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9yZWFsdGVrL3BoeS1ydGstdXNiMi5jIGIvZHJp dmVycy9waHkvcmVhbHRlay9waHktcnRrLXVzYjIuYwo+IGluZGV4IDI0ODU1MGVmOThjYWIuLmJk OWVlODk1YjlmOTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9waHkvcmVhbHRlay9waHktcnRrLXVz YjIuYwo+ICsrKyBiL2RyaXZlcnMvcGh5L3JlYWx0ZWsvcGh5LXJ0ay11c2IyLmMKClsgLi4uIF0K Cj4gQEAgLTE5NCwyNSArMjAwLDI2IEBAIHN0YXRpYyBpbnQgcnRrX3BoeV93cml0ZShzdHJ1Y3Qg cGh5X3JlZyAqcGh5X3JlZywgY2hhciBhZGRyLCBjaGFyIGRhdGEpCj4gIAlpbnQgcmV0ID0gMDsK PiAgCj4gIAkvKiB3cml0ZSBkYXRhIHRvIFZTdGF0dXNPdXQyIChkYXRhIG91dHB1dCB0byBwaHkp ICovCj4gLQl3cml0ZWwoKHUzMilkYXRhIDw8IHNoaWZ0X2JpdHMsIHJlZ193cmFwX3ZzdGF0dXMp Owo+ICsJd3JpdGVsKCh1MzIpZGF0YSA8PCBzaGlmdF9iaXRzLAo+ICsJICAgICAgIHJlZ193cmFw X3ZzdGF0dXMgKyBwaHlfcmVnLT52c3RhdHVzX29mZnNldCk7CgpbU2V2ZXJpdHk6IEhpZ2hdClRo aXMgaXMgYSBwcmUtZXhpc3RpbmcgaXNzdWUsIGJ1dCBkb2VzIHdyaXRpbmcgZGlyZWN0bHkgdG8g dGhpcyByZWdpc3Rlcgp3aXRob3V0IGEgcmVhZC1tb2RpZnktd3JpdGUgY3ljbGUgb3ZlcndyaXRl IHRoZSBjb25maWd1cmF0aW9uIGZvciBvdGhlcgpwb3J0cz8KCkluIG11bHRpLXBvcnQgc2V0dXBz LCBhbGwgUEhZIGluc3RhbmNlcyBhcHBlYXIgdG8gc2hhcmUgdGhpcyBzYW1lIGJhc2UKYWRkcmVz cywgYW5kIGEgZGlyZWN0IHdyaXRlbCgpIGNvdWxkIGNsZWFyIHRoZSBiaXRzIGJlbG9uZ2luZyB0 byBvdGhlciBQSFlzLgoKSXMgdGhlcmUgYWxzbyBhIG5lZWQgZm9yIHN5bmNocm9uaXphdGlvbiB0 byBwcmV2ZW50IGNvbmN1cnJlbnQgd3JpdGVzIGFjcm9zcwpkaWZmZXJlbnQgcG9ydHM/Cgo+ICAK PiAtCXJldCA9IHV0bWlfd2FpdF9yZWdpc3RlcihyZWdfZ3VzYjJwaHlhY2MwLCBQSFlfVlNUU19C VVNZLCAwKTsKPiArCXJldCA9IHV0bWlfd2FpdF9yZWdpc3RlcihyZWdfZ3VzYjJwaHlhY2MwLCBw aHlfcmVnLT52c3RhdHVzX2J1c3ksIDApOwo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0OwoK WyAuLi4gXQoKPiBAQCAtOTc0LDYgKzk4Miw5IEBAIHN0YXRpYyBpbnQgcGFyc2VfcGh5X2RhdGEo c3RydWN0IHJ0a19waHkgKnJ0a19waHkpCj4gIAkJcGh5X3BhcmFtZXRlci0+cGh5X3JlZy5yZWdf d3JhcF92c3RhdHVzID0gb2ZfaW9tYXAobnAsIDApOwo+ICAJCXBoeV9wYXJhbWV0ZXItPnBoeV9y ZWcucmVnX2d1c2IycGh5YWNjMCA9IG9mX2lvbWFwKG5wLCAxKSArIGluZGV4OwoKW1NldmVyaXR5 OiBIaWdoXQpUaGlzIGlzbid0IGEgYnVnIGludHJvZHVjZWQgYnkgdGhpcyBwYXRjaCwgYnV0IGRv ZXMgdGhlIGRyaXZlciBuZWVkIHRvCmNoZWNrIHRoZSByZXR1cm4gdmFsdWUgb2Ygb2ZfaW9tYXAo KSBoZXJlPwoKSWYgdGhlIG1hcHBpbmcgZmFpbHMsIHRoaXMgd291bGQgbGVhdmUgdGhlIHBvaW50 ZXJzIGFzIE5VTEwgYW5kIGNhdXNlIGEKZGVyZWZlcmVuY2UgZHVyaW5nIEkvTyBvcGVyYXRpb25z LgoKW1NldmVyaXR5OiBIaWdoXQpUaGlzIGlzIGEgcHJlLWV4aXN0aW5nIGlzc3VlLCBidXQgZG9l cyBhZGRpbmcgaW5kZXggZGlyZWN0bHkgdG8gdGhlCnZvaWQgX19pb21lbSAqIHJldHVybmVkIGJ5 IG9mX2lvbWFwKCkgcmVzdWx0IGluIGV4YWN0bHkgYSAxLWJ5dGUgb2Zmc2V0CndoZW4gaW5kZXgg PiAwPwoKSWYgc28sIHRoaXMgY291bGQgY2F1c2UgYW4gdW5hbGlnbmVkIG1lbW9yeSBhY2Nlc3Mg ZmF1bHQgb24gQVJNCmFyY2hpdGVjdHVyZXMuIFNob3VsZCB0aGUgaW5kZXggYmUgc2NhbGVkIGFw cHJvcHJpYXRlbHk/CgpbU2V2ZXJpdHk6IEhpZ2hdClRoaXMgaXMgYWxzbyBhIHByZS1leGlzdGlu ZyBpc3N1ZSwgYnV0IGRvZXMgdGhlIGRyaXZlciBsZWFrIHRoZXNlIEkvTwptYXBwaW5ncz8KClRo ZSBkcml2ZXIgbWFwcyB0aGUgbWVtb3J5IGhlcmUgdXNpbmcgb2ZfaW9tYXAoKSwgYnV0IHRoZXJl IGRvZXMgbm90CmFwcGVhciB0byBiZSBhIG1hdGNoaW5nIGlvdW5tYXAoKSBpbiB0aGUgZHJpdmVy IGNsZWFudXAgcGF0aHMuIFdvdWxkCnVzaW5nIGRldm1fb2ZfaW9tYXAoKSBwcmV2ZW50IHRoaXMg bGVhaz8KCj4gIAkJcGh5X3BhcmFtZXRlci0+cGh5X3JlZy52c3RhdHVzX2luZGV4ID0gaW5kZXg7 Cj4gKwkJcGh5X3BhcmFtZXRlci0+cGh5X3JlZy52c3RhdHVzX29mZnNldCA9IHBoeV9jZmctPnZz dGF0dXNfb2Zmc2V0Owo+ICsJCXBoeV9wYXJhbWV0ZXItPnBoeV9yZWcudnN0YXR1c19idXN5ID0g cGh5X2NmZy0+dnN0YXR1c19idXN5Owo+ICsJCXBoeV9wYXJhbWV0ZXItPnBoeV9yZWcubmV3X3Jl Z19yZXEgPSBwaHlfY2ZnLT5uZXdfcmVnX3JlcTsKPiAgCj4gIAkJaWYgKG9mX3Byb3BlcnR5X3Jl YWRfYm9vbChucCwgInJlYWx0ZWssaW52ZXJzZS1oc3R4LXN5bmMtY2xvY2siKSkKClsgLi4uIF0K Ci0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQv MjAyNjA1MjAxNzU3MjguNzIwODc3LTEtYWRpbG92QGRpc3Jvb3Qub3JnP3BhcnQ9MQoKLS0gCmxp bnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D961372B31 for ; Wed, 20 May 2026 18:23:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779301392; cv=none; b=S2rJPAmedXujKCd44VYQ7tVGAQlSJYDaVfwJl9kuTyc0vhmQ46J8ofGXjZARXjp4ShTe0lbjRFQVskxr8Dkqht6bWI8cEvp2P+VkkpmmHyOOfIKHxH2eltaVJvCAB5McV34xIxhaT14Qq59SgJMW8ijEil9eseaiyUzw/9pvJM0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779301392; c=relaxed/simple; bh=XeV1aWDitY2Uc/Q25ms4y2sAr3ivbUnsqVyl65VKAB8=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=l2xyDUr/rP+rIFN+fCud1rWL+L4kAzWiEnxrVmJg+PfTg/D051T5TljgaIEn+YhCn0y5O4LSo57a1kS1/dIalWpWavG35Ju6qztrz1+FMw0Bhli73CpCL9wnK9TK+xNnYeE5l+xQLr3TFG7+pXSjftfD3Is3FqHDFsf9D4wLZp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VrO8p/AM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VrO8p/AM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF28C1F00894; Wed, 20 May 2026 18:23:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779301391; bh=O8pZXT88JamUOEed+p0VRDdpFezDMQUWHy5KfPCJ8UA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VrO8p/AMcDA4prnhPQKZPU/r0NwjL012ao+Z11dfCzhTxxH88F88NloBkfaivVqKa dw6iv2NYB+xgbQv1V+zhy+X0g+r3ii+kjrMk7oV6Stb0RKqpWMnU1o4GZfumGTtfxC FWtTXBlXMbrhEugq28Tq5RTEkKzjQlAO/gjJAAMGWkx8nS6/4YjdlOnSZV1OFT1D7t +lmd2y+/IDO/V+yJc2Wd/lWoMPSTufw48/kNbu6l6bCD0xQpt9z0Q/XSPtfkyXYZqw cpfOHCCgPz3p4zrzB7z1Dai/hmzLiFPLWW2dgtHkW3DdDPHDt6FjGKOYGEJOVjTJIa QvRzN5LyqhtEQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 1/6] phy: realtek: usb2: introduce vstatus/new_reg_req variables to driver data Reply-To: sashiko-reviews@lists.linux.dev To: "Rustam Adilov" Cc: neil.armstrong@linaro.org, robh@kernel.org, devicetree@vger.kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org, vkoul@kernel.org, conor+dt@kernel.org In-Reply-To: <20260520175728.720877-2-adilov@disroot.org> References: <20260520175728.720877-2-adilov@disroot.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 20 May 2026 18:23:10 +0000 Message-Id: <20260520182310.AF28C1F00894@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 4 potential issue(= s) to consider: Pre-existing issues: - [High] This problem wasn't introduced by this patch, but the driver fails= to check the return value of `of_iomap()`, which can lead to a NULL pointe= r dereference. - [High] This problem wasn't introduced by this patch, but incorrect pointe= r arithmetic on a `void __iomem *` pointer results in unaligned I/O memory = accesses for multi-port setups. - [High] This problem wasn't introduced by this patch, but I/O memory mappi= ngs created by `of_iomap()` are never unmapped, leading to resource leaks. - [High] This problem wasn't introduced by this patch, but multi-port PHY c= onfigurations concurrently modify shared hardware registers without synchro= nization or a read-modify-write cycle. -- commit 734507efb75a6be151dcde389bfc7f0e1df95132 Author: Rustam Adilov phy: realtek: usb2: introduce vstatus/new_reg_req variables to driver data This commit introduces vstatus_offset, vstatus_busy, and new_reg_req variab= les=20 to the driver data to handle different register offsets and busy bit=20 definitions in the RTL9607C SoC. These variables are added to the existing= =20 PHY configuration structures and assigned default values. > diff --git a/drivers/phy/realtek/phy-rtk-usb2.c b/drivers/phy/realtek/phy= -rtk-usb2.c > index 248550ef98cab..bd9ee895b9f90 100644 > --- a/drivers/phy/realtek/phy-rtk-usb2.c > +++ b/drivers/phy/realtek/phy-rtk-usb2.c [ ... ] > @@ -194,25 +200,26 @@ static int rtk_phy_write(struct phy_reg *phy_reg, c= har addr, char data) > int ret =3D 0; > =20 > /* write data to VStatusOut2 (data output to phy) */ > - writel((u32)data << shift_bits, reg_wrap_vstatus); > + writel((u32)data << shift_bits, > + reg_wrap_vstatus + phy_reg->vstatus_offset); [Severity: High] This is a pre-existing issue, but does writing directly to this register without a read-modify-write cycle overwrite the configuration for other ports? In multi-port setups, all PHY instances appear to share this same base address, and a direct writel() could clear the bits belonging to other PHYs. Is there also a need for synchronization to prevent concurrent writes across different ports? > =20 > - ret =3D utmi_wait_register(reg_gusb2phyacc0, PHY_VSTS_BUSY, 0); > + ret =3D utmi_wait_register(reg_gusb2phyacc0, phy_reg->vstatus_busy, 0); > if (ret) > return ret; [ ... ] > @@ -974,6 +982,9 @@ static int parse_phy_data(struct rtk_phy *rtk_phy) > phy_parameter->phy_reg.reg_wrap_vstatus =3D of_iomap(np, 0); > phy_parameter->phy_reg.reg_gusb2phyacc0 =3D of_iomap(np, 1) + index; [Severity: High] This isn't a bug introduced by this patch, but does the driver need to check the return value of of_iomap() here? If the mapping fails, this would leave the pointers as NULL and cause a dereference during I/O operations. [Severity: High] This is a pre-existing issue, but does adding index directly to the void __iomem * returned by of_iomap() result in exactly a 1-byte offset when index > 0? If so, this could cause an unaligned memory access fault on ARM architectures. Should the index be scaled appropriately? [Severity: High] This is also a pre-existing issue, but does the driver leak these I/O mappings? The driver maps the memory here using of_iomap(), but there does not appear to be a matching iounmap() in the driver cleanup paths. Would using devm_of_iomap() prevent this leak? > phy_parameter->phy_reg.vstatus_index =3D index; > + phy_parameter->phy_reg.vstatus_offset =3D phy_cfg->vstatus_offset; > + phy_parameter->phy_reg.vstatus_busy =3D phy_cfg->vstatus_busy; > + phy_parameter->phy_reg.new_reg_req =3D phy_cfg->new_reg_req; > =20 > if (of_property_read_bool(np, "realtek,inverse-hstx-sync-clock")) [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260520175728.7208= 77-1-adilov@disroot.org?part=3D1