From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65E0DCD5BA4 for ; Wed, 20 May 2026 18:38:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 12B2D41452; Wed, 20 May 2026 18:38:11 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id T653xgc5mdoV; Wed, 20 May 2026 18:38:09 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1AD154144F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1779302289; bh=Vli160Be25ufAg5UH9YxzHJ/rgEgzlQQ8hmf32U8RDI=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fm2PaSq7yZ2nZyHa5Ilq9Bw2EpEi1578zV/ymfnwcNvWEE9WNLM9kAU+BK+H9iGwB E3QIZYwFv9XUCKOjqXTOwef8NpjdSl1jnpcEFt0NL1XwC/VK4ec6ZXfvEPFc4KAjSb vjr6iYsKh49SJpAlOZQlq9aR+EWkJ0DeX1+zsgn/rmZTVnFfM4eF0NlimvlSX5Suop xl7p9PmTnMSydPBPsK6evFOzdfs3toKwCBOefo3OsW0gzUbJsAQmSzfFrlToFNqZjp ZQYcS9fM+3SCwUfEzjgkXvXOAeZmHSY7cvYRn4DeTlRNAPhMws8SmNP+6dnyGN3lhY 0vEjJ96p300cw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 1AD154144F; Wed, 20 May 2026 18:38:09 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id 40F46265 for ; Wed, 20 May 2026 18:38:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 3268240CA7 for ; Wed, 20 May 2026 18:38:07 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id fpseA7iGd-hu for ; Wed, 20 May 2026 18:38:06 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 7806540CA4 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 7806540CA4 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp2.osuosl.org (Postfix) with ESMTPS id 7806540CA4 for ; Wed, 20 May 2026 18:38:06 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id D815B4388F; Wed, 20 May 2026 18:38:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25D661F000E9; Wed, 20 May 2026 18:38:03 +0000 (UTC) Date: Wed, 20 May 2026 19:38:01 +0100 From: Simon Horman To: Przemyslaw Korba Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, aleksandr.loktionov@intel.com, arkadiusz.kubalewski@intel.com Message-ID: <20260520183801.GE988238@horms.kernel.org> References: <20260520115213.10864-2-przemyslaw.korba@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260520115213.10864-2-przemyslaw.korba@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779302285; bh=Vli160Be25ufAg5UH9YxzHJ/rgEgzlQQ8hmf32U8RDI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=oPy9Gp62SyYkWC9q0Pwf85qOMAwbN/7sf54xlrfeKS+OI32FRNd2lllcORwt35a1o qzdB3Le0JFXjqfMBrhuZ97JU5avCMKa+K287iMNzRZEzgFKvi1V8lkqC3BT+ODgqlF mDjzpe3Ts9qU7WtysPE8G/6dLi/DqV7OLXxYNz/VrbxHC+QItZUhC5neBwxswCAZcC 3dUbtQ4hhaivh7OwosRe/zoqxoeTgXf6KxwGiCYQhKzS0k0U/OB5hnUmGvIAD1446P Y3/M+UDIdYre6x1qW5nSDZHsrExexnJXP+BBnqHubQTVfJA/P2xC6jYchmveLSB7rB z6SKBWLsaoNEQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=oPy9Gp62 Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: suppress DPLL errors during reset recovery X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, May 20, 2026 at 01:50:06PM +0200, Przemyslaw Korba wrote: > During reset recovery, the admin queue returns EBUSY which is expected > behavior. However, the DPLL subsystem was logging these as errors and > incrementing the error counter, potentially leading to unnecessary > warnings and even disabling the DPLL periodic worker if the threshold > was reached. > > Suppress error logging and error counter increments when the admin > queue returns EBUSY, as this is expected during reset recovery and > not a real failure condition. > > test case: > - ethtool --reset eth3 irq-shared dma-shared filter-shared offload-shared > mac-shared phy-shared ram-shared > - observe if dmesg EBUSY errors are gone > > Fixes: d7999f5ea64b ("ice: implement dpll interface to control cgu") > Signed-off-by: Przemyslaw Korba > --- > v2: > add missing EBUSY check in ice_dpll_pps_update_phase_offsets() > v1: > https://lore.kernel.org/intel-wired-lan/20260520105311.5336-1-przemyslaw.korba@intel.com/T/#u Thanks for the update. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7E9C3F39EE for ; Wed, 20 May 2026 18:38:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779302287; cv=none; b=DwHe4ni2DDW09iyIrqx1Rq9cpVRXFieMeW7oJtKpoJUJ31eA0HCS/doJGr74HqzI38299ePfl/C4q+OB5ER8coXoSZ78nssF4AU8A3Km90kVkqadFfWfZKDVGWvu/4WCeJDxVDgsDY8PruFf7NvqqTv2ANDaHjsdBabNpkMbkA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779302287; c=relaxed/simple; bh=oiDmDzRlvpUWP3j3IZra960yjAD9qjRZTM8+sInDwl4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oqr+9JgPAwG41hudKoi3rShJfc9g0sedrsPufWOE0Ks960ByQsn+T/220/5OAxzRC7hhTYmH9cwHRmOhr/s/0/vZhKG8blNLYuWiSWbyufFi/D4WUiIG/4yrIkHSA6JM/ICXQkKOZCQNUY6NsbSCEhtf1nRheX38TEOQ007v3qU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oPy9Gp62; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oPy9Gp62" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25D661F000E9; Wed, 20 May 2026 18:38:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779302285; bh=Vli160Be25ufAg5UH9YxzHJ/rgEgzlQQ8hmf32U8RDI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=oPy9Gp62SyYkWC9q0Pwf85qOMAwbN/7sf54xlrfeKS+OI32FRNd2lllcORwt35a1o qzdB3Le0JFXjqfMBrhuZ97JU5avCMKa+K287iMNzRZEzgFKvi1V8lkqC3BT+ODgqlF mDjzpe3Ts9qU7WtysPE8G/6dLi/DqV7OLXxYNz/VrbxHC+QItZUhC5neBwxswCAZcC 3dUbtQ4hhaivh7OwosRe/zoqxoeTgXf6KxwGiCYQhKzS0k0U/OB5hnUmGvIAD1446P Y3/M+UDIdYre6x1qW5nSDZHsrExexnJXP+BBnqHubQTVfJA/P2xC6jYchmveLSB7rB z6SKBWLsaoNEQ== Date: Wed, 20 May 2026 19:38:01 +0100 From: Simon Horman To: Przemyslaw Korba Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, aleksandr.loktionov@intel.com, arkadiusz.kubalewski@intel.com Subject: Re: [PATCH iwl-net v2] ice: suppress DPLL errors during reset recovery Message-ID: <20260520183801.GE988238@horms.kernel.org> References: <20260520115213.10864-2-przemyslaw.korba@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260520115213.10864-2-przemyslaw.korba@intel.com> On Wed, May 20, 2026 at 01:50:06PM +0200, Przemyslaw Korba wrote: > During reset recovery, the admin queue returns EBUSY which is expected > behavior. However, the DPLL subsystem was logging these as errors and > incrementing the error counter, potentially leading to unnecessary > warnings and even disabling the DPLL periodic worker if the threshold > was reached. > > Suppress error logging and error counter increments when the admin > queue returns EBUSY, as this is expected during reset recovery and > not a real failure condition. > > test case: > - ethtool --reset eth3 irq-shared dma-shared filter-shared offload-shared > mac-shared phy-shared ram-shared > - observe if dmesg EBUSY errors are gone > > Fixes: d7999f5ea64b ("ice: implement dpll interface to control cgu") > Signed-off-by: Przemyslaw Korba > --- > v2: > add missing EBUSY check in ice_dpll_pps_update_phase_offsets() > v1: > https://lore.kernel.org/intel-wired-lan/20260520105311.5336-1-przemyslaw.korba@intel.com/T/#u Thanks for the update.