From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70AF881724; Wed, 20 May 2026 19:07:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779304042; cv=none; b=l3VFQGDqP8uwB4NDI/kQMd7SI7T30N+oN6QtfE+oAEhf2wQ6AMTz08natDH5A0tADddN3C+/Mb2Qd+B4/tkOcCrPtK2KPlLg8mslSZ8K8F8KetMbbV88kyEbfzRZ5OWhlx21nIdDlaMYs6dwIqL/jo1svBUaBm9j7hR06WvEmJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779304042; c=relaxed/simple; bh=w13NPPgdfG2sQ24gdIRbEaqnI4X0VH5g3sga/D7rTgk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k0EiI+Itd+EYzhFYPliXqZh2wtxEWLnyN0yiLB4Hbtohn1wTsenZp2V+qp0q/0cfV4xXuhXNYKNiw+3gllHHNX37kUzxdy9F6S32p6j36pUf+9GRKopT6/WeS+u8B5QM3ytW9pSRnjHowie8TmVs7nTAjbV0vu8AWtP+DTby38E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VNWkxPBa; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VNWkxPBa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B33DA1F000E9; Wed, 20 May 2026 19:07:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779304041; bh=TuPPbPM8zpAe4QryA/1tthxBDo9k7tG+N3NSiznpDNI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=VNWkxPBavgvYKU9722kNE74XIMhBMVW+G4jyKQJ0nm7VoG+oe3Wf7Bdz8zwHUOCsp BUUK0HGdj/G1ZfTfgY31uAmqaBCMaKDYXRUczZgX0F/7glO62VhDb+Pp0rRP8Ntxss tx7P4nXzdrCw1EIoPvQtbkvhOmZS3hCJ1flylpqcUBMtxxa7G0bs94xeTsu+FGT1j4 P+04tUdFUJMWGgONqolYkbzqUDNPi76D6j51YQ/9bOu97Hkmm6DDbHVhKX6aLnI0eH RY5naeBLVTgeqqoPZPRfvlV4WzL/6vOsZlInhn3QKirVl3Us58ghxELQEZKDlfHpj0 oQpMazXCUUQGQ== Date: Wed, 20 May 2026 19:07:19 +0000 From: Eric Biggers To: Andrey Albershteyn Cc: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev, linux-fsdevel@vger.kernel.org, hch@lst.de, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-btrfs@vger.kernel.org, linux-unionfs@vger.kernel.org, djwong@kernel.org, Amir Goldstein Subject: Re: [PATCH v10 03/22] ovl: use core fsverity ensure info interface Message-ID: <20260520190719.GB3424023@google.com> References: <20260520123722.405752-1-aalbersh@kernel.org> <20260520123722.405752-4-aalbersh@kernel.org> Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260520123722.405752-4-aalbersh@kernel.org> On Wed, May 20, 2026 at 02:37:01PM +0200, Andrey Albershteyn wrote: > fsverity now exposes fsverity_ensure_verity_info() which could be used > instead of opening file to ensure that fsverity info is loaded and > attached to inode. > > Signed-off-by: Andrey Albershteyn > Acked-by: Amir Goldstein > --- > fs/overlayfs/util.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) Reviewed-by: Eric Biggers I'm still confused by the new implementation of fsverity_active() that got introduced by "fsverity: use a hashtable to find the fsverity_info", though. I should have caught this during review of that commit. For one its comment is outdated, but also the memory barrier seems to be specific to the fsverity_get_info() caller and probably should be moved to there. Anyway, that's not directly related to this patch. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A31FCD4F3D for ; Wed, 20 May 2026 19:07:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4xQZsJAetMzDcwssqi+/eknwkar89WJoEkZ7nd0krcI=; b=D5DQf8RlUnxUGBFz1xcgjJ5GU+ 0h8ID2F0Uo1U0Cf3KWyJRdznHBU83TFV0MxHmfucyOJXEnLH6Lq8wTxUFzXibNTTgQbbfbC05lTRL zV8BRGxhgDEy1UEM7lgn/CGKwBtJiL6m/mTQGVnHEpLk9yjxH/y8/Wc0HAOapqafVis4=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wPmGU-0001lR-2W; Wed, 20 May 2026 19:07:34 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wPmGS-0001lC-KS for linux-f2fs-devel@lists.sourceforge.net; Wed, 20 May 2026 19:07:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TuPPbPM8zpAe4QryA/1tthxBDo9k7tG+N3NSiznpDNI=; b=YsdKnX6frQaTadKCWlAaDYxhox LgYzAzFtuXp4PCZl3IaYDdbRIeK3mHYvwJx+lSwtdQJITSFQWJAJALlDN+GN2wW2DHq32FZQJWCt7 N9aMiElWzFgtOkdt0w2qnSNYm9IJYyq0e+MsoZxjRWcoSHDuWb2mk+xe9TJjwhp4YzWQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TuPPbPM8zpAe4QryA/1tthxBDo9k7tG+N3NSiznpDNI=; b=eilJy/1vh6uKe0FwNSa7fEGYoj GJBYOuxCbmz8nzeFLNQGXD33fGYcz8pdpwjEGdzqX/B/AMQ6HSFPoOl+Jg/NdHPDrfwSHsWRzNk5/ IOhlF+XSYjl/ZYGxciLDyxnhDdumDPmqvkO20Z0MeqPyuXoMjFLUHO330UhnUTvevP5I=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wPmGR-0000s3-Ar for linux-f2fs-devel@lists.sourceforge.net; Wed, 20 May 2026 19:07:33 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 42417418C6; Wed, 20 May 2026 19:07:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B33DA1F000E9; Wed, 20 May 2026 19:07:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779304041; bh=TuPPbPM8zpAe4QryA/1tthxBDo9k7tG+N3NSiznpDNI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=VNWkxPBavgvYKU9722kNE74XIMhBMVW+G4jyKQJ0nm7VoG+oe3Wf7Bdz8zwHUOCsp BUUK0HGdj/G1ZfTfgY31uAmqaBCMaKDYXRUczZgX0F/7glO62VhDb+Pp0rRP8Ntxss tx7P4nXzdrCw1EIoPvQtbkvhOmZS3hCJ1flylpqcUBMtxxa7G0bs94xeTsu+FGT1j4 P+04tUdFUJMWGgONqolYkbzqUDNPi76D6j51YQ/9bOu97Hkmm6DDbHVhKX6aLnI0eH RY5naeBLVTgeqqoPZPRfvlV4WzL/6vOsZlInhn3QKirVl3Us58ghxELQEZKDlfHpj0 oQpMazXCUUQGQ== Date: Wed, 20 May 2026 19:07:19 +0000 To: Andrey Albershteyn Message-ID: <20260520190719.GB3424023@google.com> References: <20260520123722.405752-1-aalbersh@kernel.org> <20260520123722.405752-4-aalbersh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260520123722.405752-4-aalbersh@kernel.org> X-Headers-End: 1wPmGR-0000s3-Ar Subject: Re: [f2fs-dev] [PATCH v10 03/22] ovl: use core fsverity ensure info interface X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: fsverity@lists.linux.dev, djwong@kernel.org, Amir Goldstein , linux-unionfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, hch@lst.de, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, May 20, 2026 at 02:37:01PM +0200, Andrey Albershteyn wrote: > fsverity now exposes fsverity_ensure_verity_info() which could be used > instead of opening file to ensure that fsverity info is loaded and > attached to inode. > > Signed-off-by: Andrey Albershteyn > Acked-by: Amir Goldstein > --- > fs/overlayfs/util.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) Reviewed-by: Eric Biggers I'm still confused by the new implementation of fsverity_active() that got introduced by "fsverity: use a hashtable to find the fsverity_info", though. I should have caught this during review of that commit. For one its comment is outdated, but also the memory barrier seems to be specific to the fsverity_get_info() caller and probably should be moved to there. Anyway, that's not directly related to this patch. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel