All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Simon Glass <sjg@chromium.org>,
	Dwaipayan Ray <dwaipayanray1@gmail.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH v3 1/3] checkpatch: Add more user space directories to is_userspace()
Date: Wed, 20 May 2026 22:35:09 +0200	[thread overview]
Message-ID: <20260520203509.GA94543@pevik> (raw)
In-Reply-To: <825c889d29ad7332678d6bd0a467465252f4797b.camel@perches.com>

> On Wed, 2026-05-20 at 12:08 +0200, Petr Vorel wrote:
> > arch/*/tools/ and arch/*/boot/tools/ are directories containing user
> > space tools. This helps not only to strscpy checks but also to CamelCase
> > checks in the next commit to be more precise.
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -2669,7 +2669,10 @@ sub exclude_global_initialisers {

> >  sub is_userspace {
> >      my ($realfile) = @_;
> > -    return ($realfile =~ m@^tools/@ || $realfile =~ m@^scripts/@);
> > +    return ($realfile =~ m@^tools/@ ||
> > +		$realfile =~ m@^scripts/@ ||
> > +		$realfile =~ m@^arch/[^/]+/tools/@ ||
> > +		$realfile =~ m@^arch/[^/]+/boot/tools/@);

> Perhaps a more generic test like

> 	m@^arch/.*\btools\b@

Sure, I'll add it in the next version.

Kind regards,
Petr

  reply	other threads:[~2026-05-20 20:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 10:08 [PATCH v3 0/3] checkpatch: userspace improvements Petr Vorel
2026-05-20 10:08 ` [PATCH v3 1/3] checkpatch: Add more user space directories to is_userspace() Petr Vorel
2026-05-20 15:13   ` Joe Perches
2026-05-20 20:35     ` Petr Vorel [this message]
2026-05-20 10:08 ` [PATCH v3 2/3] checkpatch: Ignore <inttypes.h> format macros for userspace tools Petr Vorel
2026-05-20 10:08 ` [PATCH v3 3/3] checkpatch: Add new option to force userspace Petr Vorel
2026-05-20 20:37   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260520203509.GA94543@pevik \
    --to=pvorel@suse.cz \
    --cc=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=sjg@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.