From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Fabiano Rosas <farosas@suse.de>, Peter Xu <peterx@redhat.com>
Subject: [PULL 08/29] tests/qtest/migration: Make file-tests defer by default
Date: Wed, 20 May 2026 17:33:36 -0400 [thread overview]
Message-ID: <20260520213357.40646-9-peterx@redhat.com> (raw)
In-Reply-To: <20260520213357.40646-1-peterx@redhat.com>
From: Fabiano Rosas <farosas@suse.de>
All file: tests use listen_uri="defer". Make this the default in the
common function.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Link: https://lore.kernel.org/r/20260505160915.25558-3-farosas@suse.de
Signed-off-by: Peter Xu <peterx@redhat.com>
---
tests/qtest/migration/cpr-tests.c | 1 -
tests/qtest/migration/file-tests.c | 14 --------------
tests/qtest/migration/framework.c | 2 +-
3 files changed, 1 insertion(+), 16 deletions(-)
diff --git a/tests/qtest/migration/cpr-tests.c b/tests/qtest/migration/cpr-tests.c
index 48c98f0089..18217f0460 100644
--- a/tests/qtest/migration/cpr-tests.c
+++ b/tests/qtest/migration/cpr-tests.c
@@ -36,7 +36,6 @@ static void test_mode_reboot(char *name, MigrateCommon *args)
FILE_TEST_FILENAME);
args->connect_uri = uri;
- args->listen_uri = "defer";
args->start_hook = migrate_hook_start_mode_reboot;
args->start.mem_type = MEM_TYPE_SHMEM;
diff --git a/tests/qtest/migration/file-tests.c b/tests/qtest/migration/file-tests.c
index fef172068f..75135447f8 100644
--- a/tests/qtest/migration/file-tests.c
+++ b/tests/qtest/migration/file-tests.c
@@ -70,8 +70,6 @@ static void test_precopy_file(char *name, MigrateCommon *args)
g_autofree char *uri = g_strdup_printf("file:%s/%s", tmpfs,
FILE_TEST_FILENAME);
args->connect_uri = uri;
- args->listen_uri = "defer";
-
test_file_common(args, true);
}
@@ -114,7 +112,6 @@ static void test_precopy_file_offset_fdset(char *name, MigrateCommon *args)
g_autofree char *uri = g_strdup_printf("file:/dev/fdset/1,offset=%d",
FILE_TEST_OFFSET);
args->connect_uri = uri;
- args->listen_uri = "defer";
args->start_hook = migrate_hook_start_file_offset_fdset;
test_file_common(args, false);
@@ -128,8 +125,6 @@ static void test_precopy_file_offset(char *name, MigrateCommon *args)
FILE_TEST_OFFSET);
args->connect_uri = uri;
- args->listen_uri = "defer";
-
test_file_common(args, false);
}
@@ -140,7 +135,6 @@ static void test_precopy_file_offset_bad(char *name, MigrateCommon *args)
tmpfs, FILE_TEST_FILENAME);
args->connect_uri = uri;
- args->listen_uri = "defer";
args->result = MIG_TEST_QMP_ERROR;
test_file_common(args, false);
@@ -152,7 +146,6 @@ static void test_precopy_file_mapped_ram_live(char *name, MigrateCommon *args)
FILE_TEST_FILENAME);
args->connect_uri = uri;
- args->listen_uri = "defer";
args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;
@@ -165,7 +158,6 @@ static void test_precopy_file_mapped_ram(char *name, MigrateCommon *args)
FILE_TEST_FILENAME);
args->connect_uri = uri;
- args->listen_uri = "defer";
args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;
@@ -177,7 +169,6 @@ static void test_multifd_file_mapped_ram_live(char *name, MigrateCommon *args)
g_autofree char *uri = g_strdup_printf("file:%s/%s", tmpfs,
FILE_TEST_FILENAME);
args->connect_uri = uri;
- args->listen_uri = "defer";
args->start.caps[MIGRATION_CAPABILITY_MULTIFD] = true;
args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;
@@ -191,7 +182,6 @@ static void test_multifd_file_mapped_ram(char *name, MigrateCommon *args)
FILE_TEST_FILENAME);
args->connect_uri = uri;
- args->listen_uri = "defer";
args->start.caps[MIGRATION_CAPABILITY_MULTIFD] = true;
args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;
@@ -213,7 +203,6 @@ static void test_multifd_file_mapped_ram_dio(char *name, MigrateCommon *args)
g_autofree char *uri = g_strdup_printf("file:%s/%s", tmpfs,
FILE_TEST_FILENAME);
args->connect_uri = uri;
- args->listen_uri = "defer";
args->start_hook = migrate_hook_start_multifd_mapped_ram_dio;
args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;
@@ -285,7 +274,6 @@ static void test_multifd_file_mapped_ram_fdset(char *name, MigrateCommon *args)
FILE_TEST_OFFSET);
args->connect_uri = uri;
- args->listen_uri = "defer";
args->start_hook = migrate_hook_start_multifd_mapped_ram_fdset;
args->end_hook = migrate_hook_end_multifd_mapped_ram_fdset;
@@ -301,7 +289,6 @@ static void test_multifd_file_mapped_ram_fdset_dio(char *name,
g_autofree char *uri = g_strdup_printf("file:/dev/fdset/1,offset=%d",
FILE_TEST_OFFSET);
args->connect_uri = uri;
- args->listen_uri = "defer";
args->start_hook = migrate_hook_start_multifd_mapped_ram_fdset_dio;
args->end_hook = migrate_hook_end_multifd_mapped_ram_fdset;
@@ -332,7 +319,6 @@ test_precopy_file_mapped_ram_ignore_shared(char *name, MigrateCommon *args)
g_autofree char *uri = g_strdup_printf("file:%s/%s", tmpfs,
FILE_TEST_FILENAME);
args->connect_uri = uri;
- args->listen_uri = "defer";
args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;
args->start.caps[MIGRATION_CAPABILITY_X_IGNORE_SHARED] = true;
diff --git a/tests/qtest/migration/framework.c b/tests/qtest/migration/framework.c
index 4cd07be1d5..a0c80c0a61 100644
--- a/tests/qtest/migration/framework.c
+++ b/tests/qtest/migration/framework.c
@@ -972,7 +972,7 @@ void test_file_common(MigrateCommon *args, bool stop_src)
void *data_hook = NULL;
bool check_offset = false;
- if (migrate_start(&from, &to, args->listen_uri, &args->start)) {
+ if (migrate_start(&from, &to, "defer", &args->start)) {
return;
}
--
2.53.0
next prev parent reply other threads:[~2026-05-20 21:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 21:33 [PULL 00/29] Next patches Peter Xu
2026-05-20 21:33 ` [PULL 01/29] migration: Fix crash on second migration when cancel early Peter Xu
2026-05-20 21:33 ` [PULL 02/29] migration: Remove VMS_MULTIPLY_ELEMENTS and VMSTATE_VARRAY_MULTIPLY() Peter Xu
2026-05-20 21:33 ` [PULL 03/29] migration: Fix possible division by zero on calc expected downtime Peter Xu
2026-05-20 21:33 ` [PULL 04/29] tests/qtest/migration: Fix auto-converge test Peter Xu
2026-05-20 21:33 ` [PULL 05/29] migration: Replace current_migration with migrate_get_current() Peter Xu
2026-05-20 21:33 ` [PULL 06/29] MAINTAINERS: Make Maciej CPR maintainer Peter Xu
2026-05-20 21:33 ` [PULL 07/29] tests/qtest/migration: Move cpr transfer logic into cpr-tests.c Peter Xu
2026-05-20 21:33 ` Peter Xu [this message]
2026-05-20 21:33 ` [PULL 09/29] tests/qtest/migration: Set file URI by default Peter Xu
2026-05-20 21:33 ` [PULL 10/29] tests/qtest/migration: Group unix migration tests Peter Xu
2026-05-20 21:33 ` [PULL 11/29] tests/qtest/migration: Use precopy_unix_common for ignore-shared test Peter Xu
2026-05-20 21:33 ` [PULL 12/29] tests/qtest/migration: Use a default TCP URI for precopy Peter Xu
2026-05-20 21:33 ` [PULL 13/29] tests/qtest/migration: Defer by default in precopy_common Peter Xu
2026-05-20 21:33 ` [PULL 14/29] tests/qtest/migration: Set compression method in compression-tests Peter Xu
2026-05-20 21:33 ` [PULL 15/29] tests/qtest/migration: Remove multifd compression hook Peter Xu
2026-05-20 21:33 ` [PULL 16/29] tests/qtest/migration: Use defer for all tests Peter Xu
2026-05-20 21:33 ` [PULL 17/29] tests/qtest/migration: Use defer for cpr-tests Peter Xu
2026-05-20 21:33 ` [PULL 18/29] tests/qtest/migration: Use defer for auto-converge Peter Xu
2026-05-20 21:33 ` [PULL 19/29] tests/qtest/migration: Use defer in dirty_limit test Peter Xu
2026-05-20 21:33 ` [PULL 20/29] tests/qtest/migration: Stop passing URI into migrate_start Peter Xu
2026-05-20 21:33 ` [PULL 21/29] tests/qtest/migration: Unify URIs Peter Xu
2026-05-20 21:33 ` [PULL 22/29] migration/global_state: replace strcpy("") with explicit NUL termination Peter Xu
2026-05-20 21:33 ` [PULL 23/29] migration/vmstate: avoid per-element heap churn in vmsd ptr marker field Peter Xu
2026-05-20 21:33 ` [PULL 24/29] migration/savevm: use stack-allocated bitmap in configuration_validate_capabilities Peter Xu
2026-05-20 21:33 ` [PULL 25/29] migration/multifd: fix off-by-one in recv channel ID validation Peter Xu
2026-05-20 21:33 ` [PULL 26/29] migration/multifd: cache migrate_multifd_channels() in send/recv hot paths Peter Xu
2026-05-20 21:33 ` [PULL 27/29] migration/multifd: cache channel count in multifd_send_sync_main Peter Xu
2026-05-20 21:33 ` [PULL 28/29] migration/cpr: use hashtable for cpr fds Peter Xu
2026-05-20 21:33 ` [PULL 29/29] MAINTAINERS: Update email of Yong Huang Peter Xu
2026-05-21 19:20 ` [PULL 00/29] Next patches Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520213357.40646-9-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.