From: Nathan Chancellor <nathan@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Zhang Yi <zhangyi@everest-semi.com>,
tiwai@suse.com, linux-sound@vger.kernel.org,
peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com,
ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com,
ckeepax@opensource.cirrus.com, vkoul@kernel.org
Subject: Re: [PATCH v15 3/6] ASoC: es9356-sdca: Add ES9356 SDCA driver
Date: Wed, 20 May 2026 16:14:20 -0700 [thread overview]
Message-ID: <20260520231420.GE1607511@ax162> (raw)
In-Reply-To: <b17f8125-89bf-4032-a166-725be94466d2@sirena.org.uk>
On Tue, May 19, 2026 at 05:30:41PM +0100, Mark Brown wrote:
> On Tue, May 19, 2026 at 09:23:52AM -0700, Nathan Chancellor wrote:
>
> > Yeah, I realized shortly after sending that suggestion through testing
> > that it would error during the Kconfig stage due to a recursive
> > dependency issue. However, CONFIG_SND_SOC_SDCA is not a user selectable
> > symbol and I only see it selected through
>
> > CONFIG_SND_SOC_ACPI_INTEL_MATCH -> CONFIG_SND_SOC_ACPI_INTEL_SDCA_QUIRKS
>
> > so is it expected that users have to enable a driver that selects
> > CONFIG_SND_SOC_ACPI_INTEL_MATCH to get CONFIG_SND_SOC_SDCA?
>
> That seems off, it's not like SoundWire is Intel or even x86 specific.
> I would expect either it should be user selectable or the drivers using
> it should select it. Given that it's a class driver that probably means
> user selectable I think, some devices might need no extra support?
Yeah, just turning it into a user selectable symbol like
diff --git a/sound/soc/sdca/Kconfig b/sound/soc/sdca/Kconfig
index 87ab2895096c..4c0dcb9ff3b9 100644
--- a/sound/soc/sdca/Kconfig
+++ b/sound/soc/sdca/Kconfig
@@ -2,7 +2,7 @@
menu "SoundWire (SDCA)"
config SND_SOC_SDCA
- tristate
+ tristate "SDCA core support"
depends on ACPI
select AUXILIARY_BUS
help
--
appears to work for me, in combination with adding
depends on SND_SOC_SDCA
to the symbol for this driver.
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-05-20 23:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 7:52 [PATCH v15 0/6] Add es9356 focused SoundWire CODEC Zhang Yi
2026-05-14 7:52 ` [PATCH v15 1/6] ASoC: sdw_utils: add soc_sdw_es9356 Zhang Yi
2026-05-14 7:52 ` [PATCH v15 2/6] ASoC: sdw_utils: add ES9356 in codec_info_list Zhang Yi
2026-05-14 7:52 ` [PATCH v15 3/6] ASoC: es9356-sdca: Add ES9356 SDCA driver Zhang Yi
2026-05-14 8:36 ` Charles Keepax
2026-05-18 22:46 ` Nathan Chancellor
2026-05-19 12:42 ` Pierre-Louis Bossart
2026-05-19 16:23 ` Nathan Chancellor
2026-05-19 16:30 ` Mark Brown
2026-05-20 23:14 ` Nathan Chancellor [this message]
2026-05-29 13:30 ` Charles Keepax
2026-05-14 7:52 ` [PATCH v15 4/6] ASoC: Intel: soc-acpi: arl: Add es9356 support Zhang Yi
2026-05-14 7:52 ` [PATCH v15 5/6] ASoC: Intel: sof_sdw: add " Zhang Yi
2026-05-14 7:52 ` [PATCH v15 6/6] soundwire: intel_auxdevice: Add es9356 to wake_capable_list Zhang Yi
2026-05-14 15:11 ` (subset) [PATCH v15 0/6] Add es9356 focused SoundWire CODEC Vinod Koul
2026-05-15 2:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520231420.GE1607511@ax162 \
--to=nathan@kernel.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
--cc=zhangyi@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.