From: sashiko-bot@kernel.org
To: "Rosen Penev" <rosenp@gmail.com>
Cc: dmaengine@vger.kernel.org, Frank.Li@kernel.org,
dlemoal@kernel.org, vkoul@kernel.org, linux-ide@vger.kernel.org,
cassel@kernel.org
Subject: Re: [PATCH] dmaengine: bestcomm: Enable compile testing
Date: Wed, 20 May 2026 23:30:39 +0000 [thread overview]
Message-ID: <20260520233040.100A41F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260520223704.39320-1-rosenp@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Relaxing the dependency of PATA_MPC52xx causes a link failure on unsupported PowerPC platforms under COMPILE_TEST due to an undefined reference.
--
commit 950d74a4a60c655a1252de12aa32ba4329c5e07c
Author: Rosen Penev <rosenp@gmail.com>
dmaengine: bestcomm: Enable compile testing
Allow the BestComm DMA engine to be selected for PowerPC compile-test builds,
and update the PATA_MPC52xx dependency to rely directly on PPC_BESTCOMM.
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index fff305ec1e788..462cbb01567c3 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -823,7 +823,7 @@ config PATA_MARVELL
>
> config PATA_MPC52xx
> tristate "Freescale MPC52xx SoC internal IDE"
> - depends on PPC_MPC52xx && PPC_BESTCOMM
> + depends on PPC_BESTCOMM
[Severity: Low]
Will relaxing this dependency introduce a regression on unsupported PowerPC
platforms under COMPILE_TEST due to a link failure?
Because PPC_BESTCOMM now allows COMPILE_TEST on any PPC architecture,
PATA_MPC52xx can also be built on architectures other than MPC52xx or MPC512x.
However, drivers/ata/pata_mpc52xx.c unconditionally calls
mpc5xxx_get_bus_frequency(), which is implemented in
arch/powerpc/sysdev/mpc5xxx_clocks.c.
Since mpc5xxx_clocks.c is only compiled when CONFIG_PPC_MPC512x or
CONFIG_PPC_MPC52xx is enabled, building this driver on other PowerPC
architectures (like PPC64) might result in an undefined reference to
mpc5xxx_get_bus_frequency() at link time.
> select PPC_BESTCOMM_ATA
[ ... ]
> diff --git a/drivers/dma/bestcomm/Kconfig b/drivers/dma/bestcomm/Kconfig
> index 5dd437295964d..153b5492c93c7 100644
> --- a/drivers/dma/bestcomm/Kconfig
> +++ b/drivers/dma/bestcomm/Kconfig
> @@ -5,7 +5,7 @@
>
> config PPC_BESTCOMM
> tristate "Bestcomm DMA engine support"
> - depends on PPC_MPC52xx
> + depends on PPC_MPC52xx || (PPC && COMPILE_TEST)
> default n
> select PPC_LIB_RHEAP
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260520223704.39320-1-rosenp@gmail.com?part=1
next prev parent reply other threads:[~2026-05-20 23:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 22:37 [PATCH] dmaengine: bestcomm: Enable compile testing Rosen Penev
2026-05-20 23:30 ` sashiko-bot [this message]
2026-05-22 13:48 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2026-09-15 18:17 Rosen Penev
2026-09-16 19:42 ` Frank Li
2026-09-16 19:47 ` Rosen Penev
2026-09-16 20:25 ` Frank Li
2026-09-16 21:25 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520233040.100A41F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=rosenp@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.