From: linuxtestproject.agent@gmail.com
To: Li Wang <li.wang@linux.dev>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] lib: Introduce tst_path_defs.h to consolidate system paths
Date: Thu, 21 May 2026 03:46:49 +0000 [thread overview]
Message-ID: <20260521034649.4079-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260521032759.18727-1-li.wang@linux.dev>
Hi Li,
--- [PATCH 2/2] ---
On 2026-05-21, Li Wang wrote:
> metaparse: Explicitly parse essential headers for macros
> +static const char *must_includes[] = {
> + "tst_path_defs.h",
> + NULL
> +};
> +
> +static void parse_must_files(void)
> +{
> + unsigned int i, j;
The new code uses spaces for indentation. The rest of metaparse.c uses
tabs — please fix to match.
[...]
---
Note:
Our agent completed the review of the patch.
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-05-21 3:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 3:27 [LTP] [PATCH v4 1/2] lib: Introduce tst_path_defs.h to consolidate system paths Li Wang
2026-05-21 3:27 ` [LTP] [PATCH v4 2/2] metaparse: Explicitly parse essential headers for macros Li Wang
2026-06-03 9:18 ` Cyril Hrubis
2026-05-21 3:46 ` [LTP] [PATCH v4 1/2] lib: Introduce tst_path_defs.h to consolidate system paths Li Wang
2026-05-21 3:46 ` linuxtestproject.agent [this message]
2026-06-02 16:21 ` Andrea Cervesato via ltp
2026-06-03 9:19 ` Cyril Hrubis
-- strict thread matches above, loose matches on Subject: below --
2026-06-04 9:41 [LTP] [PATCH v5 " Li Wang
2026-06-04 11:37 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521034649.4079-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=li.wang@linux.dev \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.