From: Jiayuan Chen <jiayuan.chen@linux.dev>
To: damon@lists.linux.dev
Cc: Jiayuan Chen <jiayuan.chen@shopee.com>,
Jiayuan Chen <jiayuan.chen@linux.dev>,
SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Shu Anzai <shu17az@gmail.com>,
Quanmin Yan <yanquanmin1@huawei.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] mm/damon/tests/core-kunit: test split above max_nr_regions/2
Date: Thu, 21 May 2026 12:52:24 +0800 [thread overview]
Message-ID: <20260521045236.115749-3-jiayuan.chen@linux.dev> (raw)
In-Reply-To: <20260521045236.115749-1-jiayuan.chen@linux.dev>
From: Jiayuan Chen <jiayuan.chen@shopee.com>
Add a test that exercises kdamond_split_regions() when the total
region count is already above max_nr_regions / 2, asserting that the
function can still produce new regions and does not overshoot the
limit.
All tests pass:
damon: pass:29 fail:0 skip:0 total:29
Totals: pass:29 fail:0 skip:0 total:29
Cc: Jiayuan Chen <jiayuan.chen@linux.dev>
Signed-off-by: Jiayuan Chen <jiayuan.chen@shopee.com>
---
mm/damon/tests/core-kunit.h | 70 +++++++++++++++++++++++++++++++++++++
1 file changed, 70 insertions(+)
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index 1cfb8c176b87..6b2439670049 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -339,6 +339,75 @@ static void damon_test_split_regions_of(struct kunit *test)
damon_destroy_ctx(c);
}
+/*
+ * kdamond_split_regions() must still be able to make progress when the
+ * total region count is above max_nr_regions / 2, as long as there is
+ * unused budget and at least one region whose access pattern has just
+ * changed.
+ */
+static void damon_test_split_above_half_progresses(struct kunit *test)
+{
+ struct damon_ctx *c;
+ struct damon_target *t;
+ struct damon_region *r, *big;
+ unsigned long start;
+ unsigned int nr_before, nr_after, i;
+ const unsigned int nr_small = 799;
+ const unsigned long small_sz = 10;
+ const unsigned long big_sz = 1000000;
+
+ c = damon_new_ctx();
+ if (!c)
+ kunit_skip(test, "ctx alloc fail");
+
+ c->attrs.min_nr_regions = 10;
+ c->attrs.max_nr_regions = 1500;
+
+ t = damon_new_target();
+ if (!t) {
+ damon_destroy_ctx(c);
+ kunit_skip(test, "target alloc fail");
+ }
+
+ for (i = 0; i < nr_small; i++) {
+ start = i * small_sz;
+ r = damon_new_region(start, start + small_sz);
+ if (!r) {
+ damon_free_target(t);
+ damon_destroy_ctx(c);
+ kunit_skip(test, "region alloc fail");
+ }
+ r->nr_accesses = (i & 1) ? 0 : 100;
+ r->age = 5;
+ damon_add_region(r, t);
+ }
+
+ start = nr_small * small_sz;
+ big = damon_new_region(start, start + big_sz);
+ if (!big) {
+ damon_free_target(t);
+ damon_destroy_ctx(c);
+ kunit_skip(test, "big region alloc fail");
+ }
+ big->nr_accesses = 50;
+ damon_add_region(big, t);
+
+ damon_add_target(c, t);
+
+ nr_before = damon_nr_regions(t);
+ KUNIT_EXPECT_GT(test, (unsigned long)nr_before,
+ c->attrs.max_nr_regions / 2);
+
+ kdamond_split_regions(c);
+
+ nr_after = damon_nr_regions(t);
+ KUNIT_EXPECT_GT(test, nr_after, nr_before);
+ KUNIT_EXPECT_LE(test, (unsigned long)nr_after,
+ c->attrs.max_nr_regions);
+
+ damon_destroy_ctx(c);
+}
+
static void damon_test_ops_registration(struct kunit *test)
{
struct damon_ctx *c = damon_new_ctx();
@@ -1468,6 +1537,7 @@ static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damon_test_merge_two),
KUNIT_CASE(damon_test_merge_regions_of),
KUNIT_CASE(damon_test_split_regions_of),
+ KUNIT_CASE(damon_test_split_above_half_progresses),
KUNIT_CASE(damon_test_ops_registration),
KUNIT_CASE(damon_test_set_regions),
KUNIT_CASE(damon_test_nr_accesses_to_accesses_bp),
--
2.43.0
next prev parent reply other threads:[~2026-05-21 4:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 4:52 [PATCH 0/2] mm/damon/core: detect internal variation above max_nr_regions/2 Jiayuan Chen
2026-05-21 4:52 ` [PATCH 1/2] mm/damon/core: split age==0 regions when nr_regions exceeds max/2 Jiayuan Chen
2026-05-21 5:22 ` sashiko-bot
2026-05-21 6:34 ` Jiayuan Chen
2026-05-21 4:52 ` Jiayuan Chen [this message]
2026-05-21 5:41 ` [PATCH 2/2] mm/damon/tests/core-kunit: test split above max_nr_regions/2 sashiko-bot
2026-05-21 6:44 ` Jiayuan Chen
2026-05-21 14:30 ` [PATCH 0/2] mm/damon/core: detect internal variation " SeongJae Park
2026-05-21 15:07 ` Jiayuan Chen
2026-05-22 2:42 ` SeongJae Park
2026-05-22 15:11 ` Jiayuan Chen
2026-05-23 1:43 ` SeongJae Park
2026-05-25 8:09 ` Jiayuan Chen
2026-05-25 16:38 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521045236.115749-3-jiayuan.chen@linux.dev \
--to=jiayuan.chen@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=jiayuan.chen@shopee.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shu17az@gmail.com \
--cc=sj@kernel.org \
--cc=yanquanmin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.