Re: [PATCH 2/3] media: i2c: add imx576 image sensor driver

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Thu, May 21, 2026 at 05:44:09AM +0000, Himanshu Bhavani wrote:
> > On Wed, May 20, 2026 at 05:26:34PM +0530, Himanshu Bhavani wrote:
> >> Add a v4l2 subdevice driver for the Sony imx576 sensor.
> >>
> >> The Sony IMX576 image sensor with an active
> >> array size of 5760 x 4312
> >>
> >> The following features are supported:
> >> - Manual exposure an gain control support
> >> - vblank/hblank control support
> >> - Supported resolution: 2880 x 2156 30fps (SRGGB10)
> >>
> >> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
> >> ---
> >>  MAINTAINERS                |    1 +
> >>  drivers/media/i2c/Kconfig  |   10 +
> >>  drivers/media/i2c/Makefile |    1 +
> >>  drivers/media/i2c/imx576.c | 1029 ++++++++++++++++++++++++++++++++++++
> >>  4 files changed, 1041 insertions(+)
> >>  create mode 100644 drivers/media/i2c/imx576.c

[snip]

> >> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> >> index 90b276a7417a..e96c083e03d9 100644
> >> --- a/drivers/media/i2c/Makefile
> >> +++ b/drivers/media/i2c/Makefile
> >> @@ -61,6 +61,7 @@ obj-$(CONFIG_VIDEO_IMX335) += imx335.o
> >>  obj-$(CONFIG_VIDEO_IMX355) += imx355.o
> >>  obj-$(CONFIG_VIDEO_IMX412) += imx412.o
> >>  obj-$(CONFIG_VIDEO_IMX415) += imx415.o
> >> +obj-$(CONFIG_VIDEO_IMX576) += imx576.o
> >>  obj-$(CONFIG_VIDEO_IR_I2C) += ir-kbd-i2c.o
> >>  obj-$(CONFIG_VIDEO_ISL7998X) += isl7998x.o
> >>  obj-$(CONFIG_VIDEO_KS0127) += ks0127.o
> >> diff --git a/drivers/media/i2c/imx576.c b/drivers/media/i2c/imx576.c
> >> new file mode 100644
> >> index 000000000000..910cbcfb6031
> >> --- /dev/null
> >> +++ b/drivers/media/i2c/imx576.c

[snip]

> >> +static const struct imx576_mode supported_modes_10bit[] = {
> >> +	{
> >> +		.width = 2880,
> >> +		.height = 2156,
> >> +		.hts = 3165,
> >> +		.vts = 2172,
> >> +		.reg_list = {
> >> +			.num_of_regs = ARRAY_SIZE(mode_2880x2156_regs),
> >> +			.regs = mode_2880x2156_regs,
> >> +		},
> >> +	},
> >> +};
> >
> > No mode tables please. Control the analog crop and binning through the
> > selection and format APIs.
> >
> >> +
> >> +static const s64 link_freq[] = {
> >> +	IMX576_LINK_FREQ_600MHZ,
> >
> > The link frequency should be selectable from DT, with PLL parameters (if
> > any) computed by the driver.
> 
> I don't have the full datasheet, so this cannot be implemented properly.

Have you tried to work with your support channel to obtain the
documentation?

-- 
Regards,

Laurent Pinchart