All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Mauricio Faria de Oliveira <mfo@igalia.com>
Cc: Matthieu CASTET <castet.matthieu@free.fr>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	kernel-dev@igalia.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: atm: ueagle-atm: use dev_dbg() for 'device found' message
Date: Thu, 21 May 2026 12:08:23 +0200	[thread overview]
Message-ID: <20260521100823.GA38864@wp.pl> (raw)
In-Reply-To: <20260520-ueagle-atm-cleanup-v1-1-010c8bc7b214@igalia.com>

On Wed, May 20, 2026 at 07:32:50PM -0300, Mauricio Faria de Oliveira wrote:
> Convert dev_info() to dev_dbg().
> 
> Per 'Documentation/process/coding-style.rst':
> 
>   13) Printing kernel messages
> 
>   ...  When drivers are working properly they are quiet,
>   so prefer to use dev_dbg/pr_debug unless something is wrong.
> 
> While in there, correct the verb form and add 'with' for clarity.
> 
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Link: https://lore.kernel.org/all/2026051628-squatter-stature-c0e0@gregkh/
> Signed-off-by: Mauricio Faria de Oliveira <mfo@igalia.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>

> ---
>  drivers/usb/atm/ueagle-atm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c
> index f3ae72feb5bfc313ccfa1ab6a9bb40fcd8f5800a..71559a934133a82ddb23d255e0f04d018c13c583 100644
> --- a/drivers/usb/atm/ueagle-atm.c
> +++ b/drivers/usb/atm/ueagle-atm.c
> @@ -2590,7 +2590,7 @@ static int uea_probe(struct usb_interface *intf, const struct usb_device_id *id)
>  	int ret;
>  
>  	uea_enters(usb);
> -	uea_info(usb, "ADSL device founded vid (%#X) pid (%#X) Rev (%#X): %s\n",
> +	uea_dbg(usb, "ADSL device found with vid (%#X) pid (%#X) Rev (%#X): %s\n",
>  		le16_to_cpu(usb->descriptor.idVendor),
>  		le16_to_cpu(usb->descriptor.idProduct),
>  		le16_to_cpu(usb->descriptor.bcdDevice),
> 
> -- 
> 2.51.0
> 

  reply	other threads:[~2026-05-21 10:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 22:32 [PATCH 0/2] usb: atm: ueagle-atm: debug message changes Mauricio Faria de Oliveira
2026-05-20 22:32 ` [PATCH 1/2] usb: atm: ueagle-atm: use dev_dbg() for 'device found' message Mauricio Faria de Oliveira
2026-05-21 10:08   ` Stanislaw Gruszka [this message]
2026-05-20 22:32 ` [PATCH 2/2] usb: atm: ueagle-atm: remove function entry/exit debug messages Mauricio Faria de Oliveira
2026-05-21 10:08   ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260521100823.GA38864@wp.pl \
    --to=stf_xl@wp.pl \
    --cc=castet.matthieu@free.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-dev@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mfo@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.