From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A18B374E42 for ; Thu, 21 May 2026 10:08:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779358089; cv=none; b=DfgcrytdeQ1ZaB48+CkffxgzkmqHIvlqjl6p8rMb6VzKV8t3CteJoBL5WQKu2rJV2UrRVILNMOVhZ/bZb7iGmxm+K7Lcku3ieMZkMokmw3Eicxr99bCxryEYOnTCsYI5Mbm/B79NyUTCsMFNg/ffzZko9zK4efJ44I90+h4DaRM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779358089; c=relaxed/simple; bh=8HPlUTLUEPHCnotL/RMKxMT3Q3j9pXUESqrm0jMSJSg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iIvpQkIH3WAOZi7H+Y4dAVCHxrKpirFPDyh1mLq+jxNvB3D1xZiZsb5lk7D3m0Ye/o04ZrYPUy7gQyhfXtTmHdAuufm7SEOhemVa/52vpAgyxzOLKs+39weQ5J1G8NIyCfEjwDOjrUwkjn8Xm8+L3PI2fm5FQf4TEcEo2JCkho4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EWP+s1fD; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EWP+s1fD" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-490229aa522so25184725e9.3 for ; Thu, 21 May 2026 03:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779358086; x=1779962886; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ufW7se9r2tjAwotKHVJInXowGJYWE+4jYJ0vi/0uHaE=; b=EWP+s1fDkVzgwGm93jsPtNiFvLdhOlQd5IAr+lxbxO1i8tFiCdZRXzzomUpliBSlZ5 8J7ncoQ+CIPj6ixz+HNYKwWWMVtulxS2RSaNIA3oOiwvb5JJRKKrfZKl2ZlIoZ6zKli5 SHyx0eYwktNVbgcvqiHhTJTdJw21RFn4+OCzFbyOhChq9gNN3pPygdP+HUTbpcM+HGH5 z5GfQd5ZhrUi6cDrwa/YTDOl9ouJqZ7W1NWnhkxTmk0Cma35A8pnjP34FO+172yNm6zy CZH1HexWh9dhW6z8VOxqc/XGxi5VxKKRBFEa0tXZ/mbTBjihSj4pi8icCvhsRvkQrl7i f9AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779358086; x=1779962886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ufW7se9r2tjAwotKHVJInXowGJYWE+4jYJ0vi/0uHaE=; b=k7iSCueLhEN8BNTYbV8xDZcVQo5lIbmVNwJAcz4Bh1L6YyDhl199gImAJXozpcZ17v 0Lkm5u1g2R0gOno2XMzw/kicuGZUvoVFrUtp06xjjB8ENWP5TzvnT/VQOn9UesQ9MESZ KHrIGFsc9ZHAzt3XbgT2xReCrc4AiXyT+P/4gKQQocMGscqrj1qmymGJnxWQVC/8MoM+ VGwGZ5E+1QqiFBl/ygwrJZ2TOoyZ/JaKzwzhbntD54pG3X5XhlWL+afzjEEGVzuPYPtd ft/nvWhAv2Z1QeMKIcWz/MTNWZJfCYE7FgRZqvqLk92pe9Hkxwb9HWUhXeMmgTPQ881D QN2g== X-Forwarded-Encrypted: i=1; AFNElJ/YxvcCQ/6hEgS1mMXnL6xbSiMPpoDZfecR8zZRxroHxCTKw4FbU8m4esFI+1wCOaJpHzWlBDpEoBOj5G8=@vger.kernel.org X-Gm-Message-State: AOJu0YzXLSE/2UiroH+6b+MLzabL66rwn1+S2S+BjrG06w+0SYEuuVlm 8bySUMfjhmL+xdNu+ivmnx/Lan4ylYgmh1q8A2CFTcMI79PwU9i+0lHL X-Gm-Gg: Acq92OH4o3YCosYitQ8unbara7cupe/Bea/BMCeNLk3ZBA1BTDtaol8fA0eQfhm1BWH AKbpWDFKNoTpE5+w5yDdXdLbsztuaEPs/Zq66e3zJ0UxplFasjcmNhEv2AEdYvz0opf4FyJyCHT 98PXBKdEnxFgVgrIE2snLDwiznYvCDPU/x0Ub6M5Giw/JiFPRBNAcXTlpfyEzRVjNuB1QSjhhl0 F+0ADFpGo/FOeFUc5nCuMTDNXrEnlneinufOdtDinH+xL99pUmiTAYDAddpyOZLs+Vc+Ayr9lK1 XfGtNLGZC8ELDMxQjCUiTRLGPA7oycb8KTE9bkKBLpcnzqi4PO19yLGEG/8QvJYZkS1VB8l7VS6 o92ePAPeW1K96ninuFvaBZr27rCIXrjke5TY8Gj0kh/Ta3ngGAfZgy+Z/lMaCpQHRPPShQsRbJX 2lU7uP/dUiS6WGVSYzW9Y5JjxOyNN5iz45ij9hquIvLBaG3dBJHNPYjJJ1MhPMvASgTfRffD1n+ /A= X-Received: by 2002:a05:600c:a296:b0:489:1f04:96c3 with SMTP id 5b1f17b1804b1-4903604ce69mr20506365e9.2.1779358086435; Thu, 21 May 2026 03:08:06 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49035c29fe8sm17678515e9.2.2026.05.21.03.08.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 03:08:06 -0700 (PDT) Date: Thu, 21 May 2026 11:08:04 +0100 From: David Laight To: Thomas Gleixner Cc: Harshitha Ramamurthy , netdev@vger.kernel.org, joshwash@google.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, jstultz@google.com, sboyd@kernel.org, willemb@google.com, nktgrg@google.com, jfraker@google.com, ziweixiao@google.com, maolson@google.com, jordanrhee@google.com, thostet@google.com, alok.a.tiwari@oracle.com, pkaligineedi@google.com, horms@kernel.org, dwmw2@infradead.org, jacob.e.keller@intel.com, yyd@google.com, jefrogers@google.com, linux-kernel@vger.kernel.org, Naman Gulati Subject: Re: [PATCH net-next v8 3/3] gve: implement PTP gettimex64 Message-ID: <20260521110804.654cf4b8@pumpkin> In-Reply-To: <87mrxtwzz9.ffs@tglx> References: <20260514225842.110706-1-hramamurthy@google.com> <20260514225842.110706-4-hramamurthy@google.com> <87mrxtwzz9.ffs@tglx> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 20 May 2026 23:08:42 +0200 Thomas Gleixner wrote: > On Thu, May 14 2026 at 22:58, Harshitha Ramamurthy wrote: ... > > + do { > > + *pre_cycles = get_cycles(); > > This is a completely non-sensical hack. Why do you need get_cycles() > here, which is a horrible and ill-defined interface that others are > trying to get rid of? ISTR that it has always returned 0 on some architectures. -- David