Re: [PATCH bpf-next v11 7/8] bpf: add bpf_list_is_first/last/empty kfuncs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Multi-line comment uses deprecated style in `bpf_list_empty`.
--

commit 22a1ce2a5267998c134b07d40be7e92224236cc6
Author: Kaitao Cheng <chengkaitao@kylinos.cn>

bpf: add bpf_list_is_first/last/empty kfuncs

This commit adds three new kfuncs to allow BPF programs to directly query
whether a node is the first or last in a linked list, or if the list is
empty. This avoids the inefficiency of having to pop and push nodes just
to check these properties.

> diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c
> index 89579165ef4dc..b6c3d02d5593c 100644
> --- a/kernel/bpf/helpers.c
> +++ b/kernel/bpf/helpers.c
[ ... ]
> @@ -2656,6 +2656,43 @@ __bpf_kfunc struct bpf_list_node *bpf_list_back(struct bpf_list_head *head)
[ ... ]
> +__bpf_kfunc bool bpf_list_empty(struct bpf_list_head *head)
> +{
> +	struct list_head *h = (struct list_head *)head;
> +
> +	/* If list_head was 0-initialized by map, bpf_obj_init_field wasn't
> +	 * called on its fields, so init here
> +	 */

[Severity: Low]
This isn't a bug, but the multi-line comment uses a deprecated style.
According to BPF subsystem guidelines, multi-line comments should have the
opening /* on its own line.

> +	if (unlikely(!h->next))
> +		INIT_LIST_HEAD(h);
> +
> +	return list_empty(h);
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521032306.97118-1-kaitao.cheng@linux.dev?part=7