From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADB54CD5BB4 for ; Thu, 21 May 2026 13:54:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wQ3oJ-0001PK-0h; Thu, 21 May 2026 09:51:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wQ3nw-00016i-67 for qemu-devel@nongnu.org; Thu, 21 May 2026 09:51:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wQ3nt-0005Hf-Su for qemu-devel@nongnu.org; Thu, 21 May 2026 09:51:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779371473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6hh6vNFU4mb69vK9rw83JMfqECqtzobaB1xx4DG/LzU=; b=D2bAxXIq+yAA936LLWJpIFoWu9w1bBCQwfrXtGB4amMzugDwMljGPJFwaxfMdxmxMq3X8g GimGczfgWiRLfycg79wkzk63i4fVbZDpsGMzsf37zwTJa8MDB4LFjd8thHlU7JucElskrG f2z4B9krshp8vbxrsCKEwCu+cyodkSo= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-MPSuKJr1PeKNSns1M7gpFQ-1; Thu, 21 May 2026 09:51:09 -0400 X-MC-Unique: MPSuKJr1PeKNSns1M7gpFQ-1 X-Mimecast-MFC-AGG-ID: MPSuKJr1PeKNSns1M7gpFQ_1779371468 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 82D9518005B2; Thu, 21 May 2026 13:51:08 +0000 (UTC) Received: from berrange.com (unknown [10.44.33.98]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 47FD61956053; Thu, 21 May 2026 13:51:03 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Hanna Reitz , Pierrick Bouvier , Paolo Bonzini , Kevin Wolf , qemu-block@nongnu.org, John Snow , Thanos Makatos , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , John Levon , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Cleber Rosa , Thomas Huth Subject: [PULL 16/29] iotests: mark 151, 181, 185 & 308 as flaky tests Date: Thu, 21 May 2026 14:49:30 +0100 Message-ID: <20260521134943.1714527-17-berrange@redhat.com> In-Reply-To: <20260521134943.1714527-1-berrange@redhat.com> References: <20260521134943.1714527-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Introduce a "_flaky_test" function for shell based I/O tests which accepts a GitLab issue URL, and causes the I/O test to be skipped unless the $QEMU_TEST_FLAKY_TESTS environment variable is set. The equivalent "skip_flaky" test decorator is added for python based I/O tests with the same behaviour. This is used by: * Test 151 which fails in QEMU private AWS runners due to failure to make progress in time * Test 181 which fails with a non-responsive QEMU on AWS runners with the QED format * Test 185 which fails in GitLab shared runners * Test 308 which fails to see disk usage increase after fallocate Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/qemu-iotests/151 | 1 + tests/qemu-iotests/181 | 2 ++ tests/qemu-iotests/185 | 1 + tests/qemu-iotests/308 | 2 ++ tests/qemu-iotests/common.rc | 16 ++++++++++++++++ tests/qemu-iotests/iotests.py | 16 ++++++++++++++++ 6 files changed, 38 insertions(+) diff --git a/tests/qemu-iotests/151 b/tests/qemu-iotests/151 index 9b9c815db5..647194094a 100755 --- a/tests/qemu-iotests/151 +++ b/tests/qemu-iotests/151 @@ -308,6 +308,7 @@ class TestThrottledWithNbdExportBase(iotests.QMPTestCase): class TestLowThrottledWithNbdExport(TestThrottledWithNbdExportBase): iops = 16 + @iotests.skip_flaky("https://gitlab.com/qemu-project/qemu/-/work_items/3513") def testUnderLoad(self): ''' Throttle the source node, then issue a whole bunch of external requests diff --git a/tests/qemu-iotests/181 b/tests/qemu-iotests/181 index dc90a10757..b904e8ce01 100755 --- a/tests/qemu-iotests/181 +++ b/tests/qemu-iotests/181 @@ -48,6 +48,8 @@ _unsupported_fmt qcow vdi vhdx vmdk vpc vvfat parallels _supported_proto generic _supported_os Linux +_flaky_test https://gitlab.com/qemu-project/qemu/-/work_items/3515 + size=64M _make_test_img $size diff --git a/tests/qemu-iotests/185 b/tests/qemu-iotests/185 index 17489fb91c..a62ae8d329 100755 --- a/tests/qemu-iotests/185 +++ b/tests/qemu-iotests/185 @@ -50,6 +50,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 _supported_fmt qcow2 _supported_proto file _supported_os Linux +_flaky_test https://gitlab.com/qemu-project/qemu/-/issues/3270 size=$((64 * 1048576)) TEST_IMG="${TEST_IMG}.base" _make_test_img $size diff --git a/tests/qemu-iotests/308 b/tests/qemu-iotests/308 index f4a06a522e..a2290825f4 100755 --- a/tests/qemu-iotests/308 +++ b/tests/qemu-iotests/308 @@ -53,6 +53,8 @@ _supported_proto file # We create the FUSE export manually _supported_os Linux # We need /dev/urandom _require_disk_usage +_flaky_test https://gitlab.com/qemu-project/qemu/-/work_items/3514 + # $1: Export ID # $2: Options (beyond the node-name and ID) # $3: Expected return value (defaults to 'return') diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index 731e4b2b99..298bc483e0 100644 --- a/tests/qemu-iotests/common.rc +++ b/tests/qemu-iotests/common.rc @@ -1088,5 +1088,21 @@ _qcow2_dump_header() fi } +# This must be referenced after any _require_ lines, so that +# test filtering happens first +_flaky_test() +{ + if test -z "$1" + then + echo "A GitLab issue URL must be provided for a flaky test" + exit 1 + fi + + if test -z "$QEMU_TEST_FLAKY_TESTS" + then + _notrun "Test is flaky (see $1) and \$QEMU_TEST_FLAKY_TESTS is not set" + fi +} + # make sure this script returns success true diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 05274772ce..072be80e07 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -1603,6 +1603,22 @@ def func_wrapper(*args, **kwargs): return func(*args, **kwargs) return func_wrapper +def skip_flaky(bugurl): + '''Skip Test Decorator + Always skips test due to unreliable design. + Requires a bug report URL for historical record.''' + def skip_test_decorator(func): + def func_wrapper(*args, **kwargs): + if os.environ.get("QEMU_TEST_FLAKY_TESTS", None) is None: + case_notrun( + ('{}: test is flaky (see {}) and $QEMU_TEST_FLAKY_TESTS ' + + 'is not set').format(args[0], bugurl)) + return None + else: + return func(*args, **kwargs) + return func_wrapper + return skip_test_decorator + # We need to filter out the time taken from the output so that # qemu-iotest can reliably diff the results against master output, # and hide skipped tests from the reference output. -- 2.54.0