Re: [PATCH v4 03/27] rust: driver: decouple driver private data from driver type

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message explicitly states that the patch adds a `Data<'bound>` associated type, but the implementation only adds a standard associated type `type Data: Send;`.
--

commit 36c9216be2c21a3bf349085eb24629f94228e6bd
Author: Danilo Krummrich <dakr@kernel.org>

rust: driver: decouple driver private data from driver type

This commit adds a Data associated type to bus driver traits, decoupling
the driver's device private data type from the driver struct itself. It
updates existing drivers to use type Data = Self to preserve current behavior.

> rust: driver: decouple driver private data from driver type
>
> Add a type Data<'bound> associated type to all bus driver traits,
> decoupling the driver's bus device private data type from the driver
> struct itself.
>
> In the context of adding a 'bound lifetime, making this an associated
> type has the advantage that it allows us to avoid a driver trait global
> lifetime and it avoids the need for ForLt for bus device private data;
> both of which make the subsequent implementation by buses much simpler.

[Severity: Medium]
Is the commit message accurate for this patch?

The commit message explicitly states that the patch adds a Data<'bound>
associated type and details the advantages of the 'bound lifetime parameter.
However, the implementation in this patch only adds a standard associated
type (type Data: Send;) without the 'bound lifetime parameter.

Could this part of the commit message have been intended for a later patch
in the series where the lifetime parameter is actually introduced?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521233501.1191842-1-dakr@kernel.org?part=3