From: Graham O'Connor <graham.oconnor@gmail.com>
To: linux-arm-msm@vger.kernel.org
Cc: andersson@kernel.org, konradybcio@kernel.org,
robin.clark@oss.qualcomm.com, lumag@kernel.org,
abhinav.kumar@linux.dev, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Graham O'Connor <graham.oconnor@gmail.com>
Subject: [PATCH 1/6] soc: qcom: rpmh-rsc: Skip TCS init when RSC is managed by firmware
Date: Fri, 22 May 2026 18:06:40 +1200 [thread overview]
Message-ID: <20260522060645.4399-2-graham.oconnor@gmail.com> (raw)
In-Reply-To: <20260522060645.4399-1-graham.oconnor@gmail.com>
On QCS6490-based platforms booting via UEFI, the RSC hardware solver
is already active when the kernel takes over from the firmware. Calling
rpmh_probe_tcs_config() in this state reinitializes the controller
while the firmware is actively managing it, causing a security
violation and system reset.
Check whether the hardware solver is already enabled via the
DRV_SOLVER_CONFIG register before calling rpmh_probe_tcs_config().
If the solver is active, skip TCS initialization and return early
after setting the driver data, allowing other drivers to find the
controller without disrupting the firmware-managed state.
Tested on Radxa Dragon Q6A (QCS6490)
Signed-off-by: Graham O'Connor <graham.oconnor@gmail.com>
---
drivers/soc/qcom/rpmh-rsc.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
index c6f7d5c9c..7915f12de 100644
--- a/drivers/soc/qcom/rpmh-rsc.c
+++ b/drivers/soc/qcom/rpmh-rsc.c
@@ -1074,6 +1074,20 @@ static int rpmh_rsc_probe(struct platform_device *pdev)
else
drv->regs = rpmh_rsc_reg_offset_ver_2_7;
+ /*
+ * On some platforms the RSC is already managed by the firmware
+ * when the kernel boots. Calling rpmh_probe_tcs_config() in this
+ * state would reinitialize the controller and cause a security
+ * violation. Skip TCS initialization if the hardware solver is
+ * already active.
+ */
+ if (readl_relaxed(drv->base + drv->regs[DRV_SOLVER_CONFIG]) &
+ (DRV_HW_SOLVER_MASK << DRV_HW_SOLVER_SHIFT)) {
+ dev_dbg(&pdev->dev, "RSC already managed by firmware, skipping TCS init\n");
+ platform_set_drvdata(pdev, drv);
+ return 0;
+ }
+
ret = rpmh_probe_tcs_config(pdev, drv);
if (ret)
return ret;
--
2.53.0
next prev parent reply other threads:[~2026-05-22 6:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 6:06 [PATCH 0/6] arm64: qcom: Enable additional hardware on Radxa Dragon Q6A Graham O'Connor
2026-05-22 6:06 ` Graham O'Connor [this message]
2026-05-22 6:48 ` [PATCH 1/6] soc: qcom: rpmh-rsc: Skip TCS init when RSC is managed by firmware sashiko-bot
2026-05-25 12:40 ` Konrad Dybcio
2026-05-27 20:30 ` Gekko
2026-06-08 10:40 ` Konrad Dybcio
2026-05-22 6:06 ` [PATCH 2/6] firmware: qcom: scm: Allow EFI variable access on Radxa Dragon Q6A Graham O'Connor
2026-05-24 16:33 ` Dmitry Baryshkov
2026-05-22 6:06 ` [PATCH 3/6] drm/msm/dp: Limit voltage swing level to 2 for RA620 bridge Graham O'Connor
2026-05-22 6:55 ` sashiko-bot
2026-05-22 9:28 ` Konrad Dybcio
2026-05-27 20:50 ` Gekko
2026-05-22 6:06 ` [PATCH 4/6] arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Add regulator supplies and disable EUD Graham O'Connor
2026-05-22 7:27 ` sashiko-bot
2026-05-24 16:38 ` Dmitry Baryshkov
2026-05-22 6:06 ` [PATCH 5/6] arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Enable GPU and display pipeline Graham O'Connor
2026-05-22 6:44 ` Neil Armstrong
2026-05-22 7:52 ` sashiko-bot
2026-05-22 6:06 ` [PATCH 6/6] arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Enable USB3 SuperSpeed Graham O'Connor
2026-05-22 6:44 ` Neil Armstrong
2026-05-22 10:13 ` [PATCH 0/6] arm64: qcom: Enable additional hardware on Radxa Dragon Q6A Graham O'Connor
2026-05-24 1:58 ` Xilin Wu
2026-05-27 20:43 ` Gekko
2026-05-28 1:56 ` Xilin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260522060645.4399-2-graham.oconnor@gmail.com \
--to=graham.oconnor@gmail.com \
--cc=abhinav.kumar@linux.dev \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.