All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Oleksij Rempel" <o.rempel@pengutronix.de>
Cc: linux-hwmon@vger.kernel.org, robh@kernel.org,
	devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v14 4/6] pinctrl: add NXP MC33978/MC34978 pinctrl driver
Date: Fri, 22 May 2026 06:22:24 +0000	[thread overview]
Message-ID: <20260522062224.D2F001F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260522044855.1772639-5-o.rempel@pengutronix.de>

> From: David Jander <david@protonic.nl>
> 
> Add pin control and GPIO driver for the NXP MC33978/MC34978 Multiple
> Switch Detection Interface (MSDI) devices.
> 
> This driver exposes the 22 mechanical switch detection inputs (14
> Switch-to-Ground, 8 Programmable) as standard GPIOs.
> 
> Key features implemented:
> - GPIO read/write: Translates physical switch states (open/closed)
>   to logical GPIO levels based on the configured switch topology
>   (Switch-to-Ground vs. Switch-to-Battery).
> - Emulated Output: Allows setting pins "high" or "low" by manipulating
>   the tri-state registers and hardware pull topologies.
> - Interrupt routing: Proxies GPIO interrupt requests to the irq_domain
>   managed by the parent MFD core driver via a hierarchical irq_chip.
> 
> Signed-off-by: David Jander <david@protonic.nl>
> Co-developed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522044855.1772639-1-o.rempel@pengutronix.de?part=4


  reply	other threads:[~2026-05-22  6:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22  4:48 [PATCH v14 0/6] mfd: Add support for NXP MC33978/MC34978 MSDI Oleksij Rempel
2026-05-22  4:48 ` [PATCH v14 1/6] dt-bindings: pinctrl: add " Oleksij Rempel
2026-05-22  4:58   ` sashiko-bot
2026-05-22  4:48 ` [PATCH v14 2/6] mfd: add NXP MC33978/MC34978 core driver Oleksij Rempel
2026-05-22  5:24   ` sashiko-bot
2026-05-22  4:48 ` [PATCH v14 3/6] pinctrl: core: Make pin group callbacks optional for pin-only drivers Oleksij Rempel
2026-05-22  5:55   ` sashiko-bot
2026-05-25 13:18     ` Linus Walleij
2026-05-22  4:48 ` [PATCH v14 4/6] pinctrl: add NXP MC33978/MC34978 pinctrl driver Oleksij Rempel
2026-05-22  6:22   ` sashiko-bot [this message]
2026-05-22  4:48 ` [PATCH v14 5/6] hwmon: add NXP MC33978/MC34978 driver Oleksij Rempel
2026-05-22  6:47   ` sashiko-bot
2026-05-22  4:48 ` [PATCH v14 6/6] mux: add NXP MC33978/MC34978 AMUX driver Oleksij Rempel
2026-05-22  7:09   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260522062224.D2F001F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.