From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C394A3C98B5 for ; Fri, 22 May 2026 10:03:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779444234; cv=none; b=ScrP+wxgZPiDHAS6TC/RzfP9cl3tAxTmdp8508yclwB4oIVBmHFPg6ApHpdw8P5wYHY334Z7YVH4k3/pVLC/WU+yAfD1AKS2DPIMdw/nlpGJknvnP2DOcQgvEFZ5skiB/Ozp5ERkdPgpFD4mK7bRj15A+NLN1bkuFHHkTD+gX5E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779444234; c=relaxed/simple; bh=wlWvomiauZ7B2iJ3h1A1PnZrGVNV+2V7Wo95ZMBDObc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q+uu5qASQc+oM6P3OrDV7vya4to3f/9ww245R9UYN8ykrttyZzMga1bBA9wERFKxe8Mt0RbfekpABPuBYci8OxOL1Oo9ye1lR+Ua6r9XCegZsUcqnkglQngwSj/X0UZ0cE2dK30U51+X8lQ2id33JDtUcZWq6jGhmaQdqFN+r04= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YjDYoiKO; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YjDYoiKO" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2ba6485d219so53878925ad.3 for ; Fri, 22 May 2026 03:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779444232; x=1780049032; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ieAL7FXG9N2pPYlycZklbhAMC0pexNuJqkqoSDsbdHQ=; b=YjDYoiKOLoDN6c6IpccmhF87lmEMiUMfSu5lMtQIPgmCbTbq5mWubHB+7/ZoadiRE1 V+QkVjP+GnRSd4itNYGgAA8KMLDKCum64BrOGW3Un4nNz+jw4HWuNbfDRHFJwLYd8KVP wKrz8LJpkahpvcY48V/vF+66dgc/iPB1s7+Ck1H9RpG5Mi1taZflg4riBujSOYdpewnR l42SPU1riW11RJfByzxH3W9MYc7JYyukZvIyVaNGc4F5LKM00DgIHxB+9n9UBhm6leKD qbHotJ3kCy65F3GTnHyk8oOndLtVw8RxqPXCZ6NdbPDHFSJDnlwcu90MkEujggczRC+F A1pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779444232; x=1780049032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ieAL7FXG9N2pPYlycZklbhAMC0pexNuJqkqoSDsbdHQ=; b=AqDCXAv4SbG5P3NT7eDUqrp30aLDDdrVdFfYF2Wt4dup8JEBLoq1xtZbl9psU3ougq wmQDPioA4zDX0XJqNR7tacGeCics7j0FHyuuH3cISZ7iaXCOYmRK2F8MFKY+C2IROAv0 7zd72ws0juZ7UNUFvFLY+DtDFk4F50r3Hh7dQM5hVchSfaqz2wQo73jN+SzK+TkbpvFJ egB8ONwD07va5yV7J395n2MMFp62tlGrBErIy1Ffz3zkN9H7FTwjSCxnY5zYQHezWLUY umtRG1e6Thq3gadp//yG/g8bncqQLkHCxW0/esTA8/XZmoxwHZonbIsUOOhs4viMGAlR VRNA== X-Forwarded-Encrypted: i=1; AFNElJ8pzxTm4ZXZwBlHaECR7dO9a5v97Hs4/q9oPk1UoQjColMA6PEqcsgGNcpN55M7jJLnT+qF8514DvKkcQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yxe6CGxIA6TsfCQy/SwKYi2xyhMKFYw6crSmYkOmgJQDUUiSind lulsRF7ESPp7iSxJsTdt8MpDLGGNQo+mUeskaYefzBagc6MIq+o8ddfQ X-Gm-Gg: Acq92OEgZu4fdHIMtPfwhO3N+xqpLLFPflsFD9d+P978PF3aT8arkUjHKHdqiq6WuCk zAh5O4dXfjJGD7LUG65A7gqr82qErcA3CuJKLHny8dx0DE8uz+x8Nb7pcEAmfjrAwWQj/WUNjnF aXvrFDGwe9pMQvbxpZXPvSwk873SAWmEUjVk1/xU0G9SFGXGwny3mZz36RNXFiJUNypOBUZXomx iNhH4EkEYvtPo8msqQlJ8cYY8vKpIr9OJlInEDoYWXNIDRUOSG8TTU4jyaC0AngKdQ5BWrE0trQ 7G49lGuPpWd0D5khlV9aeXdlOHUrfJSinGFS3N4+oieOKJXN8yKRkO7/RfH9W6dllCx/ilOjK0k 3nwm+XZzbBkm4BHXSv3Q+McpnvLpLcnoa8NoYOTLxiqYfkq9Z3c5Xhv1mS7Fx7yDQHQO9wRrck2 Nqveg5PM+LweQORnUkHzIj1Rc3zHeX66TLx/6fNnwKZbscUcAjjMuwuEuTbg== X-Received: by 2002:a17:903:24c:b0:2bc:9f51:2922 with SMTP id d9443c01a7336-2beb06c45e1mr28671585ad.41.1779444232060; Fri, 22 May 2026 03:03:52 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb56f4343sm18683455ad.36.2026.05.22.03.03.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 03:03:51 -0700 (PDT) From: phucduc.bui@gmail.com To: broonie@kernel.org Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-rockchip@lists.infradead.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, bui duc phuc Subject: [PATCH 3/3] ASoC: rockchip: rockchip_pdm: Reorder clock enable sequence Date: Fri, 22 May 2026 17:03:18 +0700 Message-ID: <20260522100318.73474-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260522100318.73474-1-phucduc.bui@gmail.com> References: <20260522100318.73474-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Enable the 'hclk' bus clock before the 'clk' controller clock during runtime resume. The bus clock provides the register access interface and should be enabled before the controller clock. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_pdm.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchip_pdm.c index c69cdd6f2499..8f78f7bc1806 100644 --- a/sound/soc/rockchip/rockchip_pdm.c +++ b/sound/soc/rockchip/rockchip_pdm.c @@ -422,16 +422,16 @@ static int rockchip_pdm_runtime_resume(struct device *dev) struct rk_pdm_dev *pdm = dev_get_drvdata(dev); int ret; - ret = clk_prepare_enable(pdm->clk); + ret = clk_prepare_enable(pdm->hclk); if (ret) { - dev_err(pdm->dev, "clock enable failed %d\n", ret); + dev_err(pdm->dev, "hclock enable failed %d\n", ret); return ret; } - ret = clk_prepare_enable(pdm->hclk); + ret = clk_prepare_enable(pdm->clk); if (ret) { - clk_disable_unprepare(pdm->clk); - dev_err(pdm->dev, "hclock enable failed %d\n", ret); + clk_disable_unprepare(pdm->hclk); + dev_err(pdm->dev, "clock enable failed %d\n", ret); return ret; } -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31816CD5BB1 for ; Fri, 22 May 2026 10:03:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D0PyFBwL6Z3bdyqpcVQnFMf0MtEPX9BJbTejbloOQZs=; b=24Y70r8MTwG97N WEtChD6PZE8SQ5AVMNVhoU2frdpLvZceNvBFF+PZw22yY5JHm1Nb54kkmFbZwzr5020nS2iNe4p2q e5kqMXO3h6eMozxxdVhpBLW4pUYhuQtmOVg+kB8kJTqwPQ8FBwudes1cqDAf6jj56+sD1TnPrxXH8 jPu3KJkNGWZmXJmFZwBu5TFYHRF4zD9OBtYpN3nhO57hbUONNMudhxwy/UjyGHntBAiX47QAJUO14 Nlg43DkSvhP+PkyPMVTpPxapMBEk7FI2UNdjTBAdyGU+s7H2E3U5u8ekVBV+r4GH1RLWFXXLatLSG MEogFuJfhgODnzb5X2ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQMjT-0000000AQgR-14Vk; Fri, 22 May 2026 10:03:55 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQMjQ-0000000AQd5-30cZ for linux-rockchip@lists.infradead.org; Fri, 22 May 2026 10:03:53 +0000 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-2ba6485d219so53878945ad.3 for ; Fri, 22 May 2026 03:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779444232; x=1780049032; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ieAL7FXG9N2pPYlycZklbhAMC0pexNuJqkqoSDsbdHQ=; b=AHroY5c6l/AlhZAKhimXAeW4VSIFt8SE6DUIFDn8gmpde0gEQ0lczwanmdOwYFD1ET xzI+i6bpohhIJFl1VKT/9z5z7CmdJNJXnXxwSRjOd5Ok3t+q3DR2QKK4LJhLLBXCRTgE UPhotq6pTeP9I/Er5DqZGcKIk0tppH+622Lfgm/Kg4PNVK3KkxyURpGhDiqc+vRMUQkC cSGc+8/g//I1io/k4XC3p+80DYc1qc+0n6TOXEuWsow7i3Y5kQlRbcH7tSBg9eLYCTuT VD5r+IyzOyRoyqV+mvRxlmKiGAX9+AGKuWCRMw1NNa766lENPMq0tr9QNigUwBRhXAdm 4uFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779444232; x=1780049032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ieAL7FXG9N2pPYlycZklbhAMC0pexNuJqkqoSDsbdHQ=; b=ewEOhZd5nGkTw4UMDexwFxjiDmWVhy2wIZDuter0wyPWIZzbM/9H8TYYGD2aB/CU/M V99fqCp2X3S228JtETnf5t7dumyOvH88sy3DCReexon7sMPCeN5/H7FBtEmBrO0Lq/AH kQugFir6+WwpX1yuLKFinfh8zws80KmQiGd+gGyNK55vBASrgFD58kEEFbtpBr/EzPZU uT9yxIuETav9QVIiK8aGYWSGnxStBuyT/Gg3KvC3fEmxJd6kNaeZEcLwuksc9peehLBa af4JIBLwSBNWHiGl/Uo5huB0CSSqLNC3+HNBdr0ZZfmYjjj7b8gX/2ZJ4r9Nea0uWsxE 5gUQ== X-Forwarded-Encrypted: i=1; AFNElJ/fAZXT/Y7V80MRk47ikt2OlmUw9JMpXuXmmLcDk0PrnzyUBDBNCm+MH429vSGixi+bBQ1hVEVa9DzTiNkRAw==@lists.infradead.org X-Gm-Message-State: AOJu0YxEYJAwLjnWB/zyOhT52e9CFT8cTaorC5maK7VIuWYXv7KpPPcJ vEafrXfC1TSg316YvCiOo8qPUpK+42ERhvtclkXAdnZr6CJUv/liEbfO X-Gm-Gg: Acq92OHhCaRKS75hd1/mYCQDEgQFpDP9IsQ80rVICVspS+in+EqZQ4uqJj2BZq50S18 6Av/K3JBzr3a0wMVjW4x66SJ3vicR5WK8XRR0KBI3yt23ph8S3oNFoDJadClTPohWQ76x6+/Q0Q 7ZMKQ8iol2p+WiIPUVvLRpA6A6TnbCCnfUgQLWiFcqUoI3H5QafMCLUyv5remzPWlX9N6agYRdK zCJ12K22+yB5eTzs6Y1mpet52QuLHSqhFODezdsoe5K6C+nMhoea5B4PzAUCtd1HKUz52UipUk3 8r8iW4j/rXBtVTwpxLZyh+PSSrlA59ekYmkFBDGiMIBsbarXFZTHbJWTNqPy/Sh/8/MXcWQG5oB IsTioP7fjIitatUQEADx9koU43kpw7DbHmsvaUz8rCwbGEPzuovGi6VJfnyM4mBkAwBO1XiB2az c9PyMNHQ6yrJmmCPLmpljZ//FGyTukVZuSFEW30lwDzMVrEoE7Kljc6IEXYg== X-Received: by 2002:a17:903:24c:b0:2bc:9f51:2922 with SMTP id d9443c01a7336-2beb06c45e1mr28671585ad.41.1779444232060; Fri, 22 May 2026 03:03:52 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb56f4343sm18683455ad.36.2026.05.22.03.03.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 03:03:51 -0700 (PDT) From: phucduc.bui@gmail.com To: broonie@kernel.org Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-rockchip@lists.infradead.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, bui duc phuc Subject: [PATCH 3/3] ASoC: rockchip: rockchip_pdm: Reorder clock enable sequence Date: Fri, 22 May 2026 17:03:18 +0700 Message-ID: <20260522100318.73474-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260522100318.73474-1-phucduc.bui@gmail.com> References: <20260522100318.73474-1-phucduc.bui@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260522_030352_768170_59288B1B X-CRM114-Status: GOOD ( 10.17 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: bui duc phuc Enable the 'hclk' bus clock before the 'clk' controller clock during runtime resume. The bus clock provides the register access interface and should be enabled before the controller clock. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_pdm.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchip_pdm.c index c69cdd6f2499..8f78f7bc1806 100644 --- a/sound/soc/rockchip/rockchip_pdm.c +++ b/sound/soc/rockchip/rockchip_pdm.c @@ -422,16 +422,16 @@ static int rockchip_pdm_runtime_resume(struct device *dev) struct rk_pdm_dev *pdm = dev_get_drvdata(dev); int ret; - ret = clk_prepare_enable(pdm->clk); + ret = clk_prepare_enable(pdm->hclk); if (ret) { - dev_err(pdm->dev, "clock enable failed %d\n", ret); + dev_err(pdm->dev, "hclock enable failed %d\n", ret); return ret; } - ret = clk_prepare_enable(pdm->hclk); + ret = clk_prepare_enable(pdm->clk); if (ret) { - clk_disable_unprepare(pdm->clk); - dev_err(pdm->dev, "hclock enable failed %d\n", ret); + clk_disable_unprepare(pdm->hclk); + dev_err(pdm->dev, "clock enable failed %d\n", ret); return ret; } -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip