From: Imre Deak <imre.deak@intel.com>
To: <intel-gfx@lists.freedesktop.org>, <intel-xe@lists.freedesktop.org>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: [PATCH v2 1/4] drm/i915/dp: Reset link params after a DPRX capability change
Date: Fri, 22 May 2026 19:05:11 +0300 [thread overview]
Message-ID: <20260522160514.2628249-2-imre.deak@intel.com> (raw)
In-Reply-To: <20260522160514.2628249-1-imre.deak@intel.com>
There is no reason to distinguish between DPRX capability changes
signaled via a long HPD and via an RX_CAP_CHANGED HPD IRQ.
Both cases result in reading out the DPRX capabilities and updating the
corresponding sink and common capabilities cached in intel_dp, however
only the long HPD resets the link training/recovery state and MST link
probe parameters correspondingly. The link training/recovery state may
contain reduced maximum link rate/lane count values left over from a
previous link training failure.
Based on the above after an RX_CAP_CHANGED increased the link rate, lane
count parameters the maximum link rate/lane count in the link
training/recovery state may remain below these, leaving the newly added
valid configurations unavailable for subsequent modesets in an
inconsistent way.
Handle RX_CAP_CHANGED IRQs the same way as long HPDs and reset the link
recovery state and MST link probe parameters in that case as well.
v2: Set intel_dp::reset_link_params instead of using a helper for this.
(Ville).
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 1920d2f026665..940e73ad451d7 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -6000,8 +6000,10 @@ static bool intel_dp_handle_link_service_irq(struct intel_dp *intel_dp, u8 irq_m
drm_WARN_ON(display->drm, irq_mask & ~(INTEL_DP_LINK_SERVICE_IRQ_MASK_SST |
INTEL_DP_LINK_SERVICE_IRQ_MASK_MST));
- if (irq_mask & RX_CAP_CHANGED)
+ if (irq_mask & RX_CAP_CHANGED) {
+ intel_dp->reset_link_params = true;
reprobe_needed = true;
+ }
if (irq_mask & LINK_STATUS_CHANGED)
intel_dp_check_link_state(intel_dp);
--
2.49.1
next prev parent reply other threads:[~2026-05-22 16:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 16:05 [PATCH v2 0/4] drm/i915/dp: Sanitize link capability change handling Imre Deak
2026-05-22 16:05 ` Imre Deak [this message]
2026-05-22 16:05 ` [PATCH v2 2/4] drm/i915/dp: Add helper to set common link params Imre Deak
2026-05-22 16:05 ` [PATCH v2 3/4] drm/i915/dp: Cache max common lane count Imre Deak
2026-05-22 16:05 ` [PATCH v2 4/4] drm/i915/dp: Detect changes in common link parameters Imre Deak
2026-05-22 17:27 ` ✓ CI.KUnit: success for drm/i915/dp: Sanitize link capability change handling (rev2) Patchwork
2026-05-22 18:04 ` [PATCH v2 0/4] drm/i915/dp: Sanitize link capability change handling Ville Syrjälä
2026-05-22 18:07 ` ✓ Xe.CI.BAT: success for drm/i915/dp: Sanitize link capability change handling (rev2) Patchwork
2026-05-22 19:19 ` ✓ i915.CI.BAT: success for drm/i915/dp: Sanitize link capability change handling (rev3) Patchwork
2026-05-23 2:03 ` ✓ Xe.CI.FULL: success for drm/i915/dp: Sanitize link capability change handling (rev2) Patchwork
2026-05-24 1:54 ` ✓ i915.CI.Full: success for drm/i915/dp: Sanitize link capability change handling (rev3) Patchwork
2026-05-25 12:15 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260522160514.2628249-2-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.