Re: [PATCH 2/3] KVM: guest_memfd: Fix possible signed integer overflow

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The fallback stub definition of `kvm_gmem_bind()` for `!CONFIG_KVM_GUEST_MEMFD` was not updated to reflect the new `u64 offset` parameter type.
--

commit d25bb3b9adbe143acc8b3b7339c4bf637a62df32
Author: Sean Christopherson <seanjc@google.com>

KVM: guest_memfd: Fix possible signed integer overflow

This commit changes the type of the offset parameter in kvm_gmem_bind() from
loff_t to u64 to prevent potential signed integer overflow issues when passing
large 64-bit offsets. It also updates the local size variable to size_t.

> diff --git a/virt/kvm/kvm_mm.h b/virt/kvm/kvm_mm.h
> index 9fcc5d5b7f8d0..23813d74ce709 100644
> --- a/virt/kvm/kvm_mm.h
> +++ b/virt/kvm/kvm_mm.h
> @@ -72,7 +72,7 @@ int kvm_gmem_init(struct module *module);
>  void kvm_gmem_exit(void);
>  int kvm_gmem_create(struct kvm *kvm, struct kvm_create_guest_memfd *args);
>  int kvm_gmem_bind(struct kvm *kvm, struct kvm_memory_slot *slot,
> -		  unsigned int fd, loff_t offset);
> +		  unsigned int fd, u64 offset);
>  void kvm_gmem_unbind(struct kvm_memory_slot *slot);
>  #else
>  static inline int kvm_gmem_init(struct module *module)

[Severity: Low]
Does the fallback stub definition of kvm_gmem_bind() for !CONFIG_KVM_GUEST_MEMFD
also need to be updated to match this new signature?

It looks like the static inline stub in the #else block might still be expecting
loff_t offset, which could cause an inconsistent API signature and potentially
trigger compiler warnings.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522-fix-sev-gmem-post-populate-v1-0-9fc8d6437b65@google.com?part=2