From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
To: jikos@kernel.org, jic23@kernel.org, srinivas.pandruvada@linux.intel.com
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com,
linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 17/36] iio: accel: hid-sensor-accel-3d: use local struct device
Date: Mon, 25 May 2026 00:55:54 +0530 [thread overview]
Message-ID: <20260524192556.1195042-8-sanjayembedded@gmail.com> (raw)
In-Reply-To: <20260524192556.1195042-1-sanjayembedded@gmail.com>
From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Introduce a local struct device pointer derived from &pdev->dev.
This avoids repeated &pdev->dev usage and improves readability.
Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
---
drivers/iio/accel/hid-sensor-accel-3d.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
index 67fb8efd6b10..561d9784d936 100644
--- a/drivers/iio/accel/hid-sensor-accel-3d.c
+++ b/drivers/iio/accel/hid-sensor-accel-3d.c
@@ -328,7 +328,8 @@ static int accel_3d_parse_report(struct platform_device *pdev,
/* Function to initialize the processing for usage id */
static int hid_accel_3d_probe(struct platform_device *pdev)
{
- struct hid_sensor_hub_device *hsdev = dev_get_platdata(&pdev->dev);
+ struct device *dev = &pdev->dev;
+ struct hid_sensor_hub_device *hsdev = dev_get_platdata(dev);
int ret = 0;
const char *name;
struct iio_dev *indio_dev;
@@ -336,8 +337,7 @@ static int hid_accel_3d_probe(struct platform_device *pdev)
const struct iio_chan_spec *channel_spec;
int channel_size;
- indio_dev = devm_iio_device_alloc(&pdev->dev,
- sizeof(struct accel_3d_state));
+ indio_dev = devm_iio_device_alloc(dev, sizeof(struct accel_3d_state));
if (indio_dev == NULL)
return -ENOMEM;
@@ -364,21 +364,21 @@ static int hid_accel_3d_probe(struct platform_device *pdev)
accel_3d_sensitivity_addresses,
ARRAY_SIZE(accel_3d_sensitivity_addresses));
if (ret) {
- dev_err(&pdev->dev, "failed to setup common attributes\n");
+ dev_err(dev, "failed to setup common attributes\n");
return ret;
}
- indio_dev->channels = devm_kmemdup(&pdev->dev, channel_spec,
+ indio_dev->channels = devm_kmemdup(dev, channel_spec,
channel_size, GFP_KERNEL);
if (!indio_dev->channels) {
- dev_err(&pdev->dev, "failed to duplicate channels\n");
+ dev_err(dev, "failed to duplicate channels\n");
return -ENOMEM;
}
ret = accel_3d_parse_report(pdev, hsdev,
(struct iio_chan_spec *)indio_dev->channels,
hsdev->usage, accel_state);
if (ret) {
- dev_err(&pdev->dev, "failed to setup attributes\n");
+ dev_err(dev, "failed to setup attributes\n");
return ret;
}
@@ -391,13 +391,13 @@ static int hid_accel_3d_probe(struct platform_device *pdev)
ret = hid_sensor_setup_trigger(indio_dev, name,
&accel_state->common_attributes);
if (ret < 0) {
- dev_err(&pdev->dev, "trigger setup failed\n");
+ dev_err(dev, "trigger setup failed\n");
return ret;
}
ret = iio_device_register(indio_dev);
if (ret) {
- dev_err(&pdev->dev, "device register failed\n");
+ dev_err(dev, "device register failed\n");
goto error_remove_trigger;
}
@@ -407,7 +407,7 @@ static int hid_accel_3d_probe(struct platform_device *pdev)
ret = sensor_hub_register_callback(hsdev, hsdev->usage,
&accel_state->callbacks);
if (ret < 0) {
- dev_err(&pdev->dev, "callback reg failed\n");
+ dev_err(dev, "callback reg failed\n");
goto error_iio_unreg;
}
--
2.34.1
next prev parent reply other threads:[~2026-05-24 19:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 19:25 [PATCH v4 10/36] iio: gyro: hid-sensor-gyro-3d: align parenthesis for readability Sanjay Chitroda
2026-05-24 19:25 ` [PATCH v4 11/36] iio: magnetometer: hid-sensor-magn-3d: " Sanjay Chitroda
2026-05-24 19:25 ` [PATCH v4 12/36] iio: humidity: hid-sensor-humidity: use common device for devres Sanjay Chitroda
2026-05-24 19:25 ` [PATCH v4 13/36] iio: position: hid-sensor-custom-intel-hinge: " Sanjay Chitroda
2026-05-24 19:25 ` [PATCH v4 14/36] iio: temperature: hid-sensor-temperature: " Sanjay Chitroda
2026-05-24 19:25 ` [PATCH v4 15/36] iio: humidity: hid-sensor-humidity: use local struct device Sanjay Chitroda
2026-05-24 19:25 ` [PATCH v4 16/36] iio: gyro: hid-sensor-gyro-3d: " Sanjay Chitroda
2026-05-24 19:25 ` Sanjay Chitroda [this message]
2026-05-24 19:25 ` [PATCH v4 18/36] iio: light: hid-sensor-als: " Sanjay Chitroda
2026-05-24 19:25 ` [PATCH v4 19/36] iio: light: hid-sensor-prox: " Sanjay Chitroda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260524192556.1195042-8-sanjayembedded@gmail.com \
--to=sanjayembeddedse@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sakari.ailus@linux.intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.