All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: cros-kernel-buildreports@googlegroups.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [android-common:android12-kiwi-5.10 235/235] arch/x86/kernel/alternative.c:1541:2-3: Unneeded semicolon
Date: Mon, 25 May 2026 00:26:02 +0800	[thread overview]
Message-ID: <202605250044.G8sVBJa6-lkp@intel.com> (raw)

tree:   https://android.googlesource.com/kernel/common android12-kiwi-5.10
head:   8c66939857f7c1785dcf957b4374265db31c6af5
commit: 1f6e6683c46612baf01555e214d863aaa03c399b [235/235] x86/alternative: Relax text_poke_bp() constraint
config: x86_64-randconfig-r064-20260524 (https://download.01.org/0day-ci/archive/20260525/202605250044.G8sVBJa6-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 5bac06718f502014fade905512f1d26d578a18f3)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605250044.G8sVBJa6-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> arch/x86/kernel/alternative.c:1541:2-3: Unneeded semicolon

vim +1541 arch/x86/kernel/alternative.c

  1509	
  1510	static void text_poke_loc_init(struct text_poke_loc *tp, void *addr,
  1511				       const void *opcode, size_t len, const void *emulate)
  1512	{
  1513		struct insn insn;
  1514		int ret, i;
  1515	
  1516		memcpy((void *)tp->text, opcode, len);
  1517		if (!emulate)
  1518			emulate = opcode;
  1519	
  1520		ret = insn_decode_kernel(&insn, emulate);
  1521		BUG_ON(ret < 0);
  1522	
  1523		tp->rel_addr = addr - (void *)_stext;
  1524		tp->len = len;
  1525		tp->opcode = insn.opcode.bytes[0];
  1526	
  1527		switch (tp->opcode) {
  1528		case RET_INSN_OPCODE:
  1529		case JMP32_INSN_OPCODE:
  1530		case JMP8_INSN_OPCODE:
  1531			/*
  1532			 * Control flow instructions without implied execution of the
  1533			 * next instruction can be padded with INT3.
  1534			 */
  1535			for (i = insn.length; i < len; i++)
  1536				BUG_ON(tp->text[i] != INT3_INSN_OPCODE);
  1537			break;
  1538	
  1539		default:
  1540			BUG_ON(len != insn.length);
> 1541		};
  1542	
  1543	
  1544		switch (tp->opcode) {
  1545		case INT3_INSN_OPCODE:
  1546		case RET_INSN_OPCODE:
  1547			break;
  1548	
  1549		case CALL_INSN_OPCODE:
  1550		case JMP32_INSN_OPCODE:
  1551		case JMP8_INSN_OPCODE:
  1552			tp->disp = insn.immediate.value;
  1553			break;
  1554	
  1555		default: /* assume NOP */
  1556			switch (len) {
  1557			case 2: /* NOP2 -- emulate as JMP8+0 */
  1558				BUG_ON(memcmp(emulate, ideal_nops[len], len));
  1559				tp->opcode = JMP8_INSN_OPCODE;
  1560				tp->disp = 0;
  1561				break;
  1562	
  1563			case 5: /* NOP5 -- emulate as JMP32+0 */
  1564				BUG_ON(memcmp(emulate, ideal_nops[NOP_ATOMIC5], len));
  1565				tp->opcode = JMP32_INSN_OPCODE;
  1566				tp->disp = 0;
  1567				break;
  1568	
  1569			default: /* unknown instruction */
  1570				BUG();
  1571			}
  1572			break;
  1573		}
  1574	}
  1575	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-05-24 16:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202605250044.G8sVBJa6-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=cros-kernel-buildreports@googlegroups.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.