From: Jakub Kicinski <kuba@kernel.org>
To: Chuck Lever <cel@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Chris Mason <clm@meta.com>,
Christian Brauner <brauner@kernel.org>,
kernel-tls-handshake@lists.linux.dev,
linux-nvme@lists.infradead.org, netdev@vger.kernel.org,
Chuck Lever <chuck.lever@oracle.com>,
Hannes Reinecke <hare@kernel.org>,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH net v2 0/7] net/handshake: anchor request lifetime to a pinned file reference
Date: Mon, 25 May 2026 11:35:33 -0700 [thread overview]
Message-ID: <20260525113533.6405efa0@kernel.org> (raw)
In-Reply-To: <20260521-handshake-file-pin-v2-0-b9dadc472840@oracle.com>
On Thu, 21 May 2026 10:47:06 -0400 Chuck Lever wrote:
> Three things in this restructuring want a careful look. In
> handshake_complete(), the fput() of the request's file
> reference has to come after hp_done() -- fput() can transitively
> run handshake_sk_destruct() and free the request, so the patch
> stashes hr_file in a local first. handshake_sk_destruct()
> itself is kept on purpose: it owns rhashtable removal and
> kfree, and remains the backstop if a consumer path bypasses
> handshake_complete() entirely. Third, handshake_req_next() now
> returns its request with an extra get_file() held under
> hn_lock; accept_doit must consume that reference (FD_PREPARE on
> success, explicit fput on the fdf.err path), and any future
> caller has to honor the same contract.
Sashiko indicates races with handshake_req_cancel() remain,
and impact the code re-written by this series. What's your take?
next prev parent reply other threads:[~2026-05-25 18:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 14:47 [PATCH net v2 0/7] net/handshake: anchor request lifetime to a pinned file reference Chuck Lever
2026-05-21 14:47 ` [PATCH net v2 1/7] net/handshake: Drain pending requests at net namespace exit Chuck Lever
2026-05-21 14:47 ` [PATCH net v2 2/7] nvme-tcp: store negative errno in queue->tls_err Chuck Lever
2026-05-21 14:47 ` [PATCH net v2 3/7] net/handshake: Pass negative errno through handshake_complete() Chuck Lever
2026-05-21 14:47 ` [PATCH net v2 4/7] net/handshake: Take a long-lived file reference at submit Chuck Lever
2026-05-21 14:47 ` [PATCH net v2 5/7] net/handshake: hand off the pinned file reference to accept_doit Chuck Lever
2026-05-21 14:47 ` [PATCH net v2 6/7] net/handshake: Close the submit-side sock_hold race Chuck Lever
2026-05-21 14:47 ` [PATCH net v2 7/7] net/handshake: Verify file-reference balance in submit paths Chuck Lever
2026-05-25 18:35 ` Jakub Kicinski [this message]
2026-05-26 1:55 ` [PATCH net v2 0/7] net/handshake: anchor request lifetime to a pinned file reference Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260525113533.6405efa0@kernel.org \
--to=kuba@kernel.org \
--cc=alistair.francis@wdc.com \
--cc=brauner@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=clm@meta.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hare@kernel.org \
--cc=horms@kernel.org \
--cc=kernel-tls-handshake@lists.linux.dev \
--cc=linux-nvme@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.