Re: [PATCH v13 4/6] iio: adc: ad4691: add SPI offload support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly introduced C macro `AD4691_OFFLOAD_CHANNEL` incorrectly uses `.format = 'u'` instead of `.sign = 'u'` for the `struct iio_scan_type` designated initializer. `struct iio_scan_type` does not have a `format` member, which causes a build failure.
--

commit 93cce4b8ea73bcfdca8b9d9c533e462db205a412
Author: Radu Sabau <radu.sabau@analog.com>

iio: adc: ad4691: add SPI offload support

This patch adds SPI offload support to the AD4691 ADC driver to enable
DMA-based, CPU-independent data acquisition using the SPI Engine framework.

> diff --git a/drivers/iio/adc/ad4691.c b/drivers/iio/adc/ad4691.c
> index 2b7bb6717e574..6563488ab8b89 100644
> --- a/drivers/iio/adc/ad4691.c
> +++ b/drivers/iio/adc/ad4691.c
[ ... ]
> @@ -139,6 +150,30 @@ struct ad4691_chip_info {
>  		},							\
>  	}
>  
> +/*
> + * Offload path (bits_per_word=16): the SPI Engine assembles received
> + * bits into native 16-bit words before DMA, so samples are in
> + * CPU-native byte order (IIO_CPU). storagebits=16 matches the 16-bit
> + * DMA word size.
> + */
> +#define AD4691_OFFLOAD_CHANNEL(ch)					\
> +	{								\
> +		.type = IIO_VOLTAGE,					\
> +		.indexed = 1,						\
> +		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),		\
> +		.info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SCALE)	\
> +				    | BIT(IIO_CHAN_INFO_SAMP_FREQ),	\
> +		.info_mask_shared_by_all_available =			\
> +				      BIT(IIO_CHAN_INFO_SAMP_FREQ),	\
> +		.channel = ch,						\
> +		.scan_index = ch,					\
> +		.scan_type = {						\
> +			.format = 'u',					\

[Severity: Low]
Does this struct initialization cause a build failure? It looks like struct
iio_scan_type does not have a member named .format, and this should probably
be .sign instead.

> +			.realbits = 16,					\
> +			.storagebits = 16,				\
> +		},							\
> +	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525-ad4692-multichannel-sar-adc-driver-v13-0-1b7626d3b35c@analog.com?part=4