All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org, stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>,
	linux-kernel@vger.kernel.org, linkinjeon@kernel.org,
	stfrench@microsoft.com, d.ornaghi97@gmail.com,
	knavaneeth786@gmail.com, Alva Lan <alvalan9@foxmail.com>
Subject: Re: [PATCH 6.6.y v2 0/3] ksmbd: validate owner of durable handle on reconnect
Date: Mon, 25 May 2026 11:33:09 -0400	[thread overview]
Message-ID: <20260525152512.agent5-0006@kernel.org> (raw)
In-Reply-To: <tencent_290D1FB4A935031FBD9251D6D238B830AD08@qq.com>

On Mon, May 25, 2026 at 06:38:58PM +0800, Alva Lan wrote:
> This series backports three upstream commits to the 6.6.y stable branch
> to address CVE-2026-31717.
>
> Upstream commits:
> - 098c0ac3808c ("ksmbd: avoid reclaiming expired durable opens by the client")
> - 894947e0736d ("ksmbd: add durable scavenger timer")
> - 49110a8ce654 ("ksmbd: validate owner of durable handle on reconnect")

Two notes before this can be queued:

1. The short SHAs in the cover letter for patches 1 and 2 do not resolve
   in mainline. The correct upstream SHAs are 520da3c488c5 ("ksmbd:
   avoid reclaiming expired durable opens by the client") and
   d484d621d40f ("ksmbd: add durable scavenger timer"). Please fix the
   cover letter on the next spin.

2. More importantly, this series adds the durable scavenger
   (d484d621d40f) without its critical follow-up bf736184d063d ("ksmbd:
   close durable scavenger races against m_fp_list lookups", Fixes:
   d484d621d40f). That follow-up closes two KASAN-validated bugs in
   the scavenger code: an fp->node list-head reuse that corrupts
   f_ci->m_fp_list via list_add(&fp->node, &scavenger_list), and a
   refcount race between scavenger qualification under global_ft.lock
   and m_fp_list walkers that races to a UAF. Please include
   bf736184d063d in the next revision so we are not knowingly queuing
   the scavenger with these races still open.

Also, given the patches are authored by Namjae, an Acked-by from him
on the 6.6.y adaptation would be helpful before I pick this up.

-- 
Thanks,
Sasha

  parent reply	other threads:[~2026-05-25 15:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25 10:38 [PATCH 6.6.y v2 0/3] ksmbd: validate owner of durable handle on reconnect Alva Lan
2026-05-25 10:41 ` [PATCH 6.6.y v2 1/3] ksmbd: avoid reclaiming expired durable opens by the client Alva Lan
     [not found] ` <20260525104130.1252-1-alvalan9@foxmail.com>
2026-05-25 10:41   ` [PATCH 6.6.y v2 2/3] ksmbd: add durable scavenger timer Alva Lan
2026-05-26  2:22     ` Namjae Jeon
2026-05-26  3:07       ` Alva Lan
2026-05-26  4:32         ` Namjae Jeon
2026-05-25 10:41   ` [PATCH 6.6.y v2 3/3] ksmbd: validate owner of durable handle on reconnect Alva Lan
2026-05-25 15:33 ` Sasha Levin [this message]
2026-05-26  7:22   ` [PATCH 6.6.y v2 0/3] " Alva Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260525152512.agent5-0006@kernel.org \
    --to=sashal@kernel.org \
    --cc=alvalan9@foxmail.com \
    --cc=d.ornaghi97@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=knavaneeth786@gmail.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=stfrench@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.