From: Jason Gunthorpe <jgg@nvidia.com>
To: Maoyi Xie <maoyixie.tju@gmail.com>
Cc: Chengchang Tang <tangchengchang@huawei.com>,
Junxian Huang <huangjunxian6@hisilicon.com>,
Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/hns: fix dead empty check on head->root in setup_root_hem()
Date: Mon, 25 May 2026 12:51:21 -0300 [thread overview]
Message-ID: <20260525155121.GA2486765@nvidia.com> (raw)
In-Reply-To: <20260521132045.3430906-1-maoyixie.tju@gmail.com>
On Thu, May 21, 2026 at 09:20:45PM +0800, Maoyi Xie wrote:
> --- a/drivers/infiniband/hw/hns/hns_roce_hem.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hem.c
> @@ -1267,8 +1267,8 @@ setup_root_hem(struct hns_roce_dev *hr_dev, struct hns_roce_hem_list *hem_list,
> int i, total;
> int ret;
>
> - root_hem = list_first_entry(&head->root,
> - struct hns_roce_hem_item, list);
> + root_hem = list_first_entry_or_null(&head->root,
> + struct hns_roce_hem_item, list);
> if (!root_hem)
> return -ENOMEM;
Delete the if, the list can never be empty. The driver immediately
adds an entry after initializing it and never removes entries
Jason
next prev parent reply other threads:[~2026-05-25 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 13:20 [PATCH] RDMA/hns: fix dead empty check on head->root in setup_root_hem() Maoyi Xie
2026-05-25 15:51 ` Jason Gunthorpe [this message]
2026-05-26 5:46 ` [PATCH v2] RDMA/hns: drop dead empty check " Maoyi Xie
2026-06-03 18:16 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260525155121.GA2486765@nvidia.com \
--to=jgg@nvidia.com \
--cc=huangjunxian6@hisilicon.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maoyixie.tju@gmail.com \
--cc=tangchengchang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.