From: Petr Vorel <pvorel@suse.cz>
To: linuxtestproject.agent@gmail.com
Cc: ltp@lists.linux.it, LTP AI Reviewer <ltp-ai@noreply.github.com>
Subject: Re: [LTP] zram01: Specify filesystem type explicitly in mount
Date: Tue, 26 May 2026 09:18:38 +0200 [thread overview]
Message-ID: <20260526071838.GB144912@pevik> (raw)
In-Reply-To: <20260525194238.3953-1-linuxtestproject.agent@gmail.com>
> Hi Avinesh,
> On Mon, 25 May 2026 21:01:23 +0200, Avinesh Kumar wrote:
> > zram01: Specify filesystem type explicitly in mount
> > - for i in $(seq $dev_start $dev_end); do
> > - tst_res TINFO "mount /dev/zram$i"
> > + local i=$dev_start
> > + local fs
> > +
> > + for fs in $zram_filesystems; do
> > + tst_res TINFO "mount /dev/zram$i ($fs)"
> > mkdir zram$i
> > - ROD mount /dev/zram$i zram$i
> > + ROD mount -t "$fs" /dev/zram$i zram$i
> > dev_mounted=$i
> > + i=$((i + 1))
> > done
> Nit: the rest of the file uses `$(($i + 1))` (e.g. zram_makefs). Prefer
> `i=$(($i + 1))` here for consistency.
Good catch, but I'd prefer to use the form Avinesh posted (i.e. "i", not "$i").
And it's probably not worth to do the cleanup on the other place (neither in
this commit nor in the separate).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-05-26 7:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 19:01 [LTP] [PATCH] zram01: Specify filesystem type explicitly in mount Avinesh Kumar via ltp
2026-05-25 19:42 ` [LTP] " linuxtestproject.agent
2026-05-26 7:18 ` Petr Vorel [this message]
2026-05-26 6:57 ` [LTP] [PATCH] " Petr Vorel
2026-05-26 12:24 ` Cyril Hrubis
2026-05-26 13:29 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260526071838.GB144912@pevik \
--to=pvorel@suse.cz \
--cc=linuxtestproject.agent@gmail.com \
--cc=ltp-ai@noreply.github.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.