From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8EA1CD5BC8 for ; Tue, 26 May 2026 09:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uHRuw3NnK6AgBGarx8knCCOAtWjgfyWSFGEmakjDT8E=; b=r2wDQtP5rbR7ld OxV3Mg3DwI1iBYLEQn2QAck0tqCVjYx2d/vHQRzVDIIpr9y1AZb+jxKwpy4spWSBbU/Z/VvKQ8XOZ ZIJ8Yu7o7Rrsti1ZWAlDSHQEeBhhZbb8Zq7JlUi08/iiA/ELv8fB5DOIwsawKAFicJ0q/95y0XAeG 8LKDBy2wTAns+uQzE4HG5Wf/WwiRYccVT70D0zr7MDmztB9s0/hS+T9V/2LQ3c3YnFKKp6RBjZqKE xtYn59XRZilmBCRgiYRx1zbIJi+ZorJHqKey5Pfn/F9MRHLoLHymwzLEN2jl1kn4r1mejB32ryQpz x3K/pBvtRfsgoCSuGAPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wRoDj-00000001XYd-1b44; Tue, 26 May 2026 09:37:07 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wRoDi-00000001XYF-0RMC for linux-phy@lists.infradead.org; Tue, 26 May 2026 09:37:06 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 7B8396008A; Tue, 26 May 2026 09:37:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFFD71F000E9; Tue, 26 May 2026 09:37:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779788225; bh=5YVj5p6nDzAUgvsCP3gk/NVlrFiDlp9L2KIsR5vlaik=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=gQcCFQSw/MDOnvUOOQXh0JcTxiIk2PuxPYbK33ra0GzfJICC1MwMnU2+3v2siKK3m /rlGz0sFzL36V1JKZT5oA3+hYKUv6b+czwx6fasJm0iHWZBO4NJsyMX4czkmWcvee/ Yu+kbzXCQYUBwh9vOwk597tD/RMrMpoU1qojMgt6R9PZ9rnDWZ1+lw4UJYviztio7v CukDQYY/lVFVhKFI5y8YvIMboOzpr4EAMRsKWI7JG3CHW9ef/CT0e6YqYXXxH0QCw5 N186yayuNAPnEFpNaDm4Lb3JqJSZPzKQzhoMBABg8phFdXEi5fjI/nknIeKTPEb32f wVmgpcp46Uu3g== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 2/3] scsi: ufs: qcom: dt-bindings: Document the Hawi UFS controller To: palash.kambar@oss.qualcomm.com Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, neil.armstrong@linaro.org, vkoul@kernel.org, olteanv@gmail.com In-Reply-To: <20260526090956.2340262-3-palash.kambar@oss.qualcomm.com> References: <20260526090956.2340262-3-palash.kambar@oss.qualcomm.com> Date: Tue, 26 May 2026 09:37:04 +0000 Message-Id: <20260526093704.DFFD71F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gVGhlIG5ldyBjb21w YXRpYmxlIHN0cmluZyBgcWNvbSxoYXdpLXVmc2hjYCB3YXMgb21pdHRlZCBmcm9tIHRoZSBleGlz dGluZyBgaWYtdGhlbmAgY29uZGl0aW9uYWwgYmxvY2sgdGhhdCBlbmZvcmNlcyB0aGUgTUNRIHJl Z2lzdGVyIGNvbnN0cmFpbnRzLgotLQoKY29tbWl0IDZjYTg1Y2VlMzA5NDMxMDA4MWYwOTg4MWI0 ZDZkNmE5ZTk4N2IzMjcKQXV0aG9yOiBQYWxhc2ggS2FtYmFyIDxwYWxhc2gua2FtYmFyQG9zcy5x dWFsY29tbS5jb20+CgpzY3NpOiB1ZnM6IHFjb206IGR0LWJpbmRpbmdzOiBEb2N1bWVudCB0aGUg SGF3aSBVRlMgY29udHJvbGxlcgogICAgCkRvY3VtZW50IHRoZSBVRlMgQ29udHJvbGxlciBvbiB0 aGUgSGF3aSBQbGF0Zm9ybS4KCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy91ZnMvcWNvbSxzbTg2NTAtdWZzaGMueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy91ZnMvcWNvbSxzbTg2NTAtdWZzaGMueWFtbAo+IGluZGV4IGYyODY0 MWM2ZTY4ZmUuLjNkZTAwYWZmYTRjNjQgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL3Vmcy9xY29tLHNtODY1MC11ZnNoYy55YW1sCj4gKysrIGIvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Vmcy9xY29tLHNtODY1MC11ZnNoYy55YW1sClsg Li4uIF0KPiBAQCAtMjcsNiArMjgsNyBAQCBwcm9wZXJ0aWVzOgo+ICAgICAgaXRlbXM6Cj4gICAg ICAgIC0gZW51bToKPiAgICAgICAgICAgIC0gcWNvbSxlbGl6YS11ZnNoYwo+ICsgICAgICAgICAg LSBxY29tLGhhd2ktdWZzaGMKPiAgICAgICAgICAgIC0gcWNvbSxrYWFuYXBhbGktdWZzaGMKPiAg ICAgICAgICAgIC0gcWNvbSxzbTg2NTAtdWZzaGMKPiAgICAgICAgICAgIC0gcWNvbSxzbTg3NTAt dWZzaGMKCltTZXZlcml0eTogTWVkaXVtXQpTaG91bGQgcWNvbSxoYXdpLXVmc2hjIGFsc28gYmUg YWRkZWQgdG8gdGhlIGFsbE9mIGNvbmRpdGlvbmFsIGJsb2NrIHRoYXQKZW5mb3JjZXMgdGhlIE1D USByZWdpc3RlciBjb25zdHJhaW50cz8KCklmIHRoZSBuZXcgY29tcGF0aWJsZSBzdHJpbmcgc2hh cmVzIHRoZSBzYW1lIGNvbnN0cmFpbnRzIGFzIHByZXZpb3VzCmdlbmVyYXRpb25zLCBkZXZpY2Ug dHJlZSBjb25maWd1cmF0aW9ucyB3aXRoIG9ubHkgb25lIHJlZ2lzdGVyIHJlZ2lvbiBjb3VsZApz aWxlbnRseSBwYXNzIHNjaGVtYSB2YWxpZGF0aW9uLgoKTG9va2luZyBhdCB0aGUgZXhpc3Rpbmcg Y29uZGl0aW9uYWwgYmxvY2sgbG93ZXIgZG93biBpbiB0aGUgZmlsZToKCmFsbE9mOgogIC0gJHJl ZjogcWNvbSx1ZnMtY29tbW9uLnlhbWwKICAtIGlmOgogICAgICBwcm9wZXJ0aWVzOgogICAgICAg IGNvbXBhdGlibGU6CiAgICAgICAgICBjb250YWluczoKICAgICAgICAgICAgZW51bToKICAgICAg ICAgICAgICAtIHFjb20sZWxpemEtdWZzaGMKICAgIHRoZW46CiAgICAgIHByb3BlcnRpZXM6CiAg ICAgICAgcmVnOgogICAgICAgICAgbWluSXRlbXM6IDIKICAgICAgICByZWctbmFtZXM6CiAgICAg ICAgICBtaW5JdGVtczogMgoKRG9lcyB0aGlzIGlmLXRoZW4gYmxvY2sgbmVlZCB0byBiZSB1cGRh dGVkIHRvIGluY2x1ZGUgdGhlIG5ldyBjb21wYXRpYmxlCnN0cmluZyBzbyB0aGUgdmFsaWRhdGlv biByZW1haW5zIGNvbXBsZXRlPwoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2Fz aGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDUyNjA5MDk1Ni4yMzQwMjYyLTEtcGFsYXNoLmthbWJh ckBvc3MucXVhbGNvbW0uY29tP3BhcnQ9MgoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGlu dXgtcGh5QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95E363CE0A1 for ; Tue, 26 May 2026 09:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779788226; cv=none; b=aP46CdIZolVW0NyERZHYl/AE3Jn1oPzuVp5gEuYBRrRhoCEvGmTe9c0p+i5+6I0j0pKN8+18x8ZFiXh42dKEdNZ2vX+dyt6mgNOZTacreZZSh9toI71th/K71iG4R+tKkb/yMVBuogP94eCxWpi7Ze5kyrI/pQeCFe2XGLQ/AWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779788226; c=relaxed/simple; bh=d5zBZkcEf37y9vpEdjI3Ey+iwV7gQTtSgCS81wQpvM4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=NHk1mYkWmlEOP8q3zZOR93uCgFsjbreOUSesibYxY+fo5vvyW9gr53heWXbF5Iypwqtqlh1b/7w4z45dslZNVaT8iK6X4LhncnB7ckj5c7lxBOhWwFewU3BQodrjhP+4TUBhyADgkTZzFnPwtVR/FerJgbfPNomL3zjwiBcduyY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gQcCFQSw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gQcCFQSw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFFD71F000E9; Tue, 26 May 2026 09:37:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779788225; bh=5YVj5p6nDzAUgvsCP3gk/NVlrFiDlp9L2KIsR5vlaik=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=gQcCFQSw/MDOnvUOOQXh0JcTxiIk2PuxPYbK33ra0GzfJICC1MwMnU2+3v2siKK3m /rlGz0sFzL36V1JKZT5oA3+hYKUv6b+czwx6fasJm0iHWZBO4NJsyMX4czkmWcvee/ Yu+kbzXCQYUBwh9vOwk597tD/RMrMpoU1qojMgt6R9PZ9rnDWZ1+lw4UJYviztio7v CukDQYY/lVFVhKFI5y8YvIMboOzpr4EAMRsKWI7JG3CHW9ef/CT0e6YqYXXxH0QCw5 N186yayuNAPnEFpNaDm4Lb3JqJSZPzKQzhoMBABg8phFdXEi5fjI/nknIeKTPEb32f wVmgpcp46Uu3g== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 2/3] scsi: ufs: qcom: dt-bindings: Document the Hawi UFS controller Reply-To: sashiko-reviews@lists.linux.dev To: palash.kambar@oss.qualcomm.com Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, neil.armstrong@linaro.org, vkoul@kernel.org, olteanv@gmail.com In-Reply-To: <20260526090956.2340262-3-palash.kambar@oss.qualcomm.com> References: <20260526090956.2340262-3-palash.kambar@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 26 May 2026 09:37:04 +0000 Message-Id: <20260526093704.DFFD71F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The new compatible string `qcom,hawi-ufshc` was omitted from the= existing `if-then` conditional block that enforces the MCQ register constr= aints. -- commit 6ca85cee3094310081f09881b4d6d6a9e987b327 Author: Palash Kambar scsi: ufs: qcom: dt-bindings: Document the Hawi UFS controller =20 Document the UFS Controller on the Hawi Platform. > diff --git a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml= b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml > index f28641c6e68fe..3de00affa4c64 100644 > --- a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml > +++ b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml [ ... ] > @@ -27,6 +28,7 @@ properties: > items: > - enum: > - qcom,eliza-ufshc > + - qcom,hawi-ufshc > - qcom,kaanapali-ufshc > - qcom,sm8650-ufshc > - qcom,sm8750-ufshc [Severity: Medium] Should qcom,hawi-ufshc also be added to the allOf conditional block that enforces the MCQ register constraints? If the new compatible string shares the same constraints as previous generations, device tree configurations with only one register region could silently pass schema validation. Looking at the existing conditional block lower down in the file: allOf: - $ref: qcom,ufs-common.yaml - if: properties: compatible: contains: enum: - qcom,eliza-ufshc then: properties: reg: minItems: 2 reg-names: minItems: 2 Does this if-then block need to be updated to include the new compatible string so the validation remains complete? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260526090956.2340= 262-1-palash.kambar@oss.qualcomm.com?part=3D2