Re: [LTP] [PATCH v2 1/2] safe_macros: Add SAFE_READ_ANY_EAGAIN

[Petr Vorel <pvorel@suse.cz>]

Hi Cyril,

...
> +/* supported values for safe_read() len_strict parameter */
Could we have kerneldoc (ok to fix before merge).

/**
 * enum safe_read_opts - supported values for safe_read() len_strict parameter */
 *
 * @SAFE_READ_ANY: no length strictness, short reads are ok.
 * @SAFE_READ_ALL: strict length, short reads trigger :c:enum:`TBROK <tst_res_flags>`.
 * @SAFE_READ_ANY_EAGAIN: converts EAGAIN to read that returns 0.
 */

Otherwise LGTM, thanks for spotting the error.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> +enum safe_read_opts {
> +	/* no length strictness, short reads are ok */
> +	SAFE_READ_ANY = 0,
> +
> +	/* strict length, short reads trigger TBROK */
> +	SAFE_READ_ALL = 1,
> +
> +	/* converts EAGAIN to read that returns 0 */
> +	SAFE_READ_ANY_EAGAIN = 2,
> +};
...

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp