From: Jakub Kicinski <kuba@kernel.org>
To: Maciek Machnikowski <maciek@machnikowski.net>
Cc: netdev@vger.kernel.org, richardcochran@gmail.com,
milena.olech@intel.com, willemdebruijn.kernel@gmail.com,
andrew@lunn.ch, vadim.fedorenko@linux.dev, horms@kernel.org
Subject: Re: [PATCH v6 net-next 3/3] selftests:net: Implement ptp4l sync test using netdevsim
Date: Tue, 26 May 2026 15:17:55 -0700 [thread overview]
Message-ID: <20260526151755.06ba2041@kernel.org> (raw)
In-Reply-To: <f10b3ddd-d403-48d3-ad0c-25b0e2d9d64d@machnikowski.net>
On Tue, 26 May 2026 17:10:46 +0200 Maciek Machnikowski wrote:
> >> +# By default, it:
> >> +# - Creates two netdevsim instances in separate namespaces
> >> +# - Assigns IPv4 addresses and links them together
> >> +# - Uses those interfaces as leader/follower endpoints for ptp4l
> >> +# Optional: --leader and --follower override endpoints with existing
> >> +# interfaces. Each argument can be either "ifname" (initial netns) or
> >> +# "netns:ifname". Both options must be provided together.
> >
> > Please use the existing DrvEpEnv infra!?
>
> It exists in the tools/testing/selftest/drivers/net and this script is
> in tools/testing/selftest/net. I can either keep the self-contained
> test only, or move the script to the drivers/net - which one is preferred?
I assume you are adding the CLI --leader and --follower options to run
this against a real device, not netdevsim. In this case of course the
test should live under tools/testing/selftest/drivers/net
prev parent reply other threads:[~2026-05-26 22:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 9:45 [PATCH v6 net-next 0/3] Implement PTP support in netdevsim Maciek Machnikowski
2026-05-13 9:45 ` [PATCH v6 net-next 1/3] ptp_mock: Expose ptp_clock_info to external drivers Maciek Machnikowski
2026-05-13 9:45 ` [PATCH v6 net-next 2/3] netdevsim: Implement basic ptp support Maciek Machnikowski
2026-05-17 14:07 ` Simon Horman
2026-05-13 9:45 ` [PATCH v6 net-next 3/3] selftests:net: Implement ptp4l sync test using netdevsim Maciek Machnikowski
2026-05-19 0:42 ` Jakub Kicinski
2026-05-26 15:10 ` Maciek Machnikowski
2026-05-26 22:17 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260526151755.06ba2041@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=horms@kernel.org \
--cc=maciek@machnikowski.net \
--cc=milena.olech@intel.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.