From: linuxtestproject.agent@gmail.com
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] mem/min_free_kbytes: Add grace period for memory reclaim
Date: Wed, 27 May 2026 05:31:00 +0000 [thread overview]
Message-ID: <20260527053100.4072-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260527050843.14963-1-wegao@suse.com>
Hi Wei,
On Wed, May 27 2026, Wei Gao wrote:
> mem/min_free_kbytes: Add grace period for memory reclaim
> +for (i = 1; i < 1024; i *= 2) {
> +usleep(i * 1000);
> +memfree = SAFE_READ_MEMINFO("MemFree:");
> +if (memfree >= tune)
> +break;
> +}
The exponential-backoff polling is the right approach here — async kernel
reclaim is exactly the case Ground Rule 2 calls out for this pattern.
> -sleep(2);
> +usleep(100000);
Reducing the polling interval from 2s to 100ms is fine.
[...]
All good. Approved.
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-05-27 5:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 5:08 [LTP] [PATCH v2] mem/min_free_kbytes: Add grace period for memory reclaim Wei Gao via ltp
2026-05-27 5:31 ` linuxtestproject.agent [this message]
2026-05-27 15:40 ` Cyril Hrubis
2026-05-29 16:07 ` Petr Vorel
2026-05-31 13:51 ` Wei Gao via ltp
2026-05-31 13:40 ` [LTP] [PATCH v3] min_free_kbytes: Handle transient memory drops in check_monitor Wei Gao via ltp
2026-06-01 6:42 ` [LTP] " linuxtestproject.agent
2026-06-02 1:00 ` [LTP] [PATCH v4] " Wei Gao via ltp
2026-06-02 4:02 ` [LTP] " linuxtestproject.agent
2026-06-02 7:46 ` Wei Gao via ltp
2026-06-02 16:07 ` Andrea Cervesato via ltp
2026-06-03 3:07 ` Wei Gao via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527053100.4072-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.