From: William Breathitt Gray <wbg@kernel.org>
To: Stepan Ionichev <sozdayvek@gmail.com>
Cc: William Breathitt Gray <wbg@kernel.org>,
o.rempel@pengutronix.de, kernel@pengutronix.de,
joshua.crofts1@gmail.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, andy@kernel.org
Subject: Re: [PATCH v2] counter: interrupt-cnt: use devm_mutex_init()
Date: Wed, 27 May 2026 15:56:31 +0900 [thread overview]
Message-ID: <20260527065632.502242-1-wbg@kernel.org> (raw)
In-Reply-To: <20260525151152.7238-1-sozdayvek@gmail.com>
On Mon, May 25, 2026 at 08:11:52PM +0500, Stepan Ionichev wrote:
> interrupt_cnt_probe() calls mutex_init() but neither this driver
> nor the counter core issues a matching mutex_destroy() on unbind,
> which leaks the lock debug state when CONFIG_DEBUG_MUTEXES is
> enabled.
>
> Switch to devm_mutex_init() so the mutex is torn down in the same
> devm scope it was set up in.
>
> Fixes: a55ebd47f21f ("counter: add IRQ or GPIO based counter")
The mutex_init() code was added in 7351312632e8 ("counter:
interrupt-cnt: Protect enable/disable OPs with mutex"), so the Fixes tag
should refer to that commit.
William Breathitt Gray
next prev parent reply other threads:[~2026-05-27 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 15:11 [PATCH v2] counter: interrupt-cnt: use devm_mutex_init() Stepan Ionichev
2026-05-27 6:56 ` William Breathitt Gray [this message]
2026-05-27 16:55 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527065632.502242-1-wbg@kernel.org \
--to=wbg@kernel.org \
--cc=andy@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=sozdayvek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.