From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: LTP AI Reviewer <ltp-ai@noreply.github.com>,
ltp@lists.linux.it, linuxtestproject.agent@gmail.com
Subject: Re: [LTP] checkpatch: Pass git root
Date: Wed, 27 May 2026 09:37:49 +0200 [thread overview]
Message-ID: <20260527073749.GB231966@pevik> (raw)
In-Reply-To: <6a0c25a4.a8d7227c.15d3fa.10da@mx.google.com>
Hi Andrea,
> Hi Petr,
> > Hi Petr,
> > On Wed, 13 May 2026, Petr Vorel wrote:
> > > checkpatch: Pass git root
> > > -CHECK_NOFLAGS ?= CHECKPATCH_CONFIG_DIR="$(abs_top_srcdir)" $(abs_top_srcdir)/scripts/checkpatch.pl -f
> > > +CHECK_NOFLAGS ?= CHECKPATCH_CONFIG_DIR="$(abs_top_srcdir)" $(abs_top_srcdir)/scripts/checkpatch.pl -f --root $(abs_top_srcdir)
The original patch is:
-CHECK_NOFLAGS ?= CHECKPATCH_CONFIG_DIR="$(abs_top_srcdir)" $(abs_top_srcdir)/scripts/checkpatch.pl -f
+CHECK_NOFLAGS ?= CHECKPATCH_CONFIG_DIR="$(abs_top_srcdir)" $(abs_top_srcdir)/scripts/checkpatch.pl -f --root $(abs_top_srcdir)
https://lists.linux.it/pipermail/ltp/2026-May/048397.html
https://lore.kernel.org/ltp/20260513134948.77923-1-pvorel@suse.cz/
https://patchwork.ozlabs.org/project/ltp/patch/20260513134948.77923-1-pvorel@suse.cz/
> > Note: there is a double space between `-f` and `--root`; consider collapsing
> > to a single space for consistency.
> Can you please fix this before merging the patch?
This is really funny. Interesting variant of hallucination. AI just added space
and pointed it out as my error.
Anyway, patch merged, no modification was needed. Thanks for your review.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-05-27 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 13:49 [LTP] [PATCH 1/1] checkpatch: Pass git root Petr Vorel
2026-05-13 16:22 ` [LTP] " linuxtestproject.agent
2026-05-19 8:56 ` Andrea Cervesato via ltp
2026-05-27 7:37 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527073749.GB231966@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=linuxtestproject.agent@gmail.com \
--cc=ltp-ai@noreply.github.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.