Re: [PATCH v2 03/24] arm64: dts: qcom: sdm670: Reduce OS PDC DRV span to 0x10000

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Reducing the PDC `reg` size to 0x10000 conflicts with the `qcom-pdc` driver, triggering a boot warning.
--

commit 91616deec930abcc3788af870cfe06cc7cfb6809
Author: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>

arm64: dts: qcom: sdm670: Reduce OS PDC DRV span to 0x10000

This commit reduces the size of the PDC register window in the sdm670 device
tree from 0x30000 to 0x10000.

> diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi
> --- a/arch/arm64/boot/dts/qcom/sdm670.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi
> @@ -1618,7 +1618,7 @@ usb_1_dwc3: usb@a600000 {
>  
>  		pdc: interrupt-controller@b220000 {
>  			compatible = "qcom,sdm670-pdc", "qcom,pdc";
> -			reg = <0 0x0b220000 0 0x30000>;
> +			reg = <0 0x0b220000 0 0x10000>;

[Severity: Medium]
Will this change trigger a boot warning from the qcom-pdc driver?

Looking at drivers/irqchip/qcom-pdc.c, the driver enforces a minimum
mapping size of 0x30000:

drivers/irqchip/qcom-pdc.c:
#define QCOM_PDC_SIZE 0x30000

...

qcom_pdc_probe() {
	...
	res_size = max_t(resource_size_t, resource_size(&res), QCOM_PDC_SIZE);
	if (res_size > resource_size(&res))
		pr_warn("%pOF: invalid reg size, please fix DT\n", node);
	...
}

If the device tree size is reduced to 0x10000, won't the driver fall back
to the 0x30000 minimum anyway and log an "invalid reg size, please fix DT"
warning during boot?

>  			qcom,pdc-ranges = <0 480 40>, <41 521 7>, <49 529 4>,
>  					  <54 534 24>, <79 559 15>, <94 609 15>,
>  					  <115 630 7>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260527094333.2311731-1-mukesh.ojha@oss.qualcomm.com?part=3