Re: [PATCHv6 bpf-next 01/29] ftrace: Add ftrace_hash_count function

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing a fallback stub for `ftrace_hash_count` when `CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS` is disabled.
--

commit 78dc69c9f694d0e9d50e5ac39e06f35ffd293fdf
Author: Jiri Olsa <jolsa@kernel.org>

ftrace: Add ftrace_hash_count function

This commit adds an external ftrace_hash_count() function to allow retrieving
the hash count outside of the ftrace object.

> diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
> index 28b30c6f10314..282da661f1313 100644
> --- a/include/linux/ftrace.h
> +++ b/include/linux/ftrace.h
> @@ -551,6 +551,8 @@ int update_ftrace_direct_mod(struct ftrace_ops *ops, struct ftrace_hash *hash, b
>  
>  void ftrace_stub_direct_tramp(void);
>  
> +unsigned long ftrace_hash_count(struct ftrace_hash *hash);
> +
>  #else

[Severity: Low]
Is a fallback stub for ftrace_hash_count() needed here when
CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS is disabled?

Other direct call functions in this header provide static inline fallbacks
in the #else block. Since struct ftrace_hash is gated by the broader
CONFIG_DYNAMIC_FTRACE config, if an external built-in caller uses this
function on a kernel configured without direct calls, could this cause a
build failure due to an implicit declaration?

>  struct ftrace_ops;
>  static inline unsigned long ftrace_find_rec_direct(unsigned long ip)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260527113951.46265-2-jolsa@kernel.org?part=1