From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Warner Losh <imp@bsdimp.com>,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: on ai generated and code provenance
Date: Wed, 27 May 2026 12:39:07 -0400 [thread overview]
Message-ID: <20260527123503-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <f8791a2d-257b-4233-aafb-ccd45e695542@redhat.com>
On Wed, May 27, 2026 at 12:01:10PM +0200, Paolo Bonzini wrote:
> Commit messages for AI-assisted changes
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> When AI/LLM tools produce or substantively shape your patch, add an
> ``AI-used-for:`` trailer. The text of the trailer could be one or more of
> ``code``, ``tests``, ``docs``, ``research``, possibly followed by an
> explanation in parentheses::
>
> AI-used-for: tests, docs
> AI-used-for: code
> AI-used-for: code (refactoring)
> AI-used-for: code (prototype)
> AI-used-for: research
>
> The trailer is intended as a clarification of your DCO obligations as well
> as to guide reviewers. It is not intended for minimal presence such as
> autocomplete or asking for a pre-review of the patch, and it does not remove
> your responsibility to understand the changes that you are submitting.
>
> Include the prompt in the commit message if it helps a reviewer judge the
> result:
>
> * yes: "move field ``foo`` from ``struct aa`` to ``struct bb``. If a
> function already has a local variable or parameter of type ``struct bb``,
> use it instead of accessing ``aa.bb``."
>
> * yes: "add an implementation of the trait for ``Mutex<T: MyTrait>``,
> forwarding the member functions to ``T`` while taking the lock around the
> calls".
>
> * no: "write user-facing documentation for the new tool"
>
> * no: "write testcases for the new functions"
I don't understand what these yes/no examples are trying to show.
AI tools aren't really yet up to the task of generating a reasonable
qemu patchset from a single prompt. As a reviewer, I am not really
interested what kind of magic "think extra ultra hard" invocation was
used to coax the output from the model.
I actually would like to know which model was used, since I expect that
with time I'll learn to trust output from specific models more just
like I trust output from specific contributors more.
--
MST
next prev parent reply other threads:[~2026-05-27 16:39 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 12:42 on ai generated and code provenance Michael S. Tsirkin
2026-05-24 17:06 ` Alex Bennée
2026-05-24 17:42 ` Michael S. Tsirkin
2026-05-24 18:26 ` Warner Losh
2026-05-24 20:04 ` Michael S. Tsirkin
2026-05-24 20:11 ` Michael S. Tsirkin
2026-05-24 20:44 ` Stefan Hajnoczi
2026-05-25 15:27 ` Stefan Hajnoczi
2026-05-25 16:32 ` Paolo Bonzini
2026-05-25 17:15 ` Warner Losh
2026-05-25 19:44 ` Stefan Hajnoczi
2026-05-25 22:36 ` Michael S. Tsirkin
2026-05-26 13:16 ` Stefan Hajnoczi
2026-05-25 19:56 ` Paolo Bonzini
2026-05-26 21:48 ` Philippe Mathieu-Daudé
2026-05-26 8:23 ` Peter Maydell
2026-05-26 9:28 ` Alex Bennée
2026-05-26 9:57 ` Paolo Bonzini
2026-05-26 11:27 ` BALATON Zoltan
2026-05-26 12:30 ` Michael S. Tsirkin
2026-05-26 12:37 ` Manos Pitsidianakis
2026-05-26 13:00 ` Michael S. Tsirkin
2026-05-26 13:22 ` Stefan Hajnoczi
2026-05-26 14:01 ` Warner Losh
2026-05-27 7:11 ` Philippe Mathieu-Daudé
2026-05-26 17:43 ` Kevin Wolf
2026-05-26 18:03 ` Michael S. Tsirkin
2026-05-26 18:59 ` Kevin Wolf
2026-05-26 19:30 ` Michael S. Tsirkin
2026-05-26 19:52 ` Warner Losh
2026-05-27 8:41 ` Kevin Wolf
2026-05-27 10:01 ` Paolo Bonzini
2026-05-27 10:43 ` Alex Bennée
2026-05-27 12:49 ` Kevin Wolf
2026-05-27 10:53 ` Kevin Wolf
2026-05-27 12:33 ` Paolo Bonzini
2026-05-27 12:43 ` Michael S. Tsirkin
2026-05-27 10:54 ` Alistair Francis
2026-05-27 14:21 ` Warner Losh
2026-05-28 1:59 ` Alistair Francis
2026-05-28 5:06 ` Michael S. Tsirkin
2026-05-28 7:32 ` Paolo Bonzini
2026-05-27 14:11 ` Michael S. Tsirkin
2026-05-27 14:14 ` Warner Losh
2026-05-27 14:51 ` Kevin Wolf
2026-05-27 16:41 ` Michael S. Tsirkin
2026-05-27 16:50 ` Kevin Wolf
2026-05-27 16:56 ` Michael S. Tsirkin
2026-05-27 17:06 ` Michael S. Tsirkin
2026-05-27 17:15 ` Warner Losh
2026-05-27 17:07 ` Warner Losh
2026-05-27 16:05 ` Paolo Bonzini
2026-05-27 16:48 ` Michael S. Tsirkin
2026-05-27 16:57 ` Warner Losh
2026-05-27 17:05 ` Michael S. Tsirkin
2026-05-27 17:48 ` Paolo Bonzini
2026-05-27 16:39 ` Michael S. Tsirkin [this message]
2026-05-26 19:50 ` Michael S. Tsirkin
2026-05-27 7:44 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527123503-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=imp@bsdimp.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.