From: Heiko Carstens <hca@linux.ibm.com>
To: David Laight <david.laight.linux@gmail.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Manuel Ebner <manuelebner@mailbox.org>,
Kees Cook <kees@kernel.org>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390/string: Remove strlcat() implementation
Date: Wed, 27 May 2026 16:08:46 +0200 [thread overview]
Message-ID: <20260527140846.9471D18-hca@linux.ibm.com> (raw)
In-Reply-To: <20260527140358.3838d1b5@pumpkin>
On Wed, May 27, 2026 at 02:03:58PM +0100, David Laight wrote:
> On Fri, 22 May 2026 16:31:11 +0200
> Heiko Carstens <hca@linux.ibm.com> wrote:
>
> > strlcat() shouldn't be used anymore (see fortify-string.h), and will be
> > deprecated / removed sooner or later [1].
> >
> ....
> > #define __HAVE_ARCH_STRCAT /* inline & arch function */
> ...
> > #define __HAVE_ARCH_STRNCAT /* arch function */
>
> Those two should probably have gone first ...
Yes, except that we need strcat() for the boot code - there we cannot use the
generic variant. Of course it would be possible to copy the existing strcat()
implementation to the boot code, rename it to e.g. strconcatenate(), and
strcat()/strncat() would be gone, at least grep wise :)
prev parent reply other threads:[~2026-05-27 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 14:31 [PATCH] s390/string: Remove strlcat() implementation Heiko Carstens
2026-05-27 12:39 ` Alexander Gordeev
2026-05-27 13:03 ` David Laight
2026-05-27 14:08 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527140846.9471D18-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david.laight.linux@gmail.com \
--cc=gor@linux.ibm.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=manuelebner@mailbox.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.