From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB9463EBF3B for ; Wed, 27 May 2026 14:55:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779893718; cv=none; b=gGH3HcrU2tY9ax3MUs77Gni3kWOxID4w+izP0d6iYGAqtKtnK6qbapcCx9PneedNx4wVO+VqngZWWj4KGjlryP90E/tddZVte1ldWPr5LYIOnfSNzV52DDg+bFL7hNP3dqLPspgqUOREW0lKlmwftHm9qnmrLfWQ8IxmZMXk93w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779893718; c=relaxed/simple; bh=vo78ECXfafqNzCWDNaTHK7KvJ81q+tP6hy87AgV8uyY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O21t9hDHvbgOlHZ9LuNFzTLAFEve28ceVMW7st/7zQSRc5tuDXo49xyqZ5q+MXwchvluDWTKID+NVxdsxwk4WkCiO2rzuoeLkMWNatmr57hsIaThEX7VdELNHIa+92rWlC1JYbDp1wtYZkVAGyqqE68924do8zlewjx2dq5IcKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UkU6uQ35; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UkU6uQ35" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 157F41F00A3D; Wed, 27 May 2026 14:55:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779893717; bh=sY/TVqy3uC7O75twxr1NslKF+o2JmY9Df75dLar6AWc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=UkU6uQ35ng8UBJZ2ZxsJaHd3FFGLYpNbmVjkbNN1IUww/fqMggQfqqLQjCW+bWWBI unNQFBRXAFbI7NSUnNi95fu0v9OLNFKHRhYKhofp1IvbPgTdlq/w4W0a0vHUadj3hi AhsvtWxQnh1PwVeongwstvX7Mn8K/tyR0CLwi0Ls+n80BbkImNVmL0wuO05ZaIiy2r a3Hal+d+Tm6Q8ag5vMlglseXueafh7943/ihoZw54VjsOZBk8s7KeN7KcMgwPBToIb suHyF2me2ssuBYaooyvyPQu7jaS9Q+UaXKNPY9yZ4TnFdwsXb5/dwxUqsgZumldMj2 /l9FD0epjRMKw== Date: Wed, 27 May 2026 15:55:12 +0100 From: Lee Jones To: Manikandan Muralidharan Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/8] drm: atmel-hlcdc: add XLCDC clock bypass support for small dividers Message-ID: <20260527145512.GD671544@google.com> References: <20260519090135.1188405-1-manikandan.m@microchip.com> <20260519090135.1188405-7-manikandan.m@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260519090135.1188405-7-manikandan.m@microchip.com> On Tue, 19 May 2026, Manikandan Muralidharan wrote: > Define ATMEL_XLCDC_CLKBYP and set the clock bypass bit on XLCDC > hardware when the computed divider is less than 2, avoiding an > invalid divider value. Non-XLCDC hardware retains the existing > minimum divider clamp of 2. > > Signed-off-by: Manikandan Muralidharan > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 7 +++++++ > include/linux/mfd/atmel-hlcdc.h | 1 + Acked-by: Lee Jones > 2 files changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > index 6da428361c19..f837684654ea 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > @@ -87,6 +87,13 @@ static int atmel_hlcdc_crtc_setup_clock(struct atmel_hlcdc_crtc *crtc, > > div = DIV_ROUND_CLOSEST(prate, mode_rate); > if (div < 2) { > + /* XLCDC: bypass divider when div < 2 */ > + if (crtc->dc->desc->is_xlcdc) { > + *cfg |= ATMEL_XLCDC_CLKBYP; > + *mask |= ATMEL_XLCDC_CLKBYP; > + return 0; > + } > + /* Enforce minimum divider for non-XLCDC */ > div = 2; > } else if (ATMEL_HLCDC_CLKDIV(div) & ~ATMEL_HLCDC_CLKDIV_MASK) { > /* The divider ended up too big, try a lower base rate. */ > diff --git a/include/linux/mfd/atmel-hlcdc.h b/include/linux/mfd/atmel-hlcdc.h > index 8e86219293b7..1463c7db0e64 100644 > --- a/include/linux/mfd/atmel-hlcdc.h > +++ b/include/linux/mfd/atmel-hlcdc.h > @@ -44,6 +44,7 @@ > #define ATMEL_XLCDC_HEO_UPDATE BIT(3) > > #define ATMEL_HLCDC_CLKPOL BIT(0) > +#define ATMEL_XLCDC_CLKBYP BIT(1) > #define ATMEL_HLCDC_CLKSEL BIT(2) > #define ATMEL_HLCDC_CLKPWMSEL BIT(3) > #define ATMEL_HLCDC_CGDIS(i) BIT(8 + (i)) > -- > 2.25.1 > -- Lee Jones