From: Jakub Kicinski <kuba@kernel.org>
To: David Thompson <davthompson@nvidia.com>
Cc: "bryan.whitehead@microchip.com" <bryan.whitehead@microchip.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: lan743x: avoid netdev-based logging before netdev registration
Date: Wed, 27 May 2026 14:56:01 -0700 [thread overview]
Message-ID: <20260527145601.512dbce9@kernel.org> (raw)
In-Reply-To: <SJ0PR12MB8113B58970F2E9B7A6EA5B75C7082@SJ0PR12MB8113.namprd12.prod.outlook.com>
On Wed, 27 May 2026 17:27:13 +0000 David Thompson wrote:
> While preparing v2, I realized it makes more sense to add a module
> parameter to control the initial value of msg_enable, instead of
> hardcoding it during probe. I'll update v2 to include this change,
> which means I'll also need to keep the checks that were previously
> always true.
Sigh, no. Please don't perpetuate this stupid log categorization.
The module param is not present, that means nobody needs it.
Also when you repost please target net-next and drop the Fixes tag.
I don't think it will make the cut as a fix given Linus's message
from -rc5 announcement.
next prev parent reply other threads:[~2026-05-27 21:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 21:52 [PATCH net] net: lan743x: avoid netdev-based logging before netdev registration David Thompson
2026-05-20 1:41 ` Jakub Kicinski
2026-05-20 19:59 ` David Thompson
2026-05-27 17:27 ` David Thompson
2026-05-27 21:56 ` Jakub Kicinski [this message]
2026-05-28 14:36 ` David Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527145601.512dbce9@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.