From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org,
richardcochran@gmail.com, yangbo.lu@nxp.com, kuniyu@google.com,
willemb@google.com
Subject: Re: [PATCH net] ethtool: vclock: propagate errors from ptp_get_vclocks_index()
Date: Wed, 27 May 2026 17:44:37 -0700 [thread overview]
Message-ID: <20260527174437.5b48187d@kernel.org> (raw)
In-Reply-To: <20260526153650.2779821-1-kuba@kernel.org>
On Tue, 26 May 2026 08:36:50 -0700 Jakub Kicinski wrote:
> ptp_get_vclocks_index() was written with sock_timestamping_bind_phc()
> in mind. Any return <= 0 will get converted to EINVAL by the virtue
> of sock_timestamping_bind_phc() not finding a matching vclock.
Sashiko points out that dump needs to skip over devices without vclock
cleanly. I'll respin.
--
pw-bot: cr
prev parent reply other threads:[~2026-05-28 0:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 15:36 [PATCH net] ethtool: vclock: propagate errors from ptp_get_vclocks_index() Jakub Kicinski
2026-05-26 18:46 ` Willem de Bruijn
2026-05-26 23:34 ` Matthieu Baerts
2026-05-28 0:44 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527174437.5b48187d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=willemb@google.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.