From: Alexander Shiyan <eagle.alexander923@gmail.com>
To: barebox@lists.infradead.org
Cc: Miaoqian Lin <linmq006@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Alexander Shiyan <eagle.alexander923@gmail.com>
Subject: [PATCH] clk: rockchip: Fix error pointer check after rockchip_clk_register_gate_link()
Date: Thu, 28 May 2026 15:15:30 +0300 [thread overview]
Message-ID: <20260528121532.1242489-1-eagle.alexander923@gmail.com> (raw)
From: Miaoqian Lin <linmq006@gmail.com>
Replace NULL check with IS_ERR_OR_NULL() check after calling
rockchip_clk_register_gate_link() since this function
returns error pointers (ERR_PTR).
Fixes: c62fa612cfa6 ("clk: rockchip: implement linked gate clock support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://patch.msgid.link/20250805030358.3665878-1-linmq006@gmail.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
---
drivers/clk/rockchip/clk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
index 987c3bc518..d01574c60b 100644
--- a/drivers/clk/rockchip/clk.c
+++ b/drivers/clk/rockchip/clk.c
@@ -566,7 +566,7 @@ void rockchip_clk_register_late_branches(struct device *dev,
break;
}
- if (!pdev)
+ if (IS_ERR_OR_NULL(pdev))
dev_err(dev, "failed to register device for clock %s\n", list->name);
}
}
--
2.52.0
next reply other threads:[~2026-05-28 12:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 12:15 Alexander Shiyan [this message]
2026-05-28 12:15 ` [PATCH] clk: rockchip: rk3568: Add PCIe pipe clock gates Alexander Shiyan
2026-05-29 11:43 ` Sascha Hauer
2026-05-29 11:43 ` Sascha Hauer
2026-05-28 12:46 ` [PATCH] clk: rockchip: Fix error pointer check after rockchip_clk_register_gate_link() Sascha Hauer
2026-05-29 11:43 ` (subset) " Sascha Hauer
-- strict thread matches above, loose matches on Subject: below --
2025-08-05 3:03 Miaoqian Lin
2025-08-05 3:03 ` Miaoqian Lin
2026-01-09 20:42 ` Heiko Stuebner
2026-01-09 20:42 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528121532.1242489-1-eagle.alexander923@gmail.com \
--to=eagle.alexander923@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=heiko@sntech.de \
--cc=linmq006@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.